[Kyu67]

I am trying to hook an event for a person joining the server, when they are alive and have control over a character. In other words, I don't want anything to happen until the person who joined is not spectating, and is alive (not dead).

"player_spawn" fires when somebody joins, even if they are dead. So I hooked player_spawn and then did a check using GetClientHealth

PHP Code:

public void playerspawn(Event event, const char[] name, bool dontBroadcast)
{

int userid = GetEventInt(event, "userid");
int clientid = GetClientOfUserId(userid);

PrintToChatAll("clientID %i (%N) spawned; health %i", clientid, clientid, GetClientHealth(clientid));

if (GetClientHealth(clientid) >= 1){
//Should only happen if the person is alive.. Assuming GetClientHealth reports correct values (which it doesn't appear to be doing)
}
} 


With the 3 bots dead, someone joined and the health of their dead character (Coach) was reported as 1 (not 0). Then, they left the game, and "player_spawn" fired again this time saying the dead Coach had 100 health (even though it was still dead). The only time it appeared to work correctly was when the round first began and everyone was alive, it reported everyone (me and the 3 bots) had 100 health.

Can anyone think of a better way to do this since GetClientHealth doesn't appear to be reporting correct values all the time?

[Silvers]

There is a takeover_bot event or something similar named, view: https://wiki.alliedmods.net/Left_4_dead_2_events

Health maybe 100 even when dead, do IsPlayerAlive(). Or you could create a 0.1 timer to check if alive.

This seems odd, why event spawn dead.

[Psyk0tik]

Why not just use a check for alive human survivors?

PHP Code:

stock bool bHasIdlePlayer(int client)
{
    int iIdler = GetClientOfUserId(GetEntData(client, FindSendPropInfo("SurvivorBot", "m_humanSpectatorUserID")));
    if (iIdler)
    {
        if (IsClientInGame(iIdler) && !IsFakeClient(iIdler) && (GetClientTeam(iIdler) != 2))
        {
            return true;
        }
    }

    return false;
}

stock bool bIsHumanSurvivor(int client)
{
    return (client > 0 && client <= MaxClients && IsClientInGame(client) && GetClientTeam(client) == 2 && IsPlayerAlive(client) && !IsClientInKickQueue(client) && !IsFakeClient(client) && !bHasIdlePlayer(client) && !bIsPlayerIdle(client));
}

stock bool bIsPlayerIdle(int client)
{
    for (int iPlayer = 1; iPlayer <= MaxClients; iPlayer++)
    {
        if (!IsClientInGame(iPlayer) || GetClientTeam(iPlayer) != 2 || !IsFakeClient(iPlayer) || !bHasIdlePlayer(iPlayer))
        {
            continue;
        }

        int iIdler = GetClientOfUserId(GetEntData(iPlayer, FindSendPropInfo("SurvivorBot", "m_humanSpectatorUserID")));
        if (iIdler == client)
        {
            return true;
        }
    }

    return false;
} 


Use it like this inside player_spawn event:

PHP Code:

if (bIsHumanSurvivor(client))
{
    // code here;
} 


[Visual77]

Player_spawn. Validate the client index and make sure the client is InGame. Check if client is in team 2 or 3 (GetClientTeam) (surv,inf) and validate if player is alive (IsPlayerAlive == true).

You took a complicated move by checking their health.

[MasterMind420]

Use player_activate hook instead