[AtomicStryker]

Not meant personal but wow that code is bad.


Why on earth use a IsConnected global array when IsClientConnected checks the game internal array.

Why is the update timer on 0.1 seconds, is that for a high velocity glide map

There is multiple redundancies, like, you loop from 1 to MaxClients, only to check if its > 0 and < MaxClients in the next function

You dont need to check if a client is a valid edict

You dont need to check Conncted, InGame, and Authorized all ... Ingame is entirely enough

[BAILOPAN]

kossolax: I'd address AtomicStryker's comments - they're spot on. But either way, what OS are you crashing on? If it's Windows, please send a .mdmp to [email protected]. If it's Linux, do you have shell access?

[databomb]

Fyren, sorry, that came out wrong.. the client-side mute code is good, I just meant that it didn't seem relevant to the problem we're having. We can ignore it since no plugins use the client-side mute discovery to do anything AFAIK.

I couldn't have coded the voice.cpp, just drawing parallels to mani which I know has a functioning dead all talk system. The major differences seemed the time and manner in which VoiceServer was hooked and the ClientDisconnect code.

The Dead All Talk plugins and 'proximity talk' plugins that have been attempted all have these symptoms:
http://forums.alliedmods.net/showthread.php?p=673586
and my attempt
http://forums.alliedmods.net/showthread.php?t=148069

Use the plugin on a server with more than 7 players and wait sometimes 45 minutes and the VoiceServer seems to unhook and no future over-rides are processed. I'm running a linux box with shell access and would love to know if there's anyway I can debug this further because, as was already stated, we don't see any errors in the logs.

[zeroibis]

To be more clear the issue is also present on windows the plugin I made is attached to this post and I have yet to get any errors despite having the same issue of it randomly breaking.

[kossolax]

Originally Posted by BAILOPAN kossolax: I'd address AtomicStryker's comments - they're spot on. But either way, what OS are you crashing on? If it's Windows, please send a .mdmp to [email protected]. If it's Linux, do you have shell access?

I'm on linux ubuntu 10.4, and I have shell acces. But server is not crashing, so I don't know if there is a crash somewhere.

Originally Posted by AtomicStryker Why on earth use a IsConnected global array when IsClientConnected checks the game internal array.

That code was a fix attemp to be sure the player is really in game, to edit the listen flag.

Originally Posted by AtomicStryker There is multiple redundancies, like, you loop from 1 to MaxClients, only to check if its > 0 and < MaxClients in the next function

I usually use the IsValidClient from a personnal include, so I haven't check it about that

Originally Posted by AtomicStryker You dont need to check if a client is a valid edict You dont need to check Conncted, InGame, and Authorized all ... Ingame is entirely enough

I've added much check to prevent crash, but I didn't know about that, thanks.

[AtomicStryker]

Here, look at this.

I've used SetListenOverride in Snaretalk Plugins and never experienced any crashes with it. I think your brutal 0.1 timer simply overloaded the engine after a time.

PHP Code:

#pragma semicolon 1

#include <sourcemod>
#include <sdktools>

const Float:CHECK_INTERVAL    = 1.0;
const Float:MAX_AREA_DIST     = 500.0;

public OnPluginStart()
{
    CreateTimer(CHECK_INTERVAL, Timer_UpdateListeners, _, TIMER_REPEAT);
}

public Action:Timer_UpdateListeners(Handle:timer)
{
    for (new client = 1; client <= MaxClients; client++)
    {
        if(!IsClientInGame(client)
        || IsFakeClient(client))
        {
            continue;
        }
        
        IsPlayerAlive(client) ? check_area(client) : check_dead(client);
    }
}

static check_area(client)
{
    decl Float:originA[3], Float:originB[3];

    for (new i = 1; i <= MaxClients; i++)
    {
        if(i == client
        || !IsClientInGame(i)
        || IsFakeClient(i))
        {
            continue;
        }
        
        GetClientAbsOrigin(client, originA);
        GetClientAbsOrigin(i, originB);
        
        if(IsPlayerAlive(i)
        && GetVectorDistance(originA, originB) < MAX_AREA_DIST)
        {    //In Range
            SetListenOverride(client, i, Listen_Yes);
        }
        else
        {    //Out of Range or Dead
            SetListenOverride(client, i, Listen_No);
        }
    }
}

static check_dead(client)
{
    for (new i = 1; i <= MaxClients; i++)
    {
        if(i == client
        || !IsClientInGame(i)
        || IsFakeClient(i))
        {
            continue;
        }
        
        SetListenOverride(client, i, Listen_No);
    }
} 


[kossolax]

I've already tried to change. But it has no effect, still crash.
Even with 2.5, or 5.0 Interval.

It doesn't even changing how often it crash.

[databomb]

zeroibis and myself don't use timers and we experience the VoiceServer error. When kossolax said "crashing" earlier, he just means that VoiceServer no longer works. (Overrides and client listen flags (even mutes) no longer function.) Atomic, I've looked over the snaretalk plugins. As I've said already, a plugin with a *small* number of over-rides such as this or Admin Setinel seem to work. When you start doing over-rides in for loops for all clients on spawn and death (or in timers), the VoiceServer becomes inoperable after some time.

[kossolax]

To add info, VoiceServer, as you tell it, has a problem in Source-Mod side.

If you set : sv_voiceenable 0: Voice are fully mutted.
If you set back to 1, SetListenOverride still not working correctly.

[zeroibis]

Correct, regardless of the method used between any of out plugins. It randomly stops working after some time without producing any errors or crashing. My print outs still occur so I know as a fact that the mod is running and functioning correctly. It is the SetLIstenOverride command that stops working.

This as stated previously IS a problem with SOURCEMOD. While we can help to try to pinpoint it the issue can really only be solved by the SOURCEMOD developers. Hopefully we can attract their attention and get to the bottom of this.