[Zyten]

Looking for plugin to swap from ct to t after round end by command !swapmeroundend

[mug1wara]

If I got this right. When someone types !swapmeroundend, the swap function is enabled. When the round ends and the swap function is enabled, it will switch the player to the opposit team. If the swap function is disabled, it won't switch on round end?

PHP Code:

#include <sourcemod> 

#pragma semicolon 1 

bool g_bAllowed[MAXPLAYERS + 1]; 

public void OnPluginStart() 
{ 
    HookEvent("round_end", Event_End); 
     
    RegConsoleCmd("sm_swapmeroundend", Cmd_Swap); 
} 

public void OnClientDisconnect(int iClient)
{
    g_bAllowed[iClient] = false;
}

public Action Event_End(Event hEvent, const char[] sName, bool bDontBroadcast) 
{ 
    for (int i = 1; i <= MaxClients; i++)
    {
        if (IsClientInGame(i))
        {
            if (g_bAllowed[i])
            {
                if (GetClientTeam(i) == 3)
                {
                    ChangeClientTeam(i, 2);
                }
                
                g_bAllowed[i] = false;
            }
        }
    }
} 

public Action Cmd_Swap(int iClient, int iArgs) 
{ 
    if (g_bAllowed[iClient]) 
        g_bAllowed[iClient] = false; 
         
    else 
        g_bAllowed[iClient] = true; 

    return Plugin_Handled; 
} 


[Rohanlogs]

Originally Posted by mug1wara If I got this right. When someone types !swapmeroundend, the swap function is enabled.

Eh, no I'm pretty sure he wants this command to be available in a public server, which means you're going to need to make that bool indexed.
Because that will not work in a mass of people.

Edit: Also because of that, its probably going to swap the whole server.

Edit2: I'm also pretty sure round end fires only once and there is no index passed. You need to make a loop.

[mug1wara]

PHP Code:

#include <sourcemod> 

#pragma semicolon 1 

bool g_bAllowed[MAXPLAYERS + 1]; 

public void OnPluginStart() 
{ 
    HookEvent("round_end", Event_End); 
     
    RegConsoleCmd("sm_swapmeroundend", Cmd_Swap); 
} 

public void OnClientDisconnect(int iClient)
{
    g_bAllowed[iClient] = false;
}

public Action Event_End(Event hEvent, const char[] sName, bool bDontBroadcast) 
{ 
    for (int i = 1; i <= MaxClients; i++)
        if (IsClientInGame(i))
            if (g_bAllowed[i])
                if (GetClientTeam(i) == 3) 
                    ChangeClientTeam(i, 2);
} 

public Action Cmd_Swap(int iClient, int iArgs) 
{ 
    if (g_bAllowed[iClient]) 
        g_bAllowed[iClient] = false; 
         
    else 
        g_bAllowed[iClient] = true; 

    return Plugin_Handled; 
} 


[Rohanlogs]

Originally Posted by mug1wara oh yea, forgot to index the bool xD also looped through clients with the active bool ty

Now when players disconnect and new players connect, some random people will have g_bAllowed true. You need to make sure when they connect/disconnect that its set to false. When you loop through clients and execute functions on them, you need to make sure the client is valid. After that take another look at the posters request.

[Rohanlogs]

Something more like this:

Spoiler

PHP Code:

#include <sourcemod>
#include <colors>

#pragma semicolon 1
#pragma newdecls required

bool g_bSwapMe[MAXPLAYERS + 1];


public void OnPluginStart()
{
    RegConsoleCmd("sm_swapmeroundend", fwSwapMe);
    HookEvent("round_end", Event_RoundEnd_Post, EventHookMode_Post);
}


public void OnClientPostAdminCheck(int iClient)
{
    g_bSwapMe[iClient] = false;
}


public void OnClientDisconnect(int iClient)
{
    g_bSwapMe[iClient] = false;
}


public Action fwSwapMe(int iClient, int iArgs)
{
    if( GetClientTeam(iClient) != 3 )
    {
        CPrintToChat(iClient, "[{olive}SwapMe{default}] This is only for CTs.");
        return Plugin_Handled;
    }
        
    if( !g_bSwapMe[iClient] )
    {
        g_bSwapMe[iClient] = true;
        CPrintToChat(iClient, "[{olive}SwapMe{default}] You'll be swapped to terrorists after this round.");
    } else {
        g_bSwapMe[iClient] = false;
        CPrintToChat(iClient, "[{olive}SwapMe{default}] Swap cancelled.");
    }
    return Plugin_Continue;
}


public Action Event_RoundEnd_Post( Event eEvent, const char[] szName, bool bDontBroadcast )
{
    for(int i = 1; i <= MaxClients; i++) 
    {
        if( IsValidClient(i) && g_bSwapMe[i] && GetClientTeam(i) == 3 ) //Client is valid, client wants a swap and client is a CT.
        {
            g_bSwapMe[i] = false;
            
            ChangeClientTeam(i, 2); 
            CPrintToChat(i, "[{olive}SwapMe{default}] You've been swapped due to your request.");
        } 
        
        else if( g_bSwapMe[i] ) //Client maybe already switched to terrorists.
            g_bSwapMe[i] = false;
    }
}


stock bool IsValidClient(int iClient) 
{ 
    if (iClient <= 0) 
        return false; 
    
    if (iClient > MaxClients) 
        return false; 
    
    if ( !IsClientConnected(iClient) ) 
        return false; 
    
    return IsClientInGame(iClient); 
} 


Note that the team index is mod-specific.
This will work for CS:GO which is what the poster is running.
For CS:GO CT is 3 and T = 2.

[KlausLaw]

bool g_getSwapped[MAXPLAYERS + 1];

public void OnPluginStart()
{
	RegConsoleCmd("sm_swapmeroundend", SM_Swapme);
	HookEvent("round_end", Event_Round_End);
}

public OnClientDisconnect(int client)
{
	g_getSwapped[client] = false;
}

public Action SM_Swapme(int client, int args)
{
	if (GetClientTeam(client) == CS_TEAM_T)
	{
		PrintToChat(client, "You can only use this command in the \x04CT\x01 team.");
		return Plugin_Handled;
	}
	g_getSwapped[client] = !g_getSwapped[client];
	PrintToChat(client, "You will now be \x04%s\x01 to team \x04t\x01.", g_getSwapped[client] ? "swapped" : "unswapped");
	return Plugin_Handled;
}

public Action Event_Round_End(Event event, const char[] name, bool dontBroadcast)
{
	for (int i = 1; i <= MaxClients; i++)
	{
		if (!IsClientInGame(i) || !g_getSwapped[i])continue;
		g_getSwapped[i] = false;
		if (GetClientTeam(i) == CS_TEAM_T)continue;
		ChangeClientTeam(i, CS_TEAM_T);		
	}
}

[mug1wara]

Better using OnClientAuthorized, rather than OnClientPostAdminCheck.

Also @Klaus "g_getSwapped[client] = !g_getSwapped[client];"
Better to check the value of the bool than make it equal to false. Because it will never remain true. If so, why even have a boolean?

This is how I would do it, tested and working well.

PHP Code:

#include <sourcemod> 

#pragma semicolon 1 

bool g_bAllowed[MAXPLAYERS + 1]; 

public void OnPluginStart() 
{ 
    HookEvent("round_end", Event_End); 
     
    RegConsoleCmd("sm_swapmeroundend", Cmd_Swap); 
} 

public void OnClientDisconnect(int iClient)
{
    g_bAllowed[iClient] = false;
}

public Action Event_End(Event hEvent, const char[] sName, bool bDontBroadcast) 
{ 
    for (int i = 1; i <= MaxClients; i++)
    {
        if (IsClientInGame(i))
        {
            if (g_bAllowed[i])
            {
                if (GetClientTeam(i) == 3)
                {
                    ChangeClientTeam(i, 2);
                }
                
                g_bAllowed[i] = false;
            }
        }
    }
} 

public Action Cmd_Swap(int iClient, int iArgs) 
{ 
    if (g_bAllowed[iClient]) 
        g_bAllowed[iClient] = false; 
         
    else 
        g_bAllowed[iClient] = true; 

    return Plugin_Handled; 
} 


[KlausLaw]

Originally Posted by mug1wara Also @Klaus "g_getSwapped[client] = !g_getSwapped[client];" Better to check the value of the bool than make it equal to false. Because it will never remain true. If so, why even have a boolean?

g_getSwapped[client] = !g_getSwapped[client];
Doesn't change the value to false, it changes the value to the opposite value.

[mug1wara]

It doesn't really work like that Klaus. Let me explain for you.

PHP Code:

g_bSomething = !g_bSomething; /* g_bSomething WILL equal to FALSE if set to true */

if (!g_bSomething){} /* IF the value is FALSE */ 


https://wiki.alliedmods.net/Tags_(Scripting)#Boolean