[Xiaobaibai]

[Purpose]
When we create entities, the general method is just like:

new iEntity = engfunc(EngFunc_CreateNamedEntity, engfunc(EngFunc_AllocString, "info_target"));

When we use some fakemeta natives such as set_pev, the module automatically calls EngFunc_AllocString to put the string into the memory.

Notice the EngFunc_AllocString, it acts just like : new char[strlen(szValue)+1];
But without delete operation.
This unlimited allocing operation will finally lead to Cache_TryAlloc error and then the server crashes.

[Method]
So here we'd better to recycle those string pointers.
1.Hook EngFunc_AllocString
2.Puts new string to memory using original call and store the result
3.When we need the same string, return the result from previous call

[Installion]
Since register_forward can't hook calls from engfunc, orpheu(or other module) is need, which can be downloaded in https://forums.alliedmods.net/showthread.php?t=116393

Download x_stringman.sma and compile it...and install it.

And you need the function information(no need for signature), put AllocString file into cstrike/addons/amxmodx/configs/orpheu/functions

[CVARs and configs]
None.

[Changelog]
ver 1.1: Destroy Trie in plugin_end()

[543658883]

nice work buddy

[JusTGo]

i have newbie question lets say the game have both this line codes:

PHP Code:

pev->noiseMoving = ALLOC_STRING("common/null.wav");
.
.
.
pev->noiseArrived = ALLOC_STRING("common/null.wav"); 


does this mean we can hook FM_AllocString and do the same so it will be allocated only once ? and in other places where ALLOC_STRING is used more then once in some forwards.

[Xiaobaibai]

Originally Posted by JusTGo i have newbie question lets say the game have both this line codes: PHP Code: pev->noiseMoving = ALLOC_STRING("common/null.wav"); . . . pev->noiseArrived = ALLOC_STRING("common/null.wav");  does this mean we can hook FM_AllocString and do the same so it will be allocated only once ? and in other places where ALLOC_STRING is used more then once in some forwards.

Yeah. However, FM_AllocString cannot hook calls from fakemeta like engfunc(EngFunc_AllocString, "info_target");

It can only hook those from mp.dll and so on but not from amxx using fakemeta.

[HamletEagle]

For approval:
-destroy the trie in plugin_end.

[Xiaobaibai]

Originally Posted by HamletEagle For approval: -destroy the trie in plugin_end.

Done

[HamletEagle]

Approved. I like the ideea.

[baneado]

Originally Posted by HamletEagle For approval: -destroy the trie in plugin_end.

Is It really necessary to do?
When a map changes, trie Will be destroyed, no?

[HamletEagle]

Originally Posted by baneado Is It really necessary to do? When a map changes, trie Will be destroyed, no?

I remember Arkshine saying that in amxx < 183 it's not guaranteed to be destroyed. Anyway, you should always free all handles that you use, no matter what.

[baneado]

So, reading more about this plugin:

Originally Posted by Xiaobaibai Notice the EngFunc_AllocString, it acts just like : new char[strlen(szValue)+1]; But without delete operation. This unlimited allocing operation will finally lead to Cache_TryAlloc error and then the server crashes.

It only be useful when you are creating entities with fakemeta.
Will It never happen using create_entity with engine?

If so, It must be fixed on fakemeta core...