[stupok]

I appreciate your attitude

Now I understand what I'm doing, but I don't have time to post my results from my latest test.

I'm searching the list of 14,000 steamids 1,000 times and finding that the cellTrie method is 4 to 5 orders of magnitude faster than the cellArray method. When searching the list only once, the profiler measures the cellTrie time as 0.000001. That's impressive!

[joaquimandrade]

Originally Posted by stupok I appreciate your attitude Now I understand what I'm doing, but I don't have time to post my results from my latest test. I'm searching the list of 14,000 steamids 1,000 times and finding that the cellTrie method is 4 to 5 orders of magnitude faster than the cellArray method. When searching the list only once, the profiler measures the cellTrie time as 0.000001. That's impressive!

For what i read in wikipedia, the performance of searching in a trie is O(length of the string) while iterating over all values of an array is O(number of strings it contains).

That means that, in this case, the longer the list the bigger the difference.

I tried with your list 10000 times and while the celltrie results were almost the same, with cellarray my windows halted.

[Exolent[jNr]]

Honestly, I never knew what a trie was. I just assumed that it was a different word for array. This is very useful information and I plan on using tries in the future.

[joaquimandrade]

Originally Posted by Exolent[jNr] Honestly, I never knew what a trie was. I just assumed that it was a different word for array. This is very useful information and I plan on using tries in the future.

That's normal. You probably started amxx programming without having prior knowledge in programming. I know that because i've studied it.
I recommend you to use tries in your "Advanced Bans".

[Exolent[jNr]]

I started converting it into Tries, and it is so much less code instead of using Arrays.
However, there is one disadvantage: I can't view the keys for my amx_banlist command so I cannot list the banned players.
I would have to create Arrays inside that command, read the file to fill the Arrays, then print the ones that were specified.
Should I keep doing Tries and do what I said above, or keep it as Arrays?

[joaquimandrade]

Originally Posted by Exolent[jNr] I started converting it into Tries, and it is so much less code instead of using Arrays. However, there is one disadvantage: I can't view the keys for my amx_banlist command so I cannot list the banned players. I would have to create Arrays inside that command, read the file to fill the Arrays, then print the ones that were specified. Should I keep doing Tries and do what I said above, or keep it as Arrays?

You are saying that:

For amx_banlist you need to list all the steam Ids?

If yes, use both. Fill both a trie and a an array with the steamIDs when you load the ban list. Then, to search use the trie, to iterate use the array. It will waste more memory but it will be much faster.

[Exolent[jNr]]

Well, now that I got further into the plugin, I also need the list to save the bans and to check which ones are time to be unbanned.
So, you think I should have both? Because that seems unnecessary.

[joaquimandrade]

Originally Posted by Exolent[jNr] Well, now that I got further into the plugin, I also need the list to save the bans and to check which ones are time to be unbanned. So, you think I should have both? Because that seems unnecessary.

Yes, try to see if you can get a way to use both. Then, to see the difference, profile both versions.

Edit:

You can make it like this:

PHP Code:

new Array:arrayBanList
new Trie:trieBanList

new arraySize

public plugin_init()
{
    register_plugin(PLUGIN, VERSION, AUTHOR)
}

public plugin_cfg()
{
    arrayBanList = ArrayCreate(34)
    trieBanList = TrieCreate();
}

isBanned(steamID[])
{
    return TrieKeyExists(trieBanList,steamID);
}

addBanToList(steamID[])
{
    ArrayPushString(arrayBanList,steamID)
    TrieSetCell(trieBanList,steamID,arraySize++);
}

removeBanFromList(steamID[])
{
    new item
    TrieGetCell(trieBanList,steamID,item)
    ArrayDeleteItem(arrayBanList,item);
    TrieDeleteKey(trieBanList,steamID)
    arraySize--

} 


[ot_207]

Interesting, this reminds me of collage. I will study these things soon, so I will have an advantage.
It's good to start with pawn when you want to become a programmer, cause you learn how to get used to with functions and programming.
GJ.

[joaquimandrade]

Let me add that "Advanced Bans (Real Time) by Exolent" know uses tries. I thought that Exolent would give up on using them (since they were giving some trouble to implement) but, not only he implemented them as, he made it very nicely.