[PvtSmithFSSF]

X-olent you rock

[Lee]

Originally Posted by X-olent retrieve would also have to be a constant number.

I haven't said anything really stupid for a while. I guess it was due.

[joaquimandrade]

This line is nice:

PHP Code:

for( new rand = random(total); count < retrieve; rand = random(total) ) 


About the rest:

You dont need to re-sort the initial array since if you want to get a random group of players you wont use it anymore. So you can do it like this:

PHP Code:

for( new rand = random(total); count < retrieve; rand = random(total) )
{
    selected[count++] = players[rand];    
    players[rand] = player[--total]
} 


[stupok]

Originally Posted by joaquimandrade PHP Code: for( new rand = random(total); count < retrieve; rand = random(total) ) {     selected[count++] = players[rand];         players[rand] = player[--total] }

It's really annoying for me to process this with my feeble brain, so I'm going to outline an example for myself (and others that want to understand the code).

EDIT: the below has been fixed

Simplified:

new players[3] = {1,2,3}
new selected[3]
new count = 0
new retrieve = 3
new total = 3

// random(3) returns 0, 1, or 2

for( new rand = random(total); count < retrieve; rand = random(total) )
{
    selected[count++] = players[rand];    
    players[rand] = players[--total]
}

/* Here we go!

ITERATION 1

rand = 2, count = 0 and 0 < 3, (rand can be 0, 1, or 2)
selected[count] = players[rand], selected[0] = players[2], so selected[0] = 3
count = 1
total = 2
players[rand] = players[total], players[2] = players[2], so players[2] = 3

ITERATION 2

rand = 1, count = 1 and 1 < 3, (rand can be 0 or 1)
selected[count] = players[rand], selected[1] = players[1], so selected[1] = 2
count = 2
total = 1
players[rand] = players[total], players[1] = players[1], so players[1] = 2

ITERATION 3

rand = 0, count = 2 and 2 < 3, (rand can be 0)
selected[count] = players[rand], selected[2] = players[0], so selected[2] = 1
count = 3
total = 0
players[rand] = players[total], players[0] = players[0], so players[0] = 1

END

count = 3 and 3 < 3 is false

selected is {3,2,1}
*/

Unless I've overlooked something, selected[2] ends with the same value as selected[0], so this code won't work.

[joaquimandrade]

Originally Posted by stupok It's really annoying for me to process this with my feeble brain, so I'm going to outline an example for myself (and others that want to understand the code). Simplified: Code: new players[3] = {1,2,3} new selected[3] new count = 0 new retrieve = 3 new total = 3 // random(3) returns 0, 1, or 2 for( new rand = random(total); count < retrieve; rand = random(total) ) { selected[count++] = players[rand]; players[rand] = players[--total] } /* Here we go! ITERATION 1 rand = 2, count = 0 and 0 < 3 selected[count] = players[rand], selected[0] = players[2], so selected[0] = 3 count = 1 total = 2 players[rand] = players[total], players[2] = players[2], so players[2] = 3 ITERATION 2 rand = 1, count = 1 and 1 < 3 selected[count] = players[rand], selected[1] = players[1], so selected[1] = 2 count = 2 total = 1 players[rand] = players[total], players[1] = players[1], so players[1] = 2 ITERATION 3 rand = 2, count = 2 and 2 < 3 selected[count] = players[rand], selected[2] = players[2], so selected[2] = 3 count = 3 total = 0 players[rand] = players[total], players[2] = players[0], so players[2] = 1 END count = 3 and 3 < 3 is false */ Unless I've overlooked something, selected[2] ends with the same value as selected[0], so this code won't work.

The total is decreasing so in the last iteration you can't have random = 2. It will be always 0.

Edit: I mean, it will always be 0 when the initial total = retrieve

[stupok]

So, I did overlook something. Damn, this code is good.

[Emp`]

Originally Posted by joaquimandrade PHP Code: for( new rand = random(total); count < retrieve; rand = random(total) ) {     selected[count++] = players[rand];         players[rand] = player[--total] }

Instead of a kind of "ugly" for loop, I prefer:

PHP Code:

new rand;
do {
    rand = random(total);
    selected[count++] = players[rand];    
    players[rand] = player[--total];
}
while( count < retrieve ) 


It's purely stylistic but IMO it looks much better.

[joaquimandrade]

Originally Posted by Emp` Instead of a kind of "ugly" for loop, I prefer: PHP Code: new rand; do {     rand = random(total);     selected[count++] = players[rand];         players[rand] = player[--total]; } while( count < retrieve )  It's purely stylistic but IMO it looks much better.

I was thinking about that and in fact it is better like that. With the for loop it is done a unnecessary rand = random(total) in the end of the final iteration.

[jediZEr0]

How can I move the players with the retrieved IDs to a team?

[Exolent[jNr]]

If you are using Counter-Strike, you can use the cs_set_user_team() native.
http://www.amxmodx.org/funcwiki.php
http://www.amxmodx.org/funcwiki.php?...team&go=search