[)v(aster]

Hi

Not too sure what i've done wrong. When I use the sample plugin, I cant find a file created. And when I run the following, I see this in the sm log:
L 07/14/2008 - 05:07:59: [m_downloadtest.smx] $$$$

EDIT: Worked it out, need to read the string in the DownloadComplete callback, as it's threadded.

public DownloadComplete(const sucess, const status, Handle:arg)
{
    PrintToServer("DownloadComplete: %i %i",sucess, status);
    CloseHandle(down);
}
public Progress(const recvSize, const totalSize, Handle:arg)
...
 
public OnPluginStart()
{
    down = CreateDownloader();
 
    SetURL(down,"http://domain/file.php/");
 
    SetCallback(down,DownloadComplete);
    SetProgressCallback(down,Progress);
 
    new String:response[1000];
 
    SetOutputString(down,response,sizeof(response));
 
    Download(down);
 
    LogMessage("$$$$%s", response); 
}

[sskillz]

Reading the source code, I don't see it can handle cases that it may recieve the header in sevral calls to recv. Its possible that the first select and recv will get: "HTTP/" and the next call will get "/1.0 100 OK\r\nContent-Length:"
and the extension will ignore it.

And where do you check if the socket has been closed by the remote side? you should check if recv returns 0 to know if that happens.

[Agret]

Can this extension be used to simply check if a file exists and get the file size of it? It would be nice to be able to verify a map exists on the downloadurl and if not then clear the url

[MikeJS]

"[SM] Unable to load extension "downloader.ext.dll": Metamod attach failed"

If you could get this working again it would be great.

[exvel]

MikeJS, you can just use Sockets extension. You can find an example of how to download a file inside the sockets' package.

[MikeJS]

I've tried using sockets but sometimes it doesn't strip the header from the file and sometimes adds characters to the end. (http://pastebin.com/d2e33dfd9 - from line 136)

[p3tsin]

Originally Posted by MikeJS I've tried using sockets but sometimes it doesn't strip the header from the file and sometimes adds characters to the end. (http://pastebin.com/d2e33dfd9 - from line 136)

The header should be included only in the first packet.

On lines 158-159, pos will never be -1.

new pos = StrContains(receiveData, "\r\n\r\n")+4;
if(pos!=-1) {

Also, whats up with lines 161-163?

WriteFile(file, receiveData[pos], (dataSize-pos)/4, 4);
for(new i=((dataSize-pos)/4)*4;i<dataSize;i++)
    WriteFile(file, receiveData[i], 1, 1);

//I'd just do
for(new i=pos;i<dataSize;i++)
    WriteFile(file, receiveData[i], 1, 1);

[MikeJS]

Originally Posted by p3tsin The header should be included only in the first packet.

Ah, thanks.

Originally Posted by p3tsin On lines 158-159, pos will never be -1.

Originally Posted by p3tsin Also, whats up with lines 161-163? WriteFile(file, receiveData[pos], (dataSize-pos)/4, 4); for(new i=((dataSize-pos)/4)*4;i<dataSize;i++)     WriteFile(file, receiveData[i], 1, 1); //I'd just do for(new i=pos;i<dataSize;i++)     WriteFile(file, receiveData[i], 1, 1);

Copy pasta from the socket thread. (http://forums.alliedmods.net/showpos...0&postcount=95)

edit: Now I'm using

PHP Code:

new pos = StrContains(receiveData, "\r\n\r\n")+4, Handle:file = OpenFile(path, "ab");
for(new i=pos;i<dataSize;i++)
    WriteFile(file, receiveData[i], 1, 1); 


Now it misses a few characters from the beginning of some files. If I set it to be less than +4, it starts adding the line breaks.

[p3tsin]

Originally Posted by MikeJS edit: Now I'm using PHP Code: new pos = StrContains(receiveData, "\r\n\r\n")+4, Handle:file = OpenFile(path, "ab"); for(new i=pos;i<dataSize;i++)     WriteFile(file, receiveData[i], 1, 1);  Now it misses a few characters from the beginning of some files. If I set it to be less than +4, it starts adding the line breaks.

Well yeah, if StrContains returns -1, the loop will start from 3 ignoring the first few chars.

I'm using something like this:

new pos;

if(g_bFirstPacket) {    //g_bFirstPacket is obviously a global var that gets set to true when a new download is started
    g_bFirstPacket = false
    pos = StrContains(receiveData, "\r\n\r\n") + 4;
}

new Handle:file = OpenFile(path, "ab");
for(new i = pos; i < dataSize; i++) {
    WriteFile(file, receiveData[i], 1, 1);
}

[MikeJS]

Originally Posted by p3tsin Well yeah, if StrContains returns -1, the loop will start from 3 ignoring the first few chars.

My bad. It seems to be working now, thanks.

edit: Will I have to use an adt_array rather than a single g_bFirstPacket? (if the plugin tries to download more than one plugin at the same time)