[dustinandband]

Been testing some different methods since yesterday and I can't seem to find a way to directly test if a command requires admin flags or not.

It seems like GetCommandOverride() should be able to detect this but it doesn't. Any ideas?

PHP Code:

public Action OnClientCommand(int client, int args)
{
    // only bother if client's an admin
    if (!client || !IsClientInGame(client) || IsFakeClient(client) || GetUserAdmin(client) == INVALID_ADMIN_ID)
        return Plugin_Continue;
    
    char sCommand[64];
    GetCmdArg(0, sCommand, sizeof(sCommand));
    
    int flags;
    if (!GetCommandOverride(sCommand, Override_Command, flags) || flags == 0)
    {
        // not an admin command, skipping..
        return Plugin_Continue;
    }
    
    // admin command...
} 


[eyal282]

Originally Posted by dustinandband Been testing some different methods since yesterday and I can't seem to find a way to directly test if a command requires admin flags or not. It seems like GetCommandOverride() should be able to detect this but it doesn't. Any ideas? PHP Code: public Action OnClientCommand(int client, int args) {     // only bother if client's an admin     if (!client || !IsClientInGame(client) || IsFakeClient(client) || GetUserAdmin(client) == INVALID_ADMIN_ID)         return Plugin_Continue;          char sCommand[64];     GetCmdArg(0, sCommand, sizeof(sCommand));          int flags;     if (!GetCommandOverride(sCommand, Override_Command, flags) || flags == 0)     {         // not an admin command, skipping..         return Plugin_Continue;     }          // admin command... }

Admin commands will almost always have no overrides. An override just means the server changed the command's default flag through a config file.

Try GetCommandFlags

[dustinandband]

Originally Posted by eyal282 Admin commands will almost always have no overrides. An override just means the server changed the command's default flag through a config file. Try GetCommandFlags

I believe GetCommandFlags() is for FCVAR flags. I'm wanting to determine if a command is registered as an admin command (ADMFLAG_).

Also worth noting I don't think checkcommandaccess() would work either. I'm not interested in seeing if a client has access to a command, but rather looking at the command itself (what bitstrings it was registered with).

I guess if i was real desperate i could just log any commands that contain "sm_" in them but I rather not do it that way.

[eyal282]

Use the iterators, either google "sourcemod CommandIterator" or google info on "FindFirstConCmd"

[Psyk0tik]

You can check out the source code of this plugin to see how the author did it: https://forums.alliedmods.net/showthread.php?t=163780

[Balimbanana]

What about GetUserFlagBits(client) ? It gets the total bit sum of what admin flags the client has.
Along with:

bool CheckCommandAccess(int client, const char[] command, int flags, bool override_only)

[Psyk0tik]

Originally Posted by Balimbanana What about GetUserFlagBits(client) ? It gets the total bit sum of what admin flags the client has. Along with: bool CheckCommandAccess(int client, const char[] command, int flags, bool override_only)

He wants to check the flags of commands. Checking client flags won't give him the information he needs.

For example, a client can have root access (ADMFLAG_ROOT) but the command may only require ADMFLAG_SLAY.

[dustinandband]

Thanks guys!

I suppose the cleanest way to do this would be adding a command listener to all admin commands while iterating through them - like this plugin does, instead of iterating over all the commands every time you want to see if an admin used an admin-registered sourcemod command.

Hopefully in future versions of sourcemod there'll be a function for checking a command's admin bitstring directly instead of deploying these hacky work-arounds.