[surfhope]

Good afternoon guys,

I would like to know how I can work with some strings and a Subroutine. A
Subroutine which returns a string.

I have here one example, how I would do it.

The call:

PHP Code:

new String:query3[200];     
Format(query3, sizeof(query3), "SELECT ban_reason FROM smx_bans WHERE player_id = '%s' OR player_ip = '%s'", auth, ip); 
new len = sizeof(query3);
new String:banreason[200]; 
                    
banreason = queryToSting(db, query3[len]); 


The subroutine:

PHP Code:

String:queryToSting(Handle:db, const String:query[])
{
    new String:value[200];
    new Handle:place;
    Format(value, sizeof(value), "wrong");
    
    if((place = SQL_Query(db, query)) != INVALID_HANDLE)
    {
    
        if (SQL_FetchRow(place))
        {
            SQL_FetchString(place, 0, value, sizeof(value));
        }

    }

    CloseHandle(place);
    return value;
} 


Please tell me what's wrong/right and what I have to remove/add.

Thanks in advance
Hope

[berni]

What the hell is a subroutine ?

You can't return a string buffer, since the buffer you allocate in a function is only valid IN the function, when it returns the allocation will be freed.

That's why you have to allocate the buffer outside the function before you call it, and pass it in:

PHP Code:

// Allocate buffer & call function
decl String:banReason[200];
queryToSting(db, query3, banReason);

// Function
String:queryToSting(Handle:db, const String:query[], String:value[])
{
    // code 


[surfhope]

You find the explanation here:
http://en.wikipedia.org/wiki/Subroutine
;)

I normally program in c++ and there's called so

Anyway, big thanks for your help, answered my question

[berni]

Originally Posted by surfhope You find the explanation here: http://en.wikipedia.org/wiki/Subroutine ;) I normally program in c++ and there's called so Anyway, big thanks for your help, answered my question

A always call it a function in C++ never, never saw anyone calling it a subroutine in C++...