[Nightfall1]

- I am the Iron Man -

Description

• Autor: Night Dreamer - (Nightfall1)
• Help: bogdyutzu, Arkshine, Nextra, NiHiLaNTh
• Release Day: 31/12/2010
• Version: 1.2
• Info: Transform your self in iron man

Cvar's

• zp_extra_ironman.amxx http://www.game-monitor.com/search.p...&type=variable
  zp_iron_jump "700" - Who much it jump iron man
  zp_iron_damage "700" - Damage of iron man + Power Of Jump
  zp_iron_radius "400" - Radius of iron man for damage and knockback
  zp_iron_knockback "2" - Iron man knockback
  zp_iron_control "0" - Iron man can control in air

Changelog's

• 1.0 first release
  
• 1.1 Added knockback + optimization
  
• 1.2 Remove fakemeta_ultils, added fun, remove unnecessary stuffs, added new cvar (zp_iron_control), plugin optimization...
  

[gladius]

WOW! seriously you are Iron Man? I am kidding

[vato loco [GE-S]]

i am spongeman

but the description could be better...

[Nextra]

Code suggestions:
- Indent your code properly and consistently.
- Your makros are inefficient. You are calling the pev native too often using this method.
- Isn't zp for counter-strike only? If so, you should use the equivalent cstrike natives instead of the fakemeta_util conversions.
- The same for things like fm_halflife_time, why not use the core function?
- The same for fun natives. They are often faster than fakemeta conversions.
- Is there a special reason for mixing EngFunc_Write's with the standard write functions?
- Are you sure that calling reset_cvar on Ham_Spawn is what you want to do (remember that some users might spawn later into the round and reset_cvar will reset all players)?

This is all I can see right now. It's hard to read, really.

[Nightfall1]

What do you mean with "- Indent your code properly and consistently."
"- Your makros are inefficient." Why is inefficient ? Please tell my
"- Isn't zp for counter-strike only?" Yes is and i will update
fm_halflife_time equal with get_gametime
I will use fun in the next version
"- Is there a special reason for mixing EngFunc_Write's with the standard write functions?" NO
"Are you sure that calling reset_cvar on Ham_Spawn...." UPS

[Arkshine]

What do you mean with "- Indent your code properly and consistently."

He means instead of :

public reset_cvar()
{
	for(new i = 1; i <= g_maxplayer; i++)
	{
	g_IronJump[i] = false
	g_IronMan[i] = false
	}
}

->

public reset_cvar()
{
	for(new i = 1; i <= g_maxplayer; i++)
	{
	      g_IronJump[i] = false
	      g_IronMan[i] = false
	}
}

Please tell my

Your macros use pev_flags and are called together. You call several times pev_flags when it would be more appropriate to save the value one time before.

fm_halflife_time equal with get_gametime

It returns get_gametime(), so just call directly get_gametime().

"- Is there a special reason for mixing EngFunc_Write's with the standard write functions?"

There is a reason. He works with float, thus to avoid to do write_coord( floatround( ; it's more efficient to use EngFunc_WriteCoord.

[Nightfall1]

"Your macros use pev_flags and are called together. You call several times pev_flags when it would be more appropriate to save the value one time before. "
I still don't get it ?

[Arkshine]

When you have severals same calls, it's more appropriate to cache the value before. The less native you call the better is.

Instead of :

if( native() ... native() )
...
if( native() ... )

You do :

new value = native();

if( value ...
...
if( value ...

You get the idea.

[Nextra]

Originally Posted by Arkshine There is a reason. He works with float, thus to avoid to do write_coord( floatround( ; it's more efficient to use EngFunc_WriteCoord.

He does not, that's why I asked.

Originally Posted by Nightfall1 "Your macros use pev_flags and are called together. You call several times pev_flags when it would be more appropriate to save the value one time before. " I still don't get it ?

I'll show you.

PHP Code:

    new pointer_on_ground = (pointer_is_ironman && is_partialground(iron) || pointer_is_ironman && is_onground(iron))
    if((pointer_on_ground || is_inworld(iron)) && !is_inwater(iron)) 


You use is_partialground, is_onground, is_inworld and is_inwater.
Each of these makros calls pev(iron, pev_flags) and bit-checks a certain flag. This is inefficient. In this small excerpt alone you are calling pev(iron, pev_flags) four times although the value will and can not change during the function call. It would be much more efficient to do this (for example):

PHP Code:

#define is_onground(%1) (%1 & FL_ONGROUND)
#define is_partialground(%1) (%1 & FL_PARTIALGROUND)
#define is_inworld(%1) (%1 & FL_WORLDBRUSH)
#define is_inwater(%1) (%1 & FL_INWATER)

somefunction( id )
{
    new flags = pev(id, pev_flags);

    if(((is_onground(flags) || is_partialonground(flags)) || is_inworld(flags)) && !is_inwater(flags))
   {
   }
} 


/edit:
Also while I'm looking at it, you need to look at the conditionals in fw_IronTouch and the sequence of instructions.
- Don't get the cvar values and origin at the beginning. Only get them when you know you need them.
- At the beginning check every information you can already check directly. Check for g_IronMan, g_IronJump, is_user_alive and the weapon right at the beginning and abort the function if necessary.
- Then do all the flag checks.
- Then get all the cvar values, origins and do the rest of the instructions.

[Arkshine]

He does not, that's why I asked.

You're right. Just seen "pev" which is associated in my mind to float value.