[coolzie]

Cool plugin, works well. I do have a couple bugs to report however. After starting a Zeus Round there is a bug where your weapons, hands and all turn invisible. It usually fixes itself after a round or two. The other bug is sometimes you're given a free zeus the round after a zeus round.

Apart from that this is a really cool mod. I'd like to try a Zeus only server, can I do that with this plugin? That could be fun.

Thanks for your work and thanks for sharing! This plugin is great!

[TnTSCS]

The bug where your hands and weapons go invisible is probably after weapon stripping, you weren't issued a Zeus for some reason. I'll look at the code and improve the issuing of the Zeus.

I still need to add the Zeus toggle and after I add that, then yes, you could use this for a zeus only server.

[coolzie]

I remember ending up with a zeus after sometimes (having never bought it previously). I'll have to pay attention, maybe it buys it with rebuy for some reason, or maybe it just gives it to you. I think it may be caused from setting a second zeus round during a zeus round. I could be wrong though.

I'll let you know if I confirm anything. Besides two very minor issues, this is an awesome plugin. Good job, I look forward to the update with a toggle function.

[TnTSCS]

Having a Zeus after a zeus round was an undocumented feature If you survived the round with a Zeus, you got to keep it - I'll add a CVar for that so you can disable it.

[coolzie]

Oh ok, That makes sense. But sure, a cvar for it would be useful.

[SDurban]

everything works great, but i had to go figure out about the sdkhooks dev for it to work on csgo, might want to mention that for people just to save a little headache..great plugin, thanks!

[asherkin]

Nice plugin.

Few quick points for approval:

CloseHandle(hRandom);

You can't close a CVar handle, this is doing nothing.
Even if it did do anything, it would only be closing your last one.

Also, this code is a mess with only one variable for all of them, and assigning to it for cvars you don't even need the handle of.
There is no disadvantage to creating a local variable for each lookup, and it would keep the code looking clean.

GetConVarBool(hRandom);

While not terrible as it's not a hot path, these assignments are pointless, just hard-code the value you use in CreateConVar.

if (UseUpdater && LibraryExists("updater"))

This one in OnPluginStart, for the same reason as above, will never do anything as UseUpdater will always be false.

public OnConfigsExecuted()

There is a change hook on the CVar, so this isn't really doing anything.

for (new i = MaxClients + 1; i <= MaxEntities; i++)

This should be i < MaxEntities, the highest edict index is 2047.
You also might want to consider changing it to call GetEntityCount(), instead of using the fixed maximum.

switch (mode)

This makes a lot more sense as

if (mode) {

} else {

}

FindDataMapOffs(client, "m_iAmmo")

You should be using GetEntProp and the element parameter for accessing these.

[TnTSCS]

Originally Posted by SDurban everything works great, but i had to go figure out about the sdkhooks dev for it to work on csgo, might want to mention that for people just to save a little headache..great plugin, thanks!

Updated OP, thanks

Originally Posted by asherkin Nice plugin. Few quick points for approval: ...

Thanks for the direction, I'll work on these ASAP and update the plugin with ready for review once I've addressed the issues you brought up.

[TnTSCS]

Originally Posted by asherkin ... FindDataMapOffs(client, "m_iAmmo") You should be using GetEntProp and the element parameter for accessing these.

You're saying this code:

PHP Code:

#define        IncenderyGrenades        56    // (14 * 4) Also Molotovs

GetClientIncendaryGrenades(client)
{
    new offsNades = FindDataMapOffs(client, "m_iAmmo") + (IncenderyGrenades);
    
    return GetEntData(client, offsNades);
} 


Should be

PHP Code:

#define        IncenderyGrenades        56    // (14 * 4) Also Molotovs

GetClientIncendaryGrenades(client)
{
    new offsNades = FindDataMapOffs(client, "m_iAmmo") + (IncenderyGrenades);
    
    return GetEntProp(client, offsNades);
} 


...:: TnT Edit ::...

I took the above snippit from Greyscale's Grenade Pack V1.5

[asherkin]

Originally Posted by TnTSCS You're saying this code: PHP Code: #define        IncenderyGrenades        56    // (14 * 4) Also Molotovs GetClientIncendaryGrenades(client) {     new offsNades = FindDataMapOffs(client, "m_iAmmo") + (IncenderyGrenades);          return GetEntData(client, offsNades); }  Should be PHP Code: #define        IncenderyGrenades        56    // (14 * 4) Also Molotovs GetClientIncendaryGrenades(client) {     new offsNades = FindDataMapOffs(client, "m_iAmmo") + (IncenderyGrenades);          return GetEntProp(client, offsNades); }

PHP Code:

#define        IncenderyGrenades        14    // Also Molotovs

GetClientIncendaryGrenades(client) 
{      
    return GetEntProp(client, Prop_Data, "m_iAmmo", _, IncenderyGrenades); 
}