[Halt]

Originally Posted by 8guawong you have to show us the code where your entity is suppose to explode then

public Action:ArtilleryExplosionTimer(Handle:timer, Handle:datapack)
{
	PrintToChatAll("Executed Timer");
	float _ImpactVector[3];
	_ImpactVector[0] = ReadPackFloat(datapack);
	_ImpactVector[1] = ReadPackFloat(datapack);
	_ImpactVector[2] = ReadPackFloat(datapack);
	new Client = ReadPackCell(datapack);
	for (int i = 0; i < 2; i++)
	{
		_ImpactVector[i] += GetRandomFloat(-250.0, 250.0);
	}
	
	new Explosion = CreateEntityByName("tf_generic_bomb");
	DispatchKeyValue(Explosion, "damage", "180.0");
	DispatchKeyValue(Explosion, "radius", "150.0");
	DispatchKeyValue(Explosion, "health", "1");
	DispatchKeyValue(Explosion, "explode_particle", "fireSmokeExplosion_trackb");
	DispatchKeyValue(Explosion, "sound", "weapons/explode1.wav")
	DispatchSpawn(Explosion);
	TeleportEntity(Explosion, _ImpactVector, NULL_VECTOR, NULL_VECTOR);
	AcceptEntityInput(Explosion, "detonate");
	SDKHooks_TakeDamage(Explosion, Client, Client, 9001.0, DMG_BULLET, GetEntPropEnt(Client, Prop_Send, "m_hActiveWeapon"));
	CloseHandle(datapack);
	delete datapack;
}

[8guawong]

Originally Posted by Halt public Action:ArtilleryExplosionTimer(Handle:timer, Handle:datapack) { PrintToChatAll("Executed Timer"); float _ImpactVector[3]; _ImpactVector[0] = ReadPackFloat(datapack); _ImpactVector[1] = ReadPackFloat(datapack); _ImpactVector[2] = ReadPackFloat(datapack); new Client = ReadPackCell(datapack); for (int i = 0; i < 2; i++) { _ImpactVector[i] += GetRandomFloat(-250.0, 250.0); } new Explosion = CreateEntityByName("tf_generic_bomb"); DispatchKeyValue(Explosion, "damage", "180.0"); DispatchKeyValue(Explosion, "radius", "150.0"); DispatchKeyValue(Explosion, "health", "1"); DispatchKeyValue(Explosion, "explode_particle", "fireSmokeExplosion_trackb"); DispatchKeyValue(Explosion, "sound", "weapons/explode1.wav") DispatchSpawn(Explosion); TeleportEntity(Explosion, _ImpactVector, NULL_VECTOR, NULL_VECTOR); AcceptEntityInput(Explosion, "detonate"); SDKHooks_TakeDamage(Explosion, Client, Client, 9001.0, DMG_BULLET, GetEntPropEnt(Client, Prop_Send, "m_hActiveWeapon")); CloseHandle(datapack); delete datapack; }

since you didn't show ALL of your code
can't really tell what the problem is
here are some points you need to know
1. sequence that you write the datapack is the sequence you have read the datapack
so if you write client first you need to read client first

2. _ImpactVector[i] += GetRandomFloat(-250.0, 250.0);
maybe this is where the problem is

3. CloseHandle(datapack);
delete datapack;
you don't need this as WildCard65 stated here https://forums.alliedmods.net/showpo...8&postcount=25

[WildCard65]

Are you resetting the datapack before you read it (either after filling it or during timer execution)

[Halt]

Originally Posted by 8guawong since you didn't show ALL of your code can't really tell what the problem is here are some points you need to know 1. sequence that you write the datapack is the sequence you have read the datapack so if you write client first you need to read client first 2. _ImpactVector[i] += GetRandomFloat(-250.0, 250.0); maybe this is where the problem is 3. CloseHandle(datapack); delete datapack; you don't need this as WildCard65 stated here https://forums.alliedmods.net/showpo...8&postcount=25

I write and read in the same sequence. And removed ClosedHandle, and delete datapack. Why might the vector corrections be an issue? I'll attempt it without it there nonetheless.

As for reseting the datapack I'm reseting it before its filled with data and before the timer is created. Here

public Action:ArtillaryStrike(Client, Args)
{
	float RandomTime = GetRandomFloat(3.0, 8.5);

	float ImpactVector[3];
	Handle datapack;
	ResetPack(datapack);
	GetAimPos(Client, ImpactVector);
	CreateTimer(0.1, ArtillarySmokeTimer, Client);
	CreateDataTimer(RandomTime, ArtilleryExplosionTimer, datapack);
	WritePackFloat(datapack, ImpactVector[0]);
	WritePackFloat(datapack, ImpactVector[1]);
	WritePackFloat(datapack, ImpactVector[2]);
	WritePackCell(datapack, Client);
	return Plugin_Handled;
}

[8guawong]

Originally Posted by Halt I write and read in the same sequence. And removed ClosedHandle, and delete datapack. Why might the vector corrections be an issue? I'll attempt it without it there nonetheless. As for reseting the datapack I'm reseting it before its filled with data and before the timer is created. Here public Action:ArtillaryStrike(Client, Args) { float RandomTime = GetRandomFloat(3.0, 8.5); float ImpactVector[3]; Handle datapack; ResetPack(datapack); GetAimPos(Client, ImpactVector); CreateTimer(0.1, ArtillarySmokeTimer, Client); CreateDataTimer(RandomTime, ArtilleryExplosionTimer, datapack); WritePackFloat(datapack, ImpactVector[0]); WritePackFloat(datapack, ImpactVector[1]); WritePackFloat(datapack, ImpactVector[2]); WritePackCell(datapack, Client); return Plugin_Handled; }

you only need to reset the pack before you read it
you do not need to reset it before writing to it

because when you randomize the location it might be somwhere you could not see? try with smaller values first?

[brunoronning]

Originally Posted by Halt I write and read in the same sequence. And removed ClosedHandle, and delete datapack. Why might the vector corrections be an issue? I'll attempt it without it there nonetheless. As for reseting the datapack I'm reseting it before its filled with data and before the timer is created. Here

Try:

PHP Code:

public Action ArtillaryStrike(int client, int args)
{
    float RandomTime = GetRandomFloat(3.0, 8.5);

    float ImpactVector[3];
    GetAimPos(client, ImpactVector);

    CreateTimer(0.1, ArtillarySmokeTimer, client);
    
    DataPack ArtillaryPack;
    CreateDataTimer(RandomTime, ArtilleryExplosionTimer, ArtillaryPack);
    ArtillaryPack.WriteFloat(ImpactVector[0]);
    ArtillaryPack.WriteFloat(ImpactVector[1]);
    ArtillaryPack.WriteFloat(ImpactVector[2]);
    ArtillaryPack.WriteCell(client);
    
    return Plugin_Handled;
}

public Action ArtilleryExplosionTimer(Handle timer, DataPack ArtillaryPack)
{
    float ImpactVector[3];
    int client;

    ArtillaryPack.Reset();

    PrintToChatAll("Executed Timer");
    ImpactVector[0] = ArtillaryPack.ReadFloat();
    ImpactVector[1] = ArtillaryPack.ReadFloat();
    ImpactVector[2] = ArtillaryPack.ReadFloat();
    client = ArtillaryPack.ReadCell();

    if (!client || !IsClientInGame(client))
        return Plugin_Stop;

    for (int i = 0; i < 2; i++)
    {
        ImpactVector[i] += GetRandomFloat(-250.0, 250.0);
    }

    int Explosion = CreateEntityByName("tf_generic_bomb");
    DispatchKeyValue(Explosion, "damage", "180.0");
    DispatchKeyValue(Explosion, "radius", "150.0");
    DispatchKeyValue(Explosion, "health", "1");
    DispatchKeyValue(Explosion, "explode_particle", "fireSmokeExplosion_trackb");
    DispatchKeyValue(Explosion, "sound", "weapons/explode1.wav")
    DispatchSpawn(Explosion);
    TeleportEntity(Explosion, ImpactVector, NULL_VECTOR, NULL_VECTOR);
    AcceptEntityInput(Explosion, "detonate");
    SDKHooks_TakeDamage(Explosion, client, client, 9001.0, DMG_BULLET, GetEntPropEnt(client, Prop_Send, "m_hActiveWeapon"));

    return Plugin_Handled;
} 


[Halt]

It works now ;) thanks everyone for your help and patience. Solved.

[asherkin]

Originally Posted by Halt I write and read in the same sequence. And removed ClosedHandle, and delete datapack. Why might the vector corrections be an issue? I'll attempt it without it there nonetheless. As for reseting the datapack I'm reseting it before its filled with data and before the timer is created. Here public Action:ArtillaryStrike(Client, Args) { float RandomTime = GetRandomFloat(3.0, 8.5); float ImpactVector[3]; Handle datapack; ResetPack(datapack); GetAimPos(Client, ImpactVector); CreateTimer(0.1, ArtillarySmokeTimer, Client); CreateDataTimer(RandomTime, ArtilleryExplosionTimer, datapack); WritePackFloat(datapack, ImpactVector[0]); WritePackFloat(datapack, ImpactVector[1]); WritePackFloat(datapack, ImpactVector[2]); WritePackCell(datapack, Client); return Plugin_Handled; }

Just a note, if you'd bothered checking the error logs, you would have seen this throwing an error on the ResetPack call, and thus not executing the rest of the code at all.

[Halt]

Originally Posted by asherkin Just a note, if you'd bothered checking the error logs, you would have seen this throwing an error on the ResetPack call, and thus not executing the rest of the code at all.

I noticed that when I read it and re-located ResetPack() just above where I write them.

Spoiler

 public Action ArtillaryStrike(int Client, int args)
{
	if(bIsPlayerAlive[Client] && !bIsPlayerZombie[Client] && ZomPoints[Client] >= 10 && HasRoundStarted)
	{
		PrintToChatAll("\x07ff2929[\x0730FF31ZomXR\x07ff2929] -\x0730FF31%N \x07e3f010has called an artillary strike!", Client);
		float RandomTime = GetRandomFloat(3.0, 8.5);
		float RandomTime2 = GetRandomFloat(3.0, 8.5);
		float RandomTime3 = GetRandomFloat(3.0, 8.5);
		float RandomTime4 = GetRandomFloat(3.0, 8.5);
		float RandomTime5 = GetRandomFloat(3.0, 8.5);
		float RandomTime6 = GetRandomFloat(3.0, 8.5);
		float ImpactVector[3];
		GetAimPos(Client, ImpactVector);
		CreateTimer(RandomTime, DistanceSounds);
		CreateTimer(RandomTime2, DistanceSounds);
		CreateTimer(RandomTime3, DistanceSounds);
		CreateTimer(RandomTime4, DistanceSounds);
		CreateTimer(RandomTime5, DistanceSounds);
		CreateTimer(RandomTime6, DistanceSounds);
		CreateTimer(0.1, ArtillarySmokeTimer, Client);
		DataPack ArtillaryPack;
		DataPack ArtillaryPack2;
		DataPack ArtillaryPack3;
		DataPack ArtillaryPack4;
		DataPack ArtillaryPack5;
		DataPack ArtillaryPack6;
		ArtillaryPack.Reset();
		ArtillaryPack2.Reset();
		ArtillaryPack3.Reset();
		ArtillaryPack4.Reset();
		ArtillaryPack5.Reset();
		ArtillaryPack6.Reset();
		CreateDataTimer(RandomTime += 5.0, ArtilleryExplosionTimer, ArtillaryPack);
		CreateDataTimer(RandomTime2 += 5.0, ArtilleryExplosionTimer2, ArtillaryPack2);
		CreateDataTimer(RandomTime3 += 5.0, ArtilleryExplosionTimer3, ArtillaryPack3);
		CreateDataTimer(RandomTime4 += 5.0, ArtilleryExplosionTimer4, ArtillaryPack4);
		CreateDataTimer(RandomTime5 += 5.0, ArtilleryExplosionTimer5, ArtillaryPack5);
		CreateDataTimer(RandomTime6 += 5.0, ArtilleryExplosionTimer6, ArtillaryPack6);
		ArtillaryPack.WriteFloat(ImpactVector[0]);
		ArtillaryPack.WriteFloat(ImpactVector[1]);
		ArtillaryPack.WriteFloat(ImpactVector[2]);
		ArtillaryPack.WriteCell(Client);
		ArtillaryPack2.WriteFloat(ImpactVector[0]);
		ArtillaryPack2.WriteFloat(ImpactVector[1]);
		ArtillaryPack2.WriteFloat(ImpactVector[2]);
		ArtillaryPack2.WriteCell(Client);
		ArtillaryPack3.WriteFloat(ImpactVector[0]);
		ArtillaryPack3.WriteFloat(ImpactVector[1]);
		ArtillaryPack3.WriteFloat(ImpactVector[2]);
		ArtillaryPack3.WriteCell(Client);
		ArtillaryPack4.WriteFloat(ImpactVector[0]);
		ArtillaryPack4.WriteFloat(ImpactVector[1]);
		ArtillaryPack4.WriteFloat(ImpactVector[2]);
		ArtillaryPack4.WriteCell(Client);
		ArtillaryPack5.WriteFloat(ImpactVector[0]);
		ArtillaryPack5.WriteFloat(ImpactVector[1]);
		ArtillaryPack5.WriteFloat(ImpactVector[2]);
		ArtillaryPack5.WriteCell(Client);
		ArtillaryPack6.WriteFloat(ImpactVector[0]);
		ArtillaryPack6.WriteFloat(ImpactVector[1]);
		ArtillaryPack6.WriteFloat(ImpactVector[2]);
		ArtillaryPack6.WriteCell(Client);

And so far its worked properly. I use the command it creates explosions at random times and random vectors every time I use it.

[hmmmmm]

This is the kind of situation where loops and arrays are very helpful. Can condense a lot of that code and avoid repeating stuff 6 different times.