[cravenge]

Ahh, I think I get the idea, MasterMind. Is it just like below?

PHP Code:

#pragma semicolon 1
#include <sourcemod>
#include <sdktools>

static const String:SOUND_AUTOSHOTGUN[] = "weapons/auto_shotgun/gunfire/auto_shotgun_fire_1.wav";
static const String:SOUND_SPASSHOTGUN[] = "weapons/auto_shotgun_spas/gunfire/shotgun_fire_1.wav";
static const String:SOUND_PUMPSHOTGUN[] = "weapons/shotgun/gunfire/shotgun_fire_1.wav";
static const String:SOUND_CHROMESHOTGUN[] = "weapons/shotgun_chrome/gunfire/shotgun_fire_1.wav";

static bool:confirmChangedView[MAXPLAYERS+1] = false;

public Plugin:myinfo = 
{
    name = "Shotgun Sounds Fix",
    author = "DeathChaos25",
    description = "Fixes Bug Where Shotguns Don't Produce Sound In Third Person View.",
    version = "1.0",
    url = "https://forums.alliedmods.net/showthread.php?t=259986"
};

public OnPluginStart()
{
    HookEvent("weapon_fire", OnWeaponFire);
    
    CreateTimer(1.0, CheckCurrentView, _, TIMER_REPEAT);
}

public Action:CheckCurrentView(Handle:timer)
{
    for (new cIndex = 1; cIndex <= MaxClients; cIndex++)
    {
        if (IsClientInGame(cIndex) && !IsFakeClient(cIndex))
        {
            if (GetClientTeam(cIndex) == 2)
            {
                QueryClientConVar(cIndex, "c_thirdpersonshoulder", QueryClientConVarCallback);
            }
        }
    }
    
    return Plugin_Continue;
}

public QueryClientConVarCallback(QueryCookie:cookie, client, ConVarQueryResult:result, const String:cvarName[], const String:cvarValue[])
{
    if (IsClientInGame(client))
    {
        if (result != ConVarQuery_Okay)
        {
            confirmChangedView[client] = false;
        }
        
        if (StrEqual(cvarValue, "false") || StrEqual(cvarValue, "0"))
        {
            confirmChangedView[client] = false;
        }
        
        confirmChangedView[client] = true;
    }
}

public OnMapStart()
{
    PrefetchSound(SOUND_AUTOSHOTGUN);
    PrefetchSound(SOUND_SPASSHOTGUN);
    PrefetchSound(SOUND_CHROMESHOTGUN);
    PrefetchSound(SOUND_PUMPSHOTGUN);
    
    PrecacheSound(SOUND_AUTOSHOTGUN, true);
    PrecacheSound(SOUND_SPASSHOTGUN, true);
    PrecacheSound(SOUND_CHROMESHOTGUN, true);
    PrecacheSound(SOUND_PUMPSHOTGUN, true);
}

public Action:OnWeaponFire(Handle:event, const String:name[], bool:dontBroadcast)
{
    new client = GetClientOfUserId(GetEventInt(event, "userid"));
    if (client <= 0 || client > MaxClients || !IsClientInGame(client) || GetClientTeam(client) != 2 || !IsPlayerAlive(client) || !confirmChangedView[client]) 
    {
        return Plugin_Handled;
    }
    
    new String:weapon[64];
    GetEventString(event, "weapon", weapon, sizeof(weapon));
    for (new i=1; i<=MaxClients; i++)
    {
        if(IsClientInGame(i) && GetClientTeam(client) == 2 && i == client)
        {
            if (StrEqual(weapon, "autoshotgun"))
            {
                EmitSoundToClient(i, SOUND_AUTOSHOTGUN, client, SNDCHAN_WEAPON);
            }
            else if (StrEqual(weapon, "shotgun_spas"))
            {
                EmitSoundToClient(i, SOUND_SPASSHOTGUN, client, SNDCHAN_WEAPON);
            }
            else if (StrEqual(weapon, "pumpshotgun"))
            {
                EmitSoundToClient(i, SOUND_PUMPSHOTGUN, client, SNDCHAN_WEAPON);
            }
            else if (StrEqual(weapon, "shotgun_chrome"))
            {
                EmitSoundToClient(i, SOUND_CHROMESHOTGUN, client, SNDCHAN_WEAPON);
            }
        }
    }
    
    return Plugin_Continue;
} 


[Lux]

you don't understand... this convar can still be 1 (c_thirdpersonshoulder) even if they are in first person view.
which mean's echo bug again this is what i mean by thirdpersonshoulder is clientsided cmd only and it is a cmd not a convar

[MasterMind420]

Originally Posted by Ludastar you don't understand... this convar can still be 1 (c_thirdpersonshoulder) even if they are in first person view. which mean's echo bug again this is what i mean by thirdpersonshoulder is clientsided cmd only and it is a cmd not a convar

That will only happen if something else forces you out of thirdpersonshoulder prematurely, for instance going afk in thirdpersonshoulder, it forces you back to firstperson when you come back yet that convar remains 1. That is the only instance i've seen that happen and i have a fix for that if its needed. But still i see that being a rare occurance...You can still use that convar check effectively. basically that convar only changes when you use the thirdpersonshoulder cmd, which is really the closest and only thing we have to detecting if there in thirdpersonshoulder...anything forcing you out of thirdpersonshoulder other than using the command will cause that issue...

[cravenge]

Originally Posted by Ludastar which mean's echo bug again

PHP Code:

for (new i=1; i<=MaxClients; i++) 
    { 
        if(IsClientInGame(i) && GetClientTeam(client) == 2 && i == client) 
        { 
            if (StrEqual(weapon, "autoshotgun")) 
            { 
                EmitSoundToClient(i, SOUND_AUTOSHOTGUN, client, SNDCHAN_WEAPON); 
            } 
            else if (StrEqual(weapon, "shotgun_spas")) 
            { 
                EmitSoundToClient(i, SOUND_SPASSHOTGUN, client, SNDCHAN_WEAPON); 
            } 
            else if (StrEqual(weapon, "pumpshotgun")) 
            { 
                EmitSoundToClient(i, SOUND_PUMPSHOTGUN, client, SNDCHAN_WEAPON); 
            } 
            else if (StrEqual(weapon, "shotgun_chrome")) 
            { 
                EmitSoundToClient(i, SOUND_CHROMESHOTGUN, client, SNDCHAN_WEAPON); 
            } 
        } 
    } 


This doesn't produce any echo because it only emits to the client itself.

[MasterMind420]

Originally Posted by cravenge PHP Code: for (new i=1; i<=MaxClients; i++)      {          if(IsClientInGame(i) && GetClientTeam(client) == 2 && i == client)          {              if (StrEqual(weapon, "autoshotgun"))              {                  EmitSoundToClient(i, SOUND_AUTOSHOTGUN, client, SNDCHAN_WEAPON);              }              else if (StrEqual(weapon, "shotgun_spas"))              {                  EmitSoundToClient(i, SOUND_SPASSHOTGUN, client, SNDCHAN_WEAPON);              }              else if (StrEqual(weapon, "pumpshotgun"))              {                  EmitSoundToClient(i, SOUND_PUMPSHOTGUN, client, SNDCHAN_WEAPON);              }              else if (StrEqual(weapon, "shotgun_chrome"))              {                  EmitSoundToClient(i, SOUND_CHROMESHOTGUN, client, SNDCHAN_WEAPON);              }          }      }  This doesn't produce any echo because it only emits to the client itself.

which would make sense, but can other clients hear the sound too, if your in thirdpersonshoulder, or does the bug only effect the specific client shooting the shotgun? Thats why i assume he initially coded it to Emit to all clients. But I haven't tested that, the echo is definately gone...

[cravenge]

I did a crash test with my friend. Actually, even without this plugin, he can hear the shotgun sounds emitted from me which means the no shotgun sounds bug comes from the player holding the shotgun him/herself.

[MasterMind420]

nice, so then that means you've fixed it...great job

[Lux]

Originally Posted by cravenge I did a crash test with my friend. Actually, even without this plugin, he can hear the shotgun sounds emitted from me which means the no shotgun sounds bug comes from the player holding the shotgun him/herself.

I see you use a local hosted server cravenge, so you would never hear the echo, the echo only happens due to delay with ping, the higher ping the more of a delay the sound you be, meaning if your on 150ping this fix is kinda useless because of standard lerp = 100ms making total latency 250ms making the sounds out of sync.

This make the fix feel yuck, ill maybe try and calc the latency if it's below >100ms

[MasterMind420]

Crossing fingers people but on an initial test with Ludastar it's looking promising, report any bugs and when they happened(echo returns), its very important for me to find and fix where the convarquerycheck is reporting falsely. So far i've narrowed it down to 4 instances mapchange, death, afk and rescue closet.

[jking]

Originally Posted by MasterMind420 Crossing fingers people but on an initial test with Ludastar it's looking promising, report any bugs and when they happened(echo returns), its very important for me to find and fix where the convarquerycheck is reporting falsely. So far i've narrowed it down to 4 instances mapchange, death, afk and rescue closet.

5x5 great work you guys