[Emp`]

Originally Posted by fysiks Does it work here?

Yes.

[Tirant]

Ya, why not do

if (tagof into != tagof from)
    break

so

PHP Code:

stock arraycopy(into[], size1, pos1, from[], size2, pos2, len) {
    if (tagof into != tagof from) {
        log_error(AMX_ERR_PARAMS, "Tag of ^"into^" does not match tag of ^"from^"");
        return;
    }
    
    for (new i; i < len; i++) {
        if (pos1 >= size1 || pos2 >= size2) {
            break;
        }
        
        into[pos1++] = from[pos2++];
    }
} 


Yea! so there is basically an instanceof operator!

[Emp`]

Originally Posted by Tirant Ya, why not do if (tagof into != tagof from) break

That would just be

if (0 != 0)
    break

You need to store the tags into an argument like it is done in the link provided earlier.

Something you should also do is return the amount of values copied.

[Tirant]

So something like this

PHP Code:

stock arraycopy(into[], tag1 = tagof into, size1, pos1, from[], tag2 = tagof from, size2, pos2, len) {
    if (tag1 != tag2) {
        log_error(AMX_ERR_PARAMS, "Tag of ^"into^" (%d) does not match tag of ^"from^" (%d)", tag1, tag2);
        return -1;
    }
    
    new i
    while (i < len) {
        if (pos1 >= size1 || pos2 >= size2) {
            break;
        }
        
        into[pos1++] = from[pos2++];
        i++;
    }
    
    return i;
} 


[Emp`]

Yes; however, you still need to tag both into and from as any so that any tag can be used. Currently it will give you a tag mismatch.

I suggest you move the tags to the end of the parameter list, so people don't have to use an underscore to skip the argument.

I would also suggest a parameter for ignoring tags.

Personally, how I would make it:

stock arraycopy( any:into[], any:from[], len, bool:ignoretags = false, intotag = tagof into, intosize = sizeof into, intopos = 0, fromtag = tagof from, fromsize = sizeof from, frompos = 0) {
    if (!ignoretags && intotag != fromtag) {
        //So we know no elements were copied (we did not remove an element ie. returning -1)
        return 0;
    }
    
    new i
    while (i < len) {
        if (intopos >= intosize || frompos >= fromsize) {
            break;
        }
        
        into[intopos++] = from[frompos++];
        i++;
    }
    
    return i;
}

[Tirant]

Originally Posted by Emp` Yes; however, you still need to tag both into and from as any so that any tag can be used. Currently it will give you a tag mismatch. I suggest you move the tags to the end of the parameter list, so people don't have to use an underscore to skip the argument. I would also suggest a parameter for ignoring tags. Personally, how I would make it: stock arraycopy( any:into[], any:from[], len, bool:ignoretags = false, intotag = tagof into, intosize = sizeof into, intopos = 0, fromtag = tagof from, fromsize = sizeof from, frompos = 0) { if (!ignoretags && intotag != fromtag) { //So we know no elements were copied (we did not remove an element ie. returning -1) return 0; } new i while (i < len) { if (intopos >= intosize || frompos >= fromsize) { break; } into[intopos++] = from[frompos++]; i++; } return i; }

Okay, I like that. Maybe we should have "len = sizeof into" within the parameter list also.

Also, why remove the error reporting? IMO, if the tags are not right when they should be, I think the client should be notified.

[Emp`]

Originally Posted by Tirant Okay, I like that. Maybe we should have "len = sizeof into" within the parameter list also. Also, why remove the error reporting? IMO, if the tags are not right when they should be, I think the client should be notified.

That's up to you, I was just showing how I would make it.

[Arkshine]

Did you test your stock ? Because I'm doing some tests just by curiosity, and by using tagof in the header will result 0 always or using multi-tag (any, or {Float, bool, etc..} ) and the value will be always the same (more the first tag). In others words, and if I don't say bullshits, it works only with mono-tag, and tagof has to used inside the function.

[Tirant]

Originally Posted by Emp` That's up to you, I was just showing how I would make it.

I think I'm going to agree with you and keep it out. It will return 0, so there will be a way to know if your loop did not work.

[Emp`]

Originally Posted by Arkshine Did you test your stock ? Because I'm doing some tests just by curiosity, and by using tagof in the header will result 0 always or using multi-tag (any, or {Float, bool, etc..} ) and the value will be always the same. In others words, and if I don't say bullshits, it works only with mono-tag, and tagof has to used inside the function.

Ah, it does seem to bugger up when used as a default value for a parameter. I thought it might work like sizeof/charsmax.

However, this works fine:

arraycopy( copyarray, initarray, sizeof copyarray, .intotag = tagof copyarray, .fromtag = tagof initarray );

The only way I see it working well is by using a macro to auto fill the required info.

Something like:

#define array_copy(%1, %2, %3) arraycopy( %1, %2, %3, .intotag = tagof %1, .fromtag = tagof %2 )