[Pricetx]

I have a script for HL2MP which removes weapons from players when they spawn, and additionally removes weapons from the map when it loads.

This worked fine up until some point in May.

For the last hour or so i've been debugging my script and I have found that the line

owner = GetPlayerWeaponSlot(client, 1);

will always resolve to -1. I have checked that the "client" variable was valid (on my last test, it was "2").

I am running the latest dev build of sourcemod, and the latest version of the HL2MP server.

I'll include a link to the script in it's current state below.

https://gravitygunonly.com/hl2mp_removeweapons_v2.sp

Thanks!

Pricetx

[berni]

You could use smlib instead.

PHP Code:

if (/* remove weapon ? */) {
    Client_RemoveWeapon(client, weaponToRemove);
} 


[Marcus_Brown001]

I am doing the same thing in my script, however, I did use SMLIB . Instead of making my plugin dependent of something else, I just used the code from the Client_RemoveAllWeapons stock.

This code will remove all the weapons a client has when they spawn:

PHP Code:

new iOffset = FindDataMapOffs(iClient, "m_hMyWeapons") - 4;

    for (new i; i < 48; i++)
    {
        iOffset += 4;

        new iWeapon = GetEntDataEnt2(iClient, iOffset);
        
        if (iWeapon <= 0) continue;

        if (RemovePlayerItem(iClient, iWeapon)) AcceptEntityInput(iWeapon, "Kill");
    } 


[Pricetx]

Thanks for the solutions so far guys, although I will admit that I have extremely little experience with SourcePawn, so if I were to go with either of your ideas it would probably take me a while to get something functional.

That being said, does anybody actually know why GetPlayerWeaponSlot is always returning -1 on hl2mp despite a valid player and weapon slot ID being provided?

Thanks,

Pricetx

[Doodil]

We just have to assume that its the wrong id or that the function just does not support hl2dm (anymore?) I guess. Maybe loop through a few numbers and print the values to chat to see if the ids changed, otherwise some update probably broke the function.

[NouveauJoueur]

Originally Posted by Pricetx That being said, does anybody actually know why GetPlayerWeaponSlot is always returning -1

GetPlayerWeaponSlot is broken since last update.

If you want your code to work change :

                CreateTimer(0.3, TimerRemoveWeapons, client);

to

                CreateTimer(3.0, TimerRemoveWeapons, client);

Anything below 2.0 will fail.
F.ck Riot ... (What has league of legends to do with this ? You tell me !)

[Marcus_Brown001]

Any timer below two will fail for what? I have a timer set for 0.5 when a player spawns to remove the weapons and mine has had zero issues.

[NouveauJoueur]

Originally Posted by Marcus_Brown001 Any timer below two will fail for what? I have a timer set for 0.5 when a player spawns to remove the weapons and mine has had zero issues.

Read the post title. Based on your post i'll give you a few hints to help you understand :

GetPlayerWeaponSlot
GetPlayerWeaponSlot != StripWeapons

You might want to read the quote that precede my first answer :

That being said, does anybody actually know why GetPlayerWeaponSlot is always returning -1

The title is about GetPlayerWeaponSlot, the question quoted is about GetPlayerWeaponSlot, the answer is about GetPlayerWeaponSlot, I let you guess what will fail if you create a timer below 2 seconds after the player get his weapons. I know it can be confusing and hard to answer, so i'll give you another hint : GetPlayerWeaponSlot.

[Marcus_Brown001]

I didn't know where you were getting the TimerRemoveWeapon from (only just now opened the mod to look at it). A simpler and less condescending answer would have both sufficed and been more sought after by the way.

[Pricetx]

Originally Posted by NouveauJoueur GetPlayerWeaponSlot is broken since last update. If you want your code to work change : CreateTimer(0.3, TimerRemoveWeapons, client); to CreateTimer(3.0, TimerRemoveWeapons, client); Anything below 2.0 will fail. F.ck Riot ... (What has league of legends to do with this ? You tell me !)

That particular section of code was working before, but I gave it a shot anyway and changed it to 3.0. Unfortunately, it still returns -1, even when set to 3.0.

On a different note; i'm not very familiar with how SourceMod actually works. With GetPlayerWeaponSlot being broken with HL2DM at the moment, is that something that only Valve can fix, or is it something with the GetPlayerWeaponSlot function within SourceMod itself?