One-Shot Multikill Detection - Page 4

EFFx · *Last edited by EFFx; 01-08-2017 at 18:27.*

I have added some things but I don't updated because I have not made all the changes, and for not updating much times, I just will update when I finish all the changes.

And you don't explained how I can return the CHAT when the cvar is more than 2...

PRoSToTeM@ · 01-08-2017 , 20:02 Re: One-Shot Multikill Detection

Quote:

Originally Posted by PRoSToTeM@

PlayerTakenDamage

Oh, i've failed, this should be PlayerTookDamage.
This is from microsoft guidelines for event naming in C#. https://msdn.microsoft.com/en-us/lib....aspx#Anchor_2

Quote:

✓ DO give events names with a concept of before and after, using the present and past tenses.
For example, a close event that is raised before a window is closed would be called Closing, and one that is raised after the window is closed would be called Closed.
X DO NOT use "Before" or "After" prefixes or postfixes to indicate pre- and post-events. Use present and past tenses as just described.

So, for pre this should be PlayerTakingDamage and for post PlayerTookDamage.

**Bugsy** · 01-08-2017 , 20:57 Re: One-Shot Multikill Detection

Quote:

Originally Posted by PRoSToTeM@

Oh, i've failed, this should be PlayerTookDamage.
This is from microsoft guidelines for event naming in C#. https://msdn.microsoft.com/en-us/lib....aspx#Anchor_2

So, for pre this should be PlayerTakingDamage and for post PlayerTookDamage.

Good thing we're not coding in C#

I think it's more obvious and clear with the '_Post' suffix, but that's just me.

EFFx · 01-08-2017 , 20:58 Re: One-Shot Multikill Detection

@Bugsy

Did you readed my post? https://forums.alliedmods.net/showpo...7&postcount=31

**Bugsy** · *Last edited by Bugsy; 01-08-2017 at 21:02.*

EFFx, what I meant with the cvar thing.

Suppose the cvar is set to 8.

You have switch for 0, 1, 2. Nothing would happen since nothing is defined for 8.

You need something to be there for outlier/undefined values.

So what I suggested is:

PHP Code:


			
case HUD: [for cvar value 1]
case LOG: [for cvar value 2]
default: [for cvar value 0 (CHAT) and anything else (-5, -1, 3, 4 , 5, 100, etc]

I suggested to use whatever you want the default output type to be, I assumed CHAT for my above example.

EFFx · *Last edited by EFFx; 01-08-2017 at 21:45.*

Yes, I know about default, but should I repeat the same case like case CHAT?? Is any optimization?

**Bugsy** · 01-08-2017 , 21:53 Re: One-Shot Multikill Detection

Quote:

Originally Posted by EFFx

Yes, I know about default, but should I repeat the same case like case CHAT?? Is any optimization?

Just do not define CHAT, it will fall into default along with any other undefined value.

EFFx · *Last edited by EFFx; 01-09-2017 at 18:21.*

All things are now added, see the spoiler at description for see the new observation.

Waiting new answers...

kristi · *Last edited by kristi; 01-09-2017 at 21:22.*

Quote:

Originally Posted by EFFx

if you add !g, the word 'grenade' will show renade because the replace_all() is removing the !g..

!ggrenade ?

EFFx · *Last edited by EFFx; 01-09-2017 at 21:32.*

Exactly. If you add !ggrenade or !g grenade the message will show renade. Because the !g have G, and this letter will be replaced with nothing with replace_all()