[dFF]

Which is better to hold some values ( like OFFSET_CSDEATHS = 444 ) const or define ?

PHP Code:

const OFFSET_CSDEATHS = 444

or

#define OFFSET_CSDEATHS 444 


?

[Exolent[jNr]]

If you only use it once in your code, use #define.
Otherwise, use a constant.

This is because defines are basically just place holders until it is compiled.
When it is compiled, the define constants are replaced with their actual definition, so the defines are not really constant variables.

Code example:

#define VERSION "1.0"

public plugin_init()
{
    register_plugin("Test", VERSION, "Exolent");
    
    log_amx("Server is running v%s", VERSION);
}

When compiled, it is translated to:

public plugin_init()
{
    register_plugin("Test", "1.0", "Exolent");
    
    log_amx("Server is running v%s", "1.0");
}

The bad thing about this is that those 2 "1.0" strings are in different places of memory, but it is a waste of space since they are the same value.

When you use a constant variable, it is set in a specific place in memory.
When you access that constant variable anywhere, it will use that 1 place in memory.

It is better practice to use constants rather than defines for this reason.
Though, if it is only used once in your code, then a define is okay.

[Dr7sTyLe]

i prefer define

[Exolent[jNr]]

Originally Posted by Dr7sTyLe i prefer define

Opinions don't make code better.

[Devil259]

#define is better because it doesn't use memory -> when the code is compiled, the defines are deleted.
constants use memory because they aren't deleted.

[dFF]

Ok, many thanks guys for replies. I will make some tests and I will see wich is more fine, const/define.

[Devil259]

You can't see that in a code,

the two methods work fine

[Exolent[jNr]]

Originally Posted by Devil259 #define is better because it doesn't use memory -> when the code is compiled, the defines are deleted. constants use memory because they aren't deleted.

You are completely wrong.

All strings, characters, numbers, etc. that are written out but not stored in variables, are still stored in memory.

Example:

log_amx("Testing");
log_amx("Testing");
log_amx("Testing");
log_amx("Testing");

"Testing" is in memory 4 times because it appears in 4 different places.

new const string[] = "Testing";

log_amx(string);
log_amx(string);
log_amx(string);
log_amx(string);

Now, "Testing" is only in memory once.

Learn yourself before trying to teach others.

[Devil259]

Originally Posted by Exolent[jNr] You are completely wrong. All strings, characters, numbers, etc. that are written out but not stored in variables, are still stored in memory. Example: log_amx("Testing"); log_amx("Testing"); log_amx("Testing"); log_amx("Testing"); "Testing" is in memory 4 times because it appears in 4 different places. new const string[] = "Testing"; log_amx(string); log_amx(string); log_amx(string); log_amx(string); Now, "Testing" is only in memory once. Learn yourself before trying to teach others.

And where are the defines in this example ? ...

[Dr7sTyLe]

Originally Posted by Devil259 And where are the defines in this example ? ...

there is no defines in this ex -_-