[BBG_Theory]

FF2 is broken on windows and Linux from update today. Is it itemes, or gamedata? or???

[Fearts]

Looks like the same for my servers. Both Freak Fortress and Saxton Hale.

[Jwu]

Indeed, how funny i made an update for FreakFortress 2 this morning and now its broke. -.-

Works for me now (after gamedata update).

[friagram]

Attribute 0 is most likely the problem.
Creating an item with attribute zero will crash the server. Old versions of tf2items will allow you to send attribute zero. It did not use to crash the server, but now it will. Newer versions of tf2 items will prevent 0 from being sent and abort the item creation.

The functions used to create the weapons in ff2 need to be fixed so that it does not send attribute zero. Then, weapons will be created properly

[friagram]

Looking through, I rewrote these ages ago when I moved all of the weapon handling in ff2 on my version into OGNI. Pretty sure the first ability set or whatever that spawns weapons for hales is still broken though. Has not had any effect on me, because I don't have any bosses that spawn blank stock weapons @ rage.

[Powerlord]

If issue is in these lines:

PHP Code:

    new count = ExplodeString(att, " ; ", atts, 32, 32);
    if (count > 0) 


ExplodeString never returns 0. Ever. Even if you pass in an empty string, it'll set atts[0] to an empty string and return 1. Meaning that the next loop runs once, turns "" to 0 (apparently) and sets attributes 0 to 0. Which causes TF2Items 254 and down to crash.

There are several ways to fix this. VSH fixed it by changing count > 0 to count > 1. I personally think that's sloppy.

Instead, I'd do this:

PHP Code:

    new count = 0;
    if (att[0] != '\0')
    {
        count = ExplodeString(att, " ; ", atts, 32, 32);
    }
    if (count > 0) 


Note: This is the freaks/special_noanims.sp version, freak_fortress_2 has the same thing but with attribCount, att, and weaponAttribsArray... and the attribCount if is farther down (but I didn't change that if anyway).

[friagram]

Originally Posted by Powerlord If issue is in these lines: Instead, I'd do this: PHP Code:     new count = 0;     if (att[0] != '\0')     {         count = ExplodeString(att, " ; ", atts, 32, 32);     }     if (count > 0)

This is a bad idea, if a user inputs something like this: " " then att[0] will be space, not string delim, and it will fail. Exploding the string first is okay, it's not that costly. The other option would be to strip whitespace... With just explodestring and then stringtoint checking if count > 1, you assume pairs, and stringtoint auto sanitizes returning zero (which could also cause the attribute zero problem, but .. oh well)

I for one still have tons of my bosses with attributes like this from when ff2 had broken string parsing:

" 2 ; 2.0 ; 134 ; 2 "

It's not good to assume that every empty string will be "", " " is perfectly valid.. and probably in some boss configs.
it may actually be better to do if(!(count % 2)) , since there MUST be an even number of args, or it WILL fail.

[Powerlord]

Originally Posted by friagram This is a bad idea, if a user inputs something like this: " " then att[0] will be space, not string delim, and it will fail. Exploding the string first is okay, it's not that costly. The other option would be to strip whitespace... With just explodestring and then stringtoint checking if count > 1, you assume pairs, and stringtoint auto sanitizes returning zero (which could also cause the attribute zero problem, but .. oh well) I for one still have tons of my bosses with attributes like this from when ff2 had broken string parsing: " 2 ; 2.0 ; 134 ; 2 " It's not good to assume that every empty string will be "", " " is perfectly valid.. and probably in some boss configs. it may actually be better to do if(!(count % 2)) , since there MUST be an even number of args, or it WILL fail.

True, but the user could just as easily put "bacon sandwich". We can't fix stupid.

[VoiDeD]

Originally Posted by friagram and then stringtoint checking if count > 1, you assume pairs, and stringtoint auto sanitizes returning zero (which could also cause the attribute zero problem, but .. oh well)

This actually becomes an issue with how ff2 builds attribute strings for bosses.

Although I'm not sure if the most recent public version does this, but some old version (and my forked version) of the FF2 code will concat a bosses attribs with some hardcoded attribs in the plugin.

So if a boss is being given a weapon with blank attribs, the final string will be something like "2 ; <something> ; 49 ; <somevalue> ; " (attribs completely from memory, but emphasis on the final semicolon and whitespace).

Now when the item code runs through whatever gets exploded, an empty string is passed to StringToInt, and that returns 0 and the code interprets that as attrib 0 and it all explodes.

[Powerlord]

Originally Posted by VoiDeD This actually becomes an issue with how ff2 builds attribute strings for bosses. Although I'm not sure if the most recent public version does this, but some old version (and my forked version) of the FF2 code will concat a bosses attribs with some hardcoded attribs in the plugin. So if a boss is being given a weapon with blank attribs, the final string will be something like "2 ; <something> ; 49 ; <somevalue> ; " (attribs completely from memory, but emphasis on the final semicolon and whitespace). Now when the item code runs through whatever gets exploded, an empty string is passed to StringToInt, and that returns 0 and the code interprets that as attrib 0 and it all explodes.

As far as I'm aware, all public versions of FF2 concat hard-coded attributes for melee weapons.

Speaking of public versions, do you have a public source code repo for your version somewhere?