[pcmaster]

Thanks, works fine now!

[Peace-Maker]

Updated to Version 1.1
Adds spectator chat interaction!

Changelog:

• Add SourceTV_OnSpectatorChatMessage[_Post] forwards to catch or block spectator chat
• Add SourceTV_PrintToChat native to print to one spectator's chat only
• Add SourceTV_PrintToConsole native to print to one spectator's console only
• Add SourceTV_SetClientTVTitle to set the stream title (tv_title) for one spectator individually
• Fix sending messages to locally connected players only in SourceTV_Broadcast*Message
• Change magic bLocalOnly boolean argument to a more readable SourceTVBroadcastTarget enum

[nosoop]

[SM] Unable to load extension "sourcetvmanager.ext": /home/server/tf/addons/sourcemod/extensions/sourcetvmanager.ext.2.tf2.so: undefined symbol: Warning

Occurs on SourceMod 1.8.0.5967 and 1.9.0.6039 in TF2; Linux.
Might need to be built with Clang? Had the same symbol message when I was testing out a modified SDKTools extension built on GCC.

Edit: Looks like building with Clang did the trick.

Edit 2: It's been a while since I worked with the extension, but since someone was trying to join a game from a relay, I decided to look into it again.

A multi-forward bug appears to actually still be present; client appears to be forcing a reconnect (internet:27005:reconnect in the output below), but only when the extension is loaded. Increases by one connection between map changes.

Here's sample output from sourcetv_test after a few map changes.

Spoiler

SourceTV client 1 put in server.
SourceTV client 1 put in server.
SourceTV client 1 put in server.
SourceTV client 1 put in server.
(client retried connection to SourceTV here)
SourceTV client 1 is disconnecting (isconnected 1) with reason -> Disconnect by user..
Dropped Pikachu on LSD from server (Disconnect by user.)
SourceTV client 1 disconnected (isconnected 0) with reason -> Disconnect by user..
SourceTV spectator is connecting! Name: Pikachu on LSD, pw: <omitted>, ip: internet
Client "Pikachu on LSD" connected (internet:27005).
SourceTV client 1 connected. (isconnected 1)
SourceTV spectator is connecting! Name: Pikachu on LSD, pw: <omitted>, ip: internet
internet:27005:reconnect
SourceTV client 1 is disconnecting (isconnected 1) with reason -> Connection closing.
Dropped Pikachu on LSD from server (Connection closing)
SourceTV client 1 disconnected (isconnected 0) with reason -> Connection closing.
Client "Pikachu on LSD" connected (internet:27005).
SourceTV client 1 connected. (isconnected 1)
SourceTV spectator is connecting! Name: Pikachu on LSD, pw: <omitted>, ip: internet
internet:27005:reconnect
SourceTV client 1 is disconnecting (isconnected 1) with reason -> Connection closing.
Dropped Pikachu on LSD from server (Connection closing)
SourceTV client 1 disconnected (isconnected 0) with reason -> Connection closing.
Client "Pikachu on LSD" connected (internet:27005).
SourceTV client 1 connected. (isconnected 1)
SourceTV spectator is connecting! Name: Pikachu on LSD, pw: <omitted>, ip: internet
internet:27005:reconnect
SourceTV client 1 is disconnecting (isconnected 1) with reason -> Connection closing.
Dropped Pikachu on LSD from server (Connection closing)
SourceTV client 1 disconnected (isconnected 0) with reason -> Connection closing.
Client "Pikachu on LSD" connected (internet:27005).
SourceTV client 1 connected. (isconnected 1)
SourceTV spectator is connecting! Name: Pikachu on LSD, pw: <omitted>, ip: internet
internet:27005:reconnect
SourceTV client 1 is disconnecting (isconnected 1) with reason -> Connection closing.
Dropped Pikachu on LSD from server (Connection closing)
SourceTV client 1 disconnected (isconnected 0) with reason -> Connection closing.
Client "Pikachu on LSD" connected (internet:27005).
SourceTV client 1 connected. (isconnected 1)

After reconnecting, the number of times the event is forwarded is reset.

[Peace-Maker]

Oh, I used the older gcc-4.8 to avoid that, but there seem to be problems still.
The server forces the client to reconnect? Can you elaborate? Do you have tv_force_steamauth set to 1?
I don't think I tested during mapchanges, so the extension might not catch the "disconnect" and keep hooking the client?

[nosoop]

Built it with clang-3.4 here.

I'm not sure which side is forcing the reconnection; all I know is that <ip>:<port>:reconnect shows up in the server console after reconnecting. No disconnect message before the map change, so it may be possible that the spectator disconnect on map change isn't being processed.

Further testing; the forward count actually isn't being reset on reconnect, and the <ip>:<port>:reconnect message shows up whether I use retry or connect <serverip>:<tvport>.

SourceTV_OnServerStart is also fired at some point after the map change, though I don't see SourceTV_OnServerShutdown being called.

Haven't modified tv_force_steamauth; it's unchanged from 0.

[Peace-Maker]

I've fixed part of it here. OnDisconnect isn't called for sourcetv spectators during mapchanges, but OnClientPutInServer is after they loaded the new map. Should I mimic the core forwards and always call the disconnect forwards on mapchange and the onconnect ones after mapchange? There is no "player_disconnect" event to catch actual disconnects for sourcetv clients though.

[nosoop]

I don't think it'd matter too much if the extension forwards differ from the SourceMod core forwards.

Compiled and installed the latest source and seems to work as expected in testing (no multiple forward calls and client reconnections). I'll drop it into my normal server and see if I run into any issues there.

Thanks!

[hlstriker]

Did any gamedata update (I'm using the latest)? Simply testing FakeClientCommand(SourceTV_GetBotIndex(), "status") will crash my Linux server.

0 sourcetvmanager.ext.2.csgo.so!HLTVServerWrapp er::OnHLTVBotExecuteStringCommand(char const*) [hltvserverwrapper.cpp:233 + 0x0] 1 sourcetvmanager.ext.2.csgo.so!__SourceHook_FH Cls_IClientExecuteStringCommand0::Func(char const*) [commonhooks.cpp:41 + 0x14] 2 sourcemod.2.csgo.so!VEngineServer_Logic::Fake ClientCommand [logic_bridge.cpp:121 + 0x16] 3 sourcemod.logic.so!FakeClientCommand [smn_console.cpp:256 + 0xd] 4 sourcepawn.jit.x86.so!sp:oolScope::~PoolSco pe [pool-allocator.cpp:82 + 0xc] 5 0x88c43d89 6 sourcepawn.jit.x86.so!sp::ScriptedInvoker::In voke [scripted-invoker.cpp:296 + 0x1f] 7 0x8 8 0xecdf3908 9 sourcemod.logic.so + 0x558d0 10 sourcemod.2.csgo.so!ConsoleDetours::InternalD ispatch [ConsoleDetours.cpp66 + 0x10]

[Peace-Maker]

Originally Posted by hlstriker Did any gamedata update (I'm using the latest)? Simply testing FakeClientCommand(SourceTV_GetBotIndex(), "status") will crash my Linux server.

That's quite possible, but I don't have access to a windows machine right now to check the gamedata

[hlstriker]

Originally Posted by Peace-Maker That's quite possible, but I don't have access to a windows machine right now to check the gamedata

It works fine on Windows. It's only Linux that's crashing for me.