[yokomo]

Hi amxmodx developers.. i would like to see these 3 natives in cstrike module since it use too often in certain mod.

- cs_give_player_item(id, "item_name") -- Same as fun module.
- cs_strip_user_weapons(id) -- Same as fun module.
- cs_strip_user_weapon(id, iCswId, iSlot = 0, bool:bSwitchIfActive = true) -- From here https://forums.alliedmods.net/showpo...7&postcount=42

Why need to use fun module just for these 2 natives?

[fysiks]

If it already exists then it doesn't need to be recreated unless there is additional functionality that is specific to Counter-Strike.

[Depresie]

if we are in the suggestions area i would like to metion the following suggestions

1. new native is_valid_player -> returns if is player connected + alive + 1<= id <= max players
2. find entity in a square/rectangle with definable x,y,z vector values

we should also have a sticky topic for suggestions

[yokomo]

Originally Posted by Depresie if we are in the suggestions area i would like to metion the following suggestions 1. new native is_valid_player -> returns if is player connected + alive + 1<= id <= max players 2. find entity in a square/rectangle with definable x,y,z vector values we should also have a sticky topic for suggestions

1. is_user_alive(id) already checked player is valid+connected+alive.
2. Never heard about this yet.

[Depresie]

@1

I dont know, but it seems like i have to check if 1<= attacker <=32 all the time in Ham_TakeDamage if i want to set damage higher or something for a player, else i will get run time errors, or worse, random crashes without any errors in the logs

I remember i had an run time error about it some time ago, and bugsy told me about that check, never got that error again in the logs again
After i did that check to all the fw_TakeDamage calls, the random server crashes have been reduced from 1-2 per day, to 1 every 3-4 days

[yokomo]

Originally Posted by Depresie @1 I dont know, but it seems like i have to check if 1<= attacker <=32 all the time in Ham_TakeDamage if i want to set damage higher or something for a player, else i will get run time errors, or worse, random crashes without any errors in the logs I remember i had an run time error about it some time ago, and bugsy told me about that check, never got that error again in the logs again After i did that check to all the fw_TakeDamage calls, the random server crashes have been reduced from 1-2 per day, to 1 every 3-4 days

Of course you need to check whether attacker is player or non-player. 1~32 is player.

So if you wanna multiplier attacker's damage then just check is_user_alive(attacker).

is_user_alive(index) native:

PHP Code:

static cell AMX_NATIVE_CALL is_user_alive(AMX *amx, cell *params) /* 1 param */
{
    int index = params[1];
    
    if (index < 1 || index > gpGlobals->maxClients)
    {
        return 0;
    }
    
    CPlayer* pPlayer = GET_PLAYER_POINTER_I(index);

    if (g_bmod_tfc)
    {
        edict_t *e = pPlayer->pEdict;
        if (e->v.flags & FL_SPECTATOR || 
            (!e->v.team || !e->v.playerclass))
        {
            return 0;
        }
    }
    
    return ((pPlayer->ingame && pPlayer->IsAlive()) ? 1 : 0);
} 


[Depresie]

well, i did check if the attacker is alive, but it was still needed to be checked if 1<=attacker<=32

Later Edit:

I just reviewed the old code, i didnt have any is_user_alive(attacker) in it... my bad, sorry

btw, quick question

is it needed to check if the victim is alive aswell?

[yokomo]

Originally Posted by Depresie and as you can see, is_user_alive doesn't check if the attacker is a player or a non player, so i got to use 1<= id <=32 all the time

Yes it does:

PHP Code:

    if (index < 1 || index > gpGlobals->maxClients)
    {
        return 0;
    } 


is it needed to check if the victim is alive or a player/non player entity aswell?

Since you already hook for "player" classname then there is no need to check whether it player/non-player. About alive check i'm not sure about it, but for me no need to check because victim is obviously alive.

[Depresie]

i was a little bit confused with take damage, thanks alot you made it clear for me

[Arkshine]

Just because you don't feel to use fun module is not really a valid argument.
That's said,

cs_give_player_item: Actually we added recently cs_create_entity because CS stores classname into an hashtable for faster lookup, this would make sense to have a CS version of this one as well, I guess.
cs_strip_user_weapons: I see no valid reason here.
cs_strip_user_weapon: I think it has been requested, is it useful to remove silently a weapon? You are supposed to control what weapons you give to a player. Do you have an example of situation?
find entity in a square/rectangle: You mean likely UTIL_EntitiesInBox?