[Dragonshadow]

I have a getrandomint(0, 13)

I want it so that if it rolls say a 6, its next roll can NOT be the same number.

I have an array of strings, and use something like this

PHP Code:


#define numphrases 10

new const String:phrases[numphrases][] = {
    "one",
    "two",
    "three",
    "four",
    "five",
    "six",
    "seven",
    "eight",
    "nine",
    "ten"
};

Format(message, sizeof(message), phrases[GetRandomInt(0, numphrases-1)]);

SayText2(client, message); 


to print them.

Well I want it so if it prints eight from the "roll", it can't print eight for the next three "rolls"

Does that make sense?

[Gachl]

PHP Code:

new iLastRandom[3];

public GetBetterRandomInt(min, max)
{
    if (max > sizeof(iLastRandom))
        return GetRandomInt(min, max);
    new iRandom = GetRandomInt(min, max);
    new bool:bWrong = true;
    while (bWrong)
    {
        bWrong = false;
        for (new i = 0; i < sizeof(iLastRandom); i++)
        {
            if (iLastRandom[i] == iRandom)
            {
                bWrong = true;
                break;
            }
        }
        if (bWrong)
            iRandom = GetRandomInt(min, max);
    }
    for (new j = sizeof(iLastRandom) - 2; j >= 0; j++)
    {
        iLastRandom[j+1] = iLastRandom[j];
    }
    iLastRandom[0] = iRandom;
    return iRandom;
} 


I have *no* idea if this works, but if you call GetBetterRandomInt(min, max) it should give you a random number between min and max which is not in the last sizeof(iLastRandom) results.
eg. usage:

PHP Code:

Format(message, sizeof(message), phrases[GetBetterRandomInt(0, numphrases-1)]); 


edit: fixed small error in code
edit2: fixed huge error in code

[Dragonshadow]

Well before I have a chance to test it, I'm using this in more than one timer with more than one array and more than one client... Will that screw anything up?

[Gachl]

Umm, well if timer1, timer2, timer3 and timer4 and then timer1 again run this function its possible that timer1 can get the same random int twice, because timer2, timer3 and timer4 pushed the first int of timer1 out of the duplicate array

[Dragonshadow]

Bump, Gachl seems to be busy and hasn't responded to my last pm, so this is what we have so far:

PHP Code:

new iLastRandom[12][3]; 

public GetBetterRandomInt(min, max, rid) 
{ 
    if (max > sizeof(iLastRandom[])) 
        return GetRandomInt(min, max); 
    new iRandom = GetRandomInt(min, max); 
    new bool:bWrong = true; 
    while (bWrong) 
    { 
        bWrong = false; 
        for (new i = 0; i < sizeof(iLastRandom[]); i++) 
        { 
            if (iLastRandom[rid][i] == iRandom) 
            { 
                bWrong = true; 
                break; 
            } 
        } 
        if (bWrong) 
            iRandom = GetRandomInt(min, max); 
    } 
    for (new j = sizeof(iLastRandom[]) - 2; j >= 0; j++) 
    { 
        iLastRandom[rid][j+1] = iLastRandom[rid][j]; 
    } 
    iLastRandom[rid][0] = iRandom; 
    return iRandom; 
} 


That is supposed to prevent each (uhh) thing I use it on from rolling the same thing.
Problem is it doesn't work at all.

PHP Code:

new random = GetBetterRandomInt(0, 13, 0);

Format(message, sizeof(message), "\x03%s\x01 Rolled a\x04 %i\x01!", clientname, random);

SayText2(client, message);
return Plugin_Continue; 


With that I can still roll the same number twice, even three times in a row.

Same this with:

PHP Code:

// Start of plugin
#define numroll 12

new const String:rollphrases[numroll][] = {
//stuff here
};
////////////////////////

// In function
Format(message, sizeof(message), rollphrases[GetBetterRandomInt(0, numroll-1, 1)], clientname);

SayText2(client, message);
return Plugin_Continue; 


I can "roll" the same string multiple times in a row.

[FeuerSturm]

What I'd do is us the normal GetRandomInt, save the value in
a global indexed variable and compare it on the next roll...
roll again if it's the same, update the global variable with the new value if it isn't and be happy

[Dragonshadow]

Originally Posted by FeuerSturm What I'd do is us the normal GetRandomInt, save the value in a global indexed variable and compare it on the next roll... roll again if it's the same, update the global variable with the new value if it isn't and be happy

Well with the rolling 0-13 that would be fine, but I for the strings I want to "blacklist" it for the next 3 rolls, that way I don't roll something, roll something else, then roll the first thing again.

[FeuerSturm]

you can still do that with using a 2D array

example:

PHP Code:

new g_LastRolls[MAXPLAYERS+1][3]
new g_LastRollPos[MAXPLAYERS+1] 


then on "OnClientPostAdminCheck"

PHP Code:

g_LastRolls[client][0] = -1
g_LastRolls[client][1] = -1
g_LastRolls[client][2] = -1
g_LastRollPos[client] = -1 


then once you have a "randomnum"

PHP Code:

new bool:foundunused = false
for(new i = 0; i < 3; i++)
{
 if(g_LastRolls[client][i] != randomnum)
 {
  // we found an unused number!
  if(g_LastRollPos[client] == 2)
  {
   g_LastRollPos[client] = 0
 
  }
  else
  {
   g_LastRollPos[client]++
  }
  g_LastRolls[client][g_LastRollPos[client]] = randomnum
  foundunused = true
 }
}
if(foundunused)
{
 // do code with your found random number here!
}
else
{
 // the random number was already used within the last 3 rolls
} 


Basically that should work, but as I just wrote that up quickly I take
no responsability!

[Gachl]

well I've never tested my code I've sent you and I was away this weekend, but as soon as I have some spare time I'll test it and send you a working version.

[Dragonshadow]

Originally Posted by Gachl well I've never tested my code I've sent you and I was away this weekend, but as soon as I have some spare time I'll test it and send you a working version.

Cool cool