motd prints all playing players in rows

TheBladerX · **Author**

Hello, what am I missing here? I would like to print all players into motd, this is the code:

Code:

/* Plugin generated by AMXX-Studio */

#include <amxmodx>

new player_name[33][64];
new g_maxplayers;

public plugin_init() {
	register_clcmd("say /hraci", "player_skills");
	g_maxplayers = get_maxplayers();
}

public client_connect(id)
{
	get_user_name(id, player_name[id], 63);
}	
	
public player_skills(id){
		
	new message[2048]
	new formats[128]

	add(message,2047,"<HTML><head></head><body bgcolor=#000000><font color=#FFB000>")

	for (id=1; id<=g_maxplayers; id++) {
		format(formats, 127, "%s",  player_name[id])
	}
	return PLUGIN_HANDLED
}

OciXCrom · *Last edited by OciXCrom; 02-05-2019 at 08:44.*

You're adding the players in the string "formats", but you're not using the string anywhere.

iceeedr · 02-05-2019 , 08:50 Re: motd prints all playing players in rows

To begin with, the name is a string limited to 32 characters, not 64. Use charsmax () as a good practice. Did you create motd where?

TheBladerX · *Last edited by TheBladerX; 02-05-2019 at 09:42.*

Code:

new player_name[33][32];

format(formats, charsmax(player_name), "%s",  player_name[id])

Like this?

.. I mean, wouldn't this open a motd? Not like file.txt but these values in it.

eat1k · *Last edited by eat1k; 02-05-2019 at 15:33.*

PHP Code:


			
#include <amxmodx>
#include <amxmisc>

public plugin_init()
{
    register_clcmd("say /hraci", "player_skills");
}

public player_skills(id)
{
    new szMessage[MAX_MOTD_LENGTH], iLen;

    iLen = formatex(szMessage, charsmax(szMessage), "<HTML><head></head><body bgcolor=#000000><font color=#FFB000>");

    new iPlayers[MAX_PLAYERS], iPlayerCount;
    get_players_ex(iPlayers, iPlayerCount, GetPlayers_ExcludeHLTV|GetPlayers_ExcludeBots);

    for(new i; i < iPlayerCount; i++)
        iLen += formatex(szMessage[iLen], charsmax(szMessage) - iLen, "%n<br>", iPlayers[i]);

    show_motd(id, szMessage, "Info players");
    return PLUGIN_HANDLED;
}

CrazY. · *Last edited by CrazY.; 02-05-2019 at 15:18.*

Code:

iLen += formatex(szMessage, charsmax(szMessage) - iLen, "%n", iPlayers[i]);

Code:

iLen += formatex(szMessage[iLen], charsmax(szMessage) - iLen, "%n<br>", iPlayers[i]);

DjSoftero · *Last edited by DjSoftero; 02-05-2019 at 16:20. Reason: nvm*

Quote:

Originally Posted by CrazY.

Code:

iLen += formatex(szMessage, charsmax(szMessage) - iLen, "%n", iPlayers[i]);

Code:

iLen += formatex(szMessage[iLen], charsmax(szMessage) - iLen, "%n<br>", iPlayers[i]);

I don't understand the szMessage[iLen] part.

JocAnis · 02-05-2019 , 15:44 Re: motd prints all playing players in rows

I dont understand %n part

eat1k · 02-05-2019 , 15:47 Re: motd prints all playing players in rows

Quote:

Originally Posted by CrazY.

Code:

iLen += formatex(szMessage, charsmax(szMessage) - iLen, "%n", iPlayers[i]);

Code:

iLen += formatex(szMessage[iLen], charsmax(szMessage) - iLen, "%n<br>", iPlayers[i]);

Yeah, thanks! Fixed. I forgot it.

Quote:

Originally Posted by JocAnis

I dont understand %n part

The nickname of the player. Check this - https://github.com/alliedmodders/amxmodx/pull/93

iceeedr · 02-05-2019 , 15:48 Re: motd prints all playing players in rows

He wrote whole plugin in Amx 1.9 %n automatically catch user_name of the id, in case iplayers[i]