[RedSword]

Hi there,

the following should be changed for approval :

• Your code is prone to error. i.e. calling "sm_credits" from server console. It seems to be the case for almost all your commands.
• While your "sm_awards" currently produce an error while trying to PrintToClient to the server, it does send a menu to the server just before (L213 / L297). While this doesn't produce a crash or an error, it is an unwanted behaviour (I did file a bug report on this).
• You load "common.phrases", but there is no %t/%T in all your code !

Beside, you should also remove FCVAR_REPLICATED, as this can produce console error for the client.

Other than that, I don't see any real problem.

[Franc1sco]

Originally Posted by RedSword Hi there, the following should be changed for approval : Your code is prone to error. i.e. calling "sm_credits" from server console. It seems to be the case for almost all your commands. While your "sm_awards" currently produce an error while trying to PrintToClient to the server, it does send a menu to the server just before (L213 / L297). While this doesn't produce a crash or an error, it is an unwanted behaviour (I did file a bug report on this). You load "common.phrases", but there is no %t/%T in all your code ! Beside, you should also remove FCVAR_REPLICATED, as this can produce console error for the client. Other than that, I don't see any real problem.

1. fixed
2. fixed
I added:

PHP Code:

    if(client == 0) // if is console
    {
        PrintToServer("you need to be ingame for use this"); // reply to console
        return; // dont continue
    } 


3. removed
4. removed



--------------------------------------------------------------------

new version 1.2

-bugfixed for approval

[RedSword]

It is still possible to get an error using sm_setcredits from server console.

EDIT : It would possible by the way to use "Command is in-game only" from common.phrases, rather than creating your own phrase, that way your plugin is (partially) multilingual.

[Franc1sco]

Originally Posted by RedSword It is still possible to get an error using sm_setcredits from server console.

ups ok fixed

[RedSword]

Approved.

[Franc1sco]

Originally Posted by RedSword EDIT : It would possible by the way to use "Command is in-game only" from common.phrases, rather than creating your own phrase, that way your plugin is (partially) multilingual.

Added.

Originally Posted by RedSword Approved.

ok thanks

[healasuk]

How do you edit the amount of credits that is required to buy a certain award?

[Franc1sco]

Originally Posted by healasuk How do you edit the amount of credits that is required to buy a certain award?

Soon I will add cvars for it

[healasuk]

I'll be waiting for the cvars to be added

[sjvcs]

hello, do it to the T and CT are different credits ..
I think it would be good