[addons_zz]

Originally Posted by Shattered Heart Lynx gal_nom_mapfile "#" disables nominations. (make nomination of mapcycle.txt maps only default?) Thank you for supporting the plugin!

You are welcome

Now, are you saying that it is not allowing any nominations when do you use "#"? If was it that, could be a bug because I was not removing double quotes.

If is not that, the value # does not disables the nominations, it use whatever map file list do you have over the cvar 'mapcyclefile'. I updated the documentation to be more descriptive.

PHP Code:

// Specifies the file to use which holds the names of the maps, listed
// one per line, that players can nominate. You can specify a relative
// path before the filename, relative from your gamemod folder (i.e.
// "addons/amxmodx/configs/mymapcycle.txt").
// Use * for all maps in the server's maps folder.
// Use # for your mapcycle (whatever file is on the cvar 'mapcyclefile').
gal_nom_mapfile "*" 


Originally Posted by Shattered Heart Lynx Hello Galileo is not storing its data files in a custom "amxx_datadir" directory. (Files go directly to amxmodx/data/ regardless of what is set on amxx_datadir)

I will review this code and make certain it is working properly and release a new hotfix version improving that. The actually code, was not working because it relies on an existing folder called 'Galileo' on your new data dir. Now I implemented auto-creation to that directory and it must not happen anymore. It should be released soon.

I cannot test it right now, but if you want to try it, it is already on the 'v2.1.9d' branch over github if you want to see.
Changes:
https://github.com/addonszz/Galileo/commits/v2.1.9d

Download link:
https://github.com/addonszz/Galileo/archive/v2.1.9d.zip

[gabuch2]

Originally Posted by addons_zz Now, are you saying that it is not allowing any nominations when do you use "#"? If was it that, could be a bug because I was not removing double quotes. If is not that, the value # does not disables the nominations, it use whatever map file list do you have over the cvar 'mapcyclefile'. I updated the documentation to be more descriptive.

mapcycle.txt is indeed the value of the cvar mapcyclefile. (or else my server wouldn't be able to change maps )

I am aware of the functionality of the "#" value on the cvar. I was reporting a possible bug.

[addons_zz]

Released newer version:

2016-03-13 | v2.2.1

1. Fixed wrong version number on files.

2016-03-13 | v2.2

1. Added to the cvar 'gal_vote_mapfile', the option '*' to use all maps in the server's maps folder as map fillers.
2. Fixed map extension now showing up.
3. Implemented the 'Galileo' data directory auto-creation.
4. Updated the cvar 'gal_nom_mapfile' documentation.
5. Fixed the possibility to start rock the vote after a map voting.

2016-03-05 | v2.1.1 ~ 2016-03-09 | v2.1.9

1. Fixed wrong version number on files.
2. Corrected "pl" translations misspellings.
3. Fixed do not reset the round limiters feature.
4. Added to restore RTV original values on 'sv_restartround' event.
5. Fixed extra map restart the on 'gal_srv_start' cvar feature.
6. Fixed nominations not showing/allowing all nominated maps.
7. Fixed bad vote start timer.
8. Fixed start on the last map feature, cvar 'gal_srv_start', using a wrong next map position.
9. Fixed the 'say nextmap' command not showing the next map.

[PartialCloning]

An admin should really change the title of this plugin. Addon_zz not only stole the name and layout which now makes it confusing to tell that this is a fork and not the original, but he also copied the cvar variable "gal_version", which he now uses to show servers using "his" plugin, when in fact most of those servers are using Brad's plugin.

[addons_zz]

Because this is the same plugin, same algorithms, they are the same features and they must behave the same. If was missed something, let me know. Whatever, now there more cvars, different variables names, more splinted and different functions workflow and some Unit Tests. This is the same plugin and I am supporting it. Code evolves, code changes... Don't be square or live in the past, then tell now I stole the plugin? This is a debacle. Please, report to trash this thread and ban me, 'cuz I'm waist my time, your time, everybody else's time. I dare that y'all have more things to do as I have to, so please help me help y'all, as I am a crazy machine which cannot stop until get banned from here, from this reality. I hate this place. This zoo. This prison. Whatever you want to call it, I can't stand it any longer. It's the smell, if there is such a thing. I feel saturated by it. I can taste it stink and every time I do, I fear that I've somehow been infected by it.

[.:cs.stambeto:.]

Why choose when to extend my time it gives in rounds and not in time.

[addons_zz]

If you are using only 'mp_timelimit' it gives you in minutes.

If you are using 'mp_maxrounds/mp_winlimit' if gives you in rounds.

If you are usin both 'mp_timelimit/mp_maxrounds/mp_winlimit' if gives you the first to get close to finish the map. For example, suppose that there are 3 minutes left and 10 rounds remaining. It will give you by minutes, and not by rounds. And to avoid re-voting when the 10 rounds end up. It will temporarily disables the rounds voting when the rounds remaining end up.

But if you are only using 'mp_timelimit'... If you have access to your game server's console, type the following in the server console:

• status
• meta list
• amxx list
• amxx cvars

If you don't have access the your game server's console, join your server and type the
following in your game console:

• status
• rcon_password your_rcon_password
• rcon meta list
• rcon amxx list
• rcon amxx cvars

1. Paste here everything from the status command *except* the player list.
2. Paste here the entire result from the meta list and amxx plugins commands.
3. Paste here *only* the CVARs that contain "galileo.amxx" in the last column
   from the amxx cvars command. They will be grouped together.

[gabuch2]

The configureRTV_votingType() method is breaking non-round based mods. After every player rocked the vote, a vote to change the map will never appear. Error: Invalid Cvar Pointer.

Maybe you can do something like this?

PHP Code:

stock configureRTV_votingType()
{
    if(is_running("cstrike") || is_running("czero"))
    {
        new minutes_left   = get_timeleft() / 60
        new maxrounds_left = get_pcvar_num( g_maxrounds_pointer ) - g_total_rounds_played
        new winlimit_left  = get_pcvar_num( g_winlimit_pointer ) - max( g_total_CT_wins, g_total_terrorists_wins )
        
        if( minutes_left > maxrounds_left
            || minutes_left > winlimit_left  )
        {
            g_isVotingByRounds = true
            
            if( maxrounds_left >= winlimit_left )
            {
                g_is_maxrounds_extend = true
            }
            else
            {
                g_is_maxrounds_extend = false
            }
        }
    }
    else
    {
        //please check, this may need a proper implementation
        g_isVotingByRounds = false;
        g_is_maxrounds_extend = false;
    }
} 


This fixed the issue on Sven Co-op. (assuming it's configured to immediately change the map on rockthevote success)

Untested elsewhere or other configurations.

[addons_zz]

Let me see. You are running Galileo on 'Sven Co-op' your code fixed the bug.

Now, before your fix, the plugin was throwing 'Invalid Cvar Pointer' error, so, this means that 'Sven Co-op' does not have some of these cvars:

    g_maxrounds_pointer  = get_cvar_pointer( "mp_maxrounds" )
    g_winlimit_pointer   = get_cvar_pointer( "mp_winlimit" )
    g_freezetime_pointer = get_cvar_pointer( "mp_freezetime" )
    g_timelimit_pointer  = get_cvar_pointer( "mp_timelimit" )

Hence the plugin was stopping then not starting the voting.

1. Well, I bad named they, would be proper 'cvar_' instead of 'g_..._pointer'. I am going to change it.
2. I will look into the 'Sven Co-op' to proper fix it.
3. As this is a very relevant issue, soon as it is fixed, I am going to release a new version.

Thank you for codding and reporting. And about these variables, I added some documentation.

/**
 * This function choose what RTV's type will be used to 'rock the vote'. The types are:
 * 1) Per rounds.
 * 1.1) Is by mp_winlimit expiration proximity?
 * 1.2) Is by mp_maxrounds expiration proximity?
 * 2) Per minutes.
 * These data are used to display the voting menu and proper set the voting flow.
 */
stock configureRtvVotingType()
{

[WaSaAa1]

Galileo had and has several critical bugs (in my opinion), one the most famous is that often does not show votemaps and its version of Galileo code remains the same in that part so I understand that it will be repeated situation (bug).

Brad already commented this bug and gave a possible solution:
https://forums.alliedmods.net/showpo...&postcount=511


For example, in your version: (Bug)

        get_user_menu( player_id, menu_id, menuKeysUnused )
        
        if( menu_id == 0 || menu_id == g_chooseMapQuestionMenuId )
        {
            show_menu( player_id, menuKeys, menu_body, ( g_pendingVoteCountdown == 1 ? 1 : 2 ), MENU_CHOOSEMAP_QUESTION )
        }

Fix:

            show_menu( player_id, menuKeys, menu_body, ( g_pendingVoteCountdown == 1 ? 1 : 2 ), MENU_CHOOSEMAP_QUESTION )

When removing the previous code, the menu is replaced always, as for example in the CS 1.6, the menu teams often given as an open menu even having chosen team. (With weapons menu the same)

PS:Reoccurs in more parts of the code, a total of 3 times.

I will try your version to check Galileo critical errors and try and solve them.