[PurposeLessx]

Hey friends, I make a plugin. It has 3951 lines so I want to make it optimized for server.
In menus, what I should use?

static data[6], name[32], access, callback, key;
menu_item_getinfo(menu, item, access, data, charsmax(data), _, _, callback);
key = str_to_num(data);

// or

new data[6], name[32], access, callback;
menu_item_getinfo(menu, item, access, data, charsmax(data), _, _, callback);
new key = str_to_num(data);

[klippy]

It doesn't matter.

[PurposeLessx]

So what should I do for optimizing plugin?

Example commands;

PHP Code:

//#define MAX_CLIENTS                     32 
            new TeamName:team;
            for(new Uid = 1; Uid <= MAX_CLIENTS; Uid++)
            {
                team = get_member(Uid, m_iTeam);

                if(team == TEAM_CT && is_user_alive(Uid))
                {
                    set_entvar(Uid, var_takedamage, DAMAGE_NO);
                    set_entvar(Uid, var_health, 99999.0);
                    unammocuk[Uid] = true;
                }
            }
            clcmd_ctmenu(id);
            rh_emit_sound2(0, 0, CHAN_AUTO, sound_godmode, VOL_NORM, ATTN_NORM, ATTN_NORM, 0, PITCH_NORM); 


[OciXCrom]

For starters, using get_players() to loop all players.

[PurposeLessx]

Originally Posted by OciXCrom For starters, using get_players() to loop all players.

The all servers which use my plugin is 32 players. Do I need check it?

[OciXCrom]

Do they have all 32 players online 24/7? Probably not.
The only right way to loop all players is by using get_players().

[PurposeLessx]

Originally Posted by OciXCrom Do they have all 32 players online 24/7? Probably not. The only right way to loop all players is by using get_players().

Is get_players more optimized than for(new .... , also ?

[maqi]

Originally Posted by PurposeLessx Is get_players more optimized than for(new .... , also ?

What kind of question is this ?

[PurposeLessx]

My english is not good enough as you all. My bad.
I guess you understand my question, so there is no problem .

"Is using get_players more optimized than using for(new Uid = 1 ; Uid <= 32 ; Uid++)"

[OciXCrom]

If it wasn't, would I be writing this in a thread that says "OPTIMIZE PLUGIN"?