[GlobalPlague]

Hello, this is the warning i get:



This is how the code looks like:



Here is the source code:

	    // Custom sounds
             new i
    
             for (i = 0; i < ZM_DEATH; i++)
             precache_sound(death_zm[i])
    
             for (i = 0; i < ZM_IDLE; i++)
             precache_sound(idle_zm[i])
    
             for (i = 0; i < ZM_PAIN; i++)
             precache_sound(pain_zm[i])
}

Why does the compiler says the code isn't well ordered? I don't see any disorder. Would you tell me how to fix the warning, please?

[GlobalPlague]

UPDATE: Problem is solved. I didn't see the problem using the AMXX Studio, but when i opened the code with Notepad, i saw that some of the code is moved a little bit forward, so i deleted some space that was behind the code and now the code is ordered and the compiler doesn't show the warning.

[Natsheh]

Because the compiler expects the code to be in curly brackets .

[DJEarthQuake]

Display whitespace to see what is going on. Loose from tabbing into spaces. Clearing whitespace helps too as you noted.

PHP Code:

»       ····//·Custom·sounds
·············new·i
····
·············for·(i·=·0;·i·<·ZM_DEATH;·i++)
·············precache_sound(death_zm[i])
····
·············for·(i·=·0;·i·<·ZM_IDLE;·i++)
·············precache_sound(idle_zm[i])
····
·············for·(i·=·0;·i·<·ZM_PAIN;·i++)
·············precache_sound(pain_zm[i])
} 


Pick tabs or spaces but not both.

·············//·Custom·sounds
·············new·i

·············for·(i·=·0;·i·<·ZM_DEATH;·i++)
·············precache_sound(death_zm[i])

·············for·(i·=·0;·i·<·ZM_IDLE;·i++)
·············precache_sound(idle_zm[i])

·············for·(i·=·0;·i·<·ZM_PAIN;·i++)
·············precache_sound(pain_zm[i])
}

[fysiks]

Use tabs. Show whitespace. Much easier to maintain proper indentation.

Originally Posted by Natsheh Because the compiler expects the code to be in curly brackets .

I actually don't think that if there is only a single line that the compiler cares (though the person should care). I dislike not using braces most of the time. I basically only skip braces when I'm returning a value and ending the function execution.

[GlobalPlague]

Originally Posted by DJEarthQuake Display whitespace to see what is going on. Loose from tabbing into spaces. Clearing whitespace helps too as you noted. PHP Code: »       ····//·Custom·sounds ·············new·i ···· ·············for·(i·=·0;·i·<·ZM_DEATH;·i++) ·············precache_sound(death_zm[i]) ···· ·············for·(i·=·0;·i·<·ZM_IDLE;·i++) ·············precache_sound(idle_zm[i]) ···· ·············for·(i·=·0;·i·<·ZM_PAIN;·i++) ·············precache_sound(pain_zm[i]) }  Pick tabs or spaces but not both. ·············//·Custom·sounds ·············new·i ·············for·(i·=·0;·i·<·ZM_DEATH;·i++) ·············precache_sound(death_zm[i]) ·············for·(i·=·0;·i·<·ZM_IDLE;·i++) ·············precache_sound(idle_zm[i]) ·············for·(i·=·0;·i·<·ZM_PAIN;·i++) ·············precache_sound(pain_zm[i]) }

By "whitespace" you mean empty space created with the SPACE button, instead of with the Tab button? Well, i wasn't aware that the Tab button creates a single empty space of the size the compiler needs. Until recently, i was creating empty space with the SPACE button or by copying already existing empty and putting it where there should be empty space.

And i didn't understand what you mean by pick tabs or spaces but not both. And what do the point you added to the code mean?

[GlobalPlague]

Originally Posted by Natsheh Because the compiler expects the code to be in curly brackets .

The code already has a curly bracket at the end. Should there be more curly brackets? If yes, where should they be?

Originally Posted by fysiks Use tabs. Show whitespace. Much easier to maintain proper indentation. I actually don't think that if there is only a single line that the compiler cares (though the person should care). I dislike not using braces most of the time. I basically only skip braces when I'm returning a value and ending the function execution.

Yes, now i know i should do this.

[HamletEagle]

PHP Code:

for(...)
statement 


is valid from the point of view of the compiler. However, as mentioned above, it is not a great idea.

A more readable version is:

PHP Code:

for(...)
{
    statement
} 


[GlobalPlague]

Originally Posted by HamletEagle PHP Code: for(...) statement  is valid from the point of view of the compiler. However, as mentioned above, it is not a great idea. A more readable version is: PHP Code: for(...) {     statement }

So, the following code:

PHP Code:

        // Custom sounds
             new i
    
             for (i = 0; i < ZM_DEATH; i++)
             precache_sound(death_zm[i])
    
             for (i = 0; i < ZM_IDLE; i++)
             precache_sound(idle_zm[i])
    
             for (i = 0; i < ZM_PAIN; i++)
             precache_sound(pain_zm[i])
} 


...actually should be like this:

PHP Code:

        // Custom sounds

}
             new i
    
             for (i = 0; i < ZM_DEATH; i++)
             precache_sound(death_zm[i])
    
             for (i = 0; i < ZM_IDLE; i++)
             precache_sound(idle_zm[i])
    
             for (i = 0; i < ZM_PAIN; i++)
             precache_sound(pain_zm[i])
} 


Correct?

[fysiks]

Originally Posted by GlobalPlague By "whitespace" you mean empty space created with the SPACE button, instead of with the Tab button? Well, i wasn't aware that the Tab button creates a single empty space of the size the compiler needs. Until recently, i was creating empty space with the SPACE button or by copying already existing empty and putting it where there should be empty space. And i didn't understand what you mean by pick tabs or spaces but not both. And what do the point you added to the code mean?

The term "whitespace" most often refers to both spaces and tabs. You can look up the term for more info but in this context (indentation) we're talking about just spaces and tabs.

When indenting code, you are generating whitespace for the purpose of making the code more readable by putting code that is in a different scope in at a different indentation depth. You can create indentation white space using either tabs OR spaces. If you try to mix tabs AND spaces together, it will most often create inconsistent indentation because tabs are variable in size while spaces are not. I like tabs because two different people working on the same code can set up their editors to display the tab character as different sizes (some people like to have more space).

Originally Posted by GlobalPlague So, the following code: PHP Code:         // Custom sounds              new i                   for (i = 0; i < ZM_DEATH; i++)              precache_sound(death_zm[i])                   for (i = 0; i < ZM_IDLE; i++)              precache_sound(idle_zm[i])                   for (i = 0; i < ZM_PAIN; i++)              precache_sound(pain_zm[i]) }  ...actually should be like this: PHP Code:         // Custom sounds }              new i                   for (i = 0; i < ZM_DEATH; i++)              precache_sound(death_zm[i])                   for (i = 0; i < ZM_IDLE; i++)              precache_sound(idle_zm[i])                   for (i = 0; i < ZM_PAIN; i++)              precache_sound(pain_zm[i]) }  Correct?

No, he means:

PHP Code:

             for (i = 0; i < ZM_DEATH; i++)
             {
                          precache_sound(death_zm[i])
             }