Make script better. "Just Joined" - Page 3

xOscar

Quote:

Originally Posted by Magnificent

Why u guys making a formatex? -_-

PHP Code:


			
#include < amxmodx >
#include < amxmisc >

#define PLUGIN "justJoined"
#define VERSION "0.1"

public plugin_init()
    register_plugin(PLUGIN, VERSION, "Blend");

public client_putinserver(id)
{
    new szInfo[4][32]
    get_user_name(id, szInfo[0], 31)
    get_user_authid(id, szInfo[1], 31)
    get_user_ip(id, szInfo[2], 31, 1)
    
    server_print("] Name: %s [%s]^n] SteamID: %s^n] IP: %s", szInfo[0], is_user_admin(id) ? "ADMIN" : "USER", szInfo[1], szInfo[2]);
}

Beat that newbies.

Will that optimize?

EDUTz

And please explain why making like this isn't the simpliest way to do it:

Code:

#include < amxmodx > 
#include < amxmisc > 

#define PLUGIN "justJoined" 
#define VERSION "0.1" 

public plugin_init() 
    register_plugin(PLUGIN, VERSION, "Blend"); 

public client_putinserver(id) 
{ 
    server_print("] Name: %s [%s]^n] SteamID: %s^n] IP: %s", get_user_name(id), is_user_admin(id) ? "ADMIN" : "USER", get_user_authid(id), get_user_ip(id)); 
}

Magnificent · *Last edited by Magnificent; 11-23-2012 at 13:05.*

If you dont know anything about scripting,
please dont spam this thread..

xOscar

Please.. If you want to change something in future, it's better with more rows to edit..

EDUTz

I just gave an example, never tryed to compile it, although i've seen my mistakes ...
humble appologises.

I tought it's a lot cleaner if you compress it.

micapat

new szInfo[4][32] -> new szInfo[3][32]

But doing this is the same than to have 3 arrays, it's just less understandable.

Btw, charsmax( ) is better than write directly the array size.

No more to say.

xOscar

Okay, I chould only use 1 array for Name, SteamID etc?

YamiKaitou

You could, but there is no advantage to it. There are 2 disadvantages that I can think of though, readability and unneeded memory allocation (ie, creating an array that is larger than the maximum you will use)

xOscar

Quote:

Originally Posted by YamiKaitou

You could, but there is no advantage to it. There are 2 disadvantages that I can think of though, readability and unneeded memory allocation (ie, creating an array that is larger than the maximum you will use)

Ok, didn't think about that every cell will be 32 long.

meTaLiCroSS

Quote:

Originally Posted by Magnificent

Why u guys making a formatex? -_-

PHP Code:


			
#include < amxmodx >

#include < amxmisc >



#define PLUGIN "justJoined"

#define VERSION "0.1"



public plugin_init()

    register_plugin(PLUGIN, VERSION, "Blend");



public client_putinserver(id)

{

    new szInfo[4][32]

    get_user_name(id, szInfo[0], 31)

    get_user_authid(id, szInfo[1], 31)

    get_user_ip(id, szInfo[2], 31, 1)

    

    server_print("] Name: %s [%s]^n] SteamID: %s^n] IP: %s", szInfo[0], is_user_admin(id) ? "ADMIN" : "USER", szInfo[1], szInfo[2]);

}

Beat that newbies.

This is the right answer to your question