[mrshark45]

Originally Posted by Natsheh Loop through using get_players array with these flags ch Also you should check if player is connected first before checking if he's Bot in standard player loop the thing is the native might result in an error not continuing the rest of the code. Also instead of passing the id in the data of the thread query you should pass the name directly since if you have too many queries and it needs to take an amount of time to execute and in that time the player leaves (disconnect) the data is longer saved. Unless some1 else joined in his slot. Also seems like you are getting the value of the wrong column SQL_ReadResult(query, 1) column One is for the name right? If I'm not mistaken?

And I pass the data to load the timeplayed so I need to pass the id so I can acces the variable TimePlayed[id], I can't pass the name.

[JusTGo]

Your data is being rested because player can disconnect before reaching client_putinserver which will result in updating player time with 0 time because it didn't load the user time yet...
to fix this simply check if the server loaded the player data before updating it.

something like this should do it :

PHP Code:

new bool:g_Loaded[33]

public handleLoadData(failstate, Handle:query, error[], errnum, data[], size){
    if(failstate != TQUERY_SUCCESS){
        log_amx("SQL Insert error: %s",error);
        return;
    }
    
    new id = data[0];
    if(!is_user_connected(id)) return;
    
    new Name[32];
    get_user_name(id, Name,31)

    if(SQL_MoreResults(query)){
        TimePlayed[id] = SQL_ReadResult(query, 1);
    }else{
        TimePlayed[id] = 0;

        formatex(gszQuery, charsmax(gszQuery), "INSERT INTO `TimePlayed` VALUES ('%s', 0)", Name);
        SQL_ThreadQuery(gTuple, "handleStandard", gszQuery);
    }
    g_Loaded[id] = true;
}

public client_disconnected(id){
    if(g_Loaded[id] == true) {
        UpdatePlayerTimePlayed(id);
        g_Loaded[id] = false;
    }
} 


[JocAnis]

Also saving/loading on nick isnt that smart..cuz you will have a lot of duplicated names on the server

EDIT: Doing one big query for updating all players will also avoid the problem which @Natsheh told you (about client_disconnect), i wrote it some months ago, i really suggest you to use that one and not your loop and update every player seperately...:

https://forums.alliedmods.net/showpo...1&postcount=22

[Natsheh]

Also don't use SQL_MoreResult to check if the query has found something use SQL_NumResults(Handle:query)

PHP Code:

loadPlayerTimePlayed(id){
    new Name[32];
    get_user_name(id, Name,31)

    formatex(gszQuery, charsmax(gszQuery), "SELECT * FROM `TimePlayed` WHERE Name='%s'", Name);
    SQL_ThreadQuery(gTuple, "handleLoadData", gszQuery, Name, sizeof(Name));
}
public handleLoadData(failstate, Handle:query, error[], errnum, data[], size){
    if(failstate != TQUERY_SUCCESS){
        log_amx("SQL Insert error: %s",error);
        return;
    }

        new id = get_user_index(data);
        if(!id) return;
    if(SQL_NumResults(query)){
        TimePlayed[id] = SQL_ReadResult(query, 1);
    }else{
        TimePlayed[id] = 0;

        formatex(gszQuery, charsmax(gszQuery), "INSERT INTO `TimePlayed` VALUES ('%s', 0)", data);
        SQL_ThreadQuery(gTuple, "handleStandard", gszQuery);
    }
} 


[mrshark45]

Originally Posted by JocAnis Also saving/loading on nick isnt that smart..cuz you will have a lot of duplicated names on the server EDIT: Doing one big query for updating all players will also avoid the problem which @Natsheh told you (about client_disconnect), i wrote it some months ago, i really suggest you to use that one and not your loop and update every player seperately...: https://forums.alliedmods.net/showpo...1&postcount=22

Ok, thanks , I understand now what he tried to tell me, I'll do it

[mrshark45]

Originally Posted by JusTGo Your data is being rested because player can disconnect before reaching client_putinserver which will result in updating player time with 0 time because it didn't load the user time yet... to fix this simply check if the server loaded the player data before updating it. something like this should do it : PHP Code: new bool:g_Loaded[33] public handleLoadData(failstate, Handle:query, error[], errnum, data[], size){     if(failstate != TQUERY_SUCCESS){         log_amx("SQL Insert error: %s",error);         return;     }          new id = data[0];     if(!is_user_connected(id)) return;          new Name[32];     get_user_name(id, Name,31)     if(SQL_MoreResults(query)){         TimePlayed[id] = SQL_ReadResult(query, 1);     }else{         TimePlayed[id] = 0;         formatex(gszQuery, charsmax(gszQuery), "INSERT INTO `TimePlayed` VALUES ('%s', 0)", Name);         SQL_ThreadQuery(gTuple, "handleStandard", gszQuery);     }     g_Loaded[id] = true; } public client_disconnected(id){     if(g_Loaded[id] == true) {         UpdatePlayerTimePlayed(id);         g_Loaded[id] = false;     } }

Thanks, I'll use a boolean to check that too, hope it'll work

[mrshark45]

Ok, thanks all for the info, look what I did, now on client_connect I load the TimePlayed:

PHP Code:

public client_connect(id){
    loadPlayerTimePlayed(id);
}


public loadPlayerTimePlayed(id)
{
    new Name[64], szTemp[512]
    get_user_name(id, Name, 63);
    
    new Data[1]
    Data[0] = id
    
    format(szTemp,charsmax(szTemp),"SELECT * FROM `TimePlayed` WHERE (`TimePlayed`.`Nickname` = '%s')", Name);
    SQL_ThreadQuery(gTuple,"handleLoadData",szTemp,Data,1)
}

public handleLoadData(FailState,Handle:Query,Error[],Errcode,Data[],DataSize)
{
    if(FailState == TQUERY_CONNECT_FAILED)
    {
        log_amx("Load - Could not connect to SQL database.  [%d] %s", Errcode, Error)
    }
    else if(FailState == TQUERY_QUERY_FAILED)
    {
        log_amx("Load Query failed. [%d] %s", Errcode, Error)
    }

    new id
    id = Data[0]
    
    if(SQL_NumResults(Query) < 1) 
    {
        new Name[64], szTemp[512];

        get_user_name(id, Name, 63);
        
        format(szTemp,charsmax(szTemp),"INSERT INTO `TimePlayed` ( `Nickname` , `TimePlayed`) VALUES ('%s','0');",Name)
        SQL_ThreadQuery(gTuple,"IgnoreHandle",szTemp)
    } 
    else 
    {
        TimePlayed[id] = SQL_ReadResult(Query, 1)
    }
    
    return PLUGIN_HANDLED;
} 


And I save the Timeplayed using a big query every minute, when the time is updating:

PHP Code:

public plugin_init(){
       set_task(15.0,"AddTimePlayed",0,"",0,"b",0)
}

public AddTimePlayed(id){
    for(new i = 0; i <= 32; i++){
        if(!is_user_bot(i) && is_user_connected(i)){
            TimePlayed[i]++;
        }
    }
    UpdateAllPlayers();
}


public UpdateAllPlayers()
{
    new  buffer[2048], len, players[ 32 ], Name[64], pnum
    get_players( players, pnum )

    len = formatex(buffer, 2047, "UPDATE TimePlayed \
        SET TimePlayed = ( case " )
        
    if( pnum <= 1 )
        return PLUGIN_HANDLED
        
    for( new i = 1; i <= pnum; i++ )
    {
        //if( !is_user_connected( i ) ) continue 
        get_user_name(i, Name, 63);
        if( TimePlayed[ i ] != 0 )
        {
            len += formatex( buffer[len], 2047-len, "when Nickname='%s' then '%d'", Name, TimePlayed[i] )
        }
    }
        
    len += formatex( buffer[len], 2047-len, " end )");

    SQL_ThreadQuery( gTuple, "IgnoreHandle", buffer ) 
        
    log_amx(buffer);
    return PLUGIN_HANDLED
} 


I hope it works now , I'll come back with details if it actually works.

[mrshark45]

Originally Posted by mrshark45 Thanks, I'll use a boolean to check that too, hope it'll work

I'll not use the boolean , because I'm not updating the timeplayed on client_disconnected anymore.