[Sam Tsuki]

Connorr's not being cocky. He's rightly pointing out that someone with more experience would have done a much better job. There are still numerous errors.

nvm...
Didn't take it personally :p

Scrap the loop below 'Check player names' in favour of cmd_target() or find_player(). Names can be 31 characters long. The fourth parameter to cmd_access() in give_nade() should be 3. Don't return PLUGIN_HANDLED in forwards that can't be blocked. Use 'break' to exit loops. You should evaluate whether the first element of an array is false rather using equal() to determine if a string is empty.

Got all of that and will edit ;)

You need to check that str_to_num() doesn't return 0. award_fb_amount is superfluous. There are many places where you should cache native return values.

Didn't get these ones
Need more explaination plz

You overwrite a cvar pointer (award_nades) with a value rather than updating the cvar itself.

But it's giving the same effect
But also, how should I fix that?

[ConnorMcLeod]

The cvar pointer have to stay with the same value during all map.
Only the cvar VALUE have to change with set_pcvar_num(POINTER, VALUE), where VALUE is your str_to_num thing ;)

@Lee
I don't use modules.ini except for modules that can't autoload.

[Sam Tsuki]

Originally Posted by connorr The cvar pointer have to stay with the same value during all map. Only the cvar VALUE have to change with set_pcvar_num(POINTER, VALUE), where VALUE is your str_to_num thing ;)

Got that!
Can you explain these plz

You need to check that str_to_num() doesn't return 0. award_fb_amount is superfluous. There are many places where you should cache native return values.

[Sam Tsuki]

v1.1
Is it alright now???

[Dores]

i think that there are four parameters to the give_nade console command including the command itself so instead of

PHP Code:

if (!cmd_access(id, level, cid, 3))
  return PLUGIN_HANDLED 


it should be

PHP Code:

if (!cmd_access(id, level, cid, 4))
  return PLUGIN_HANDLED 


just thinking... (register_concmd("1.give_nade", "give_nade", ADMIN_LEVEL_D, "2.<name> 3.<nade he,fb,sg> 4.<amount 1,2>")) am i wrong here?

another thing, again not sure, i think that

PHP Code:

 new arg[21]
 read_argv(1, arg, 20)
 if(!arg[0]) {
  console_print(id, "[AG] Usage: award_nades_toggle <0|1> 0 = off, 1 = on")
  return PLUGIN_HANDLED
 } 


will be the same as simply not putting anything in the award_nades_toggle (for example an admin types: award_nade_toggle with nothing afterwards):

PHP Code:

register_concmd("award_nades_toggle", "award_nades_toggle", ADMIN_RCON, "[AG] award_nades_toggle <0|1> 0 = off, 1 = on"); 


[Lee]

Originally Posted by dor123 i think that there are four parameters to the give_nade console command including the command itself so instead of PHP Code: if (!cmd_access(id, level, cid, 3))   return PLUGIN_HANDLED  it should be PHP Code: if (!cmd_access(id, level, cid, 4))   return PLUGIN_HANDLED

No, it shouldn't. One of those parameters is optional. The command itself should not be called a parameter.

Originally Posted by dor123 PHP Code:  new arg[21]  read_argv(1, arg, 20)  if(!arg[0]) {   console_print(id, "[AG] Usage: award_nades_toggle <0|1> 0 = off, 1 = on")   return PLUGIN_HANDLED  }  will be the same as simply not putting anything in the award_nades_toggle (for example an admin types: award_nade_toggle with nothing afterwards): PHP Code: register_concmd("award_nades_toggle", "award_nades_toggle", ADMIN_RCON, "[AG] award_nades_toggle <0|1> 0 = off, 1 = on");

I don't know what it is you're trying to say. That code detects whether the first argument is absent. It's useless since cmd_access() will have already taken care of things by then.

If I were to release this plugin (personally I think it's a pointless plugin and should have stayed in Suggestions/Requests like all of the scripts I've ever posted), I'd rewrite it from scratch. By the time it reaches a high quality, it won't be yours anymore. I'm sorry that I'm not prepared to offer anymore constructive advice, but my patience with inexperienced scripters is wearing very thin. There are a handful of people (not you Sam Tsuki) that genuinely make me angry when I read their "advice". Perhaps I should write that scripting tutorial to give me more of a right to hold people to the high standards I try to obtain myself. It's good that people are trying to learn, but learning by experimentation rather than waiting for people to correct you has to be better for everyone.

[xjose93]

Can u create a cvar to only terrorist if kill, give HE. Thx and bye.

[YeanS]

Good suggestion ;)

[Sam Tsuki]

i think that there are four parameters to the give_nade console command including the command itself so instead of PHP Code: PHP Code: if (!cmd_access(id, level, cid, 3))   return PLUGIN_HANDLED  it should be PHP Code: PHP Code: if (!cmd_access(id, level, cid, 4))   return PLUGIN_HANDLED  just thinking... (register_concmd("1.give_nade", "give_nade", ADMIN_LEVEL_D, "2.<name> 3.<nade he,fb,sg> 4.<amount 1,2>")) am i wrong here?

Looks like Lee answered that

another thing, again not sure, i think that PHP Code: PHP Code: new arg[21]  read_argv(1, arg, 20)  if(!arg[0]) {   console_print(id, "[AG] Usage: award_nades_toggle <0|1> 0 = off, 1 = on")   return PLUGIN_HANDLED  }  will be the same as simply not putting anything in the award_nades_toggle (for example an admin types: award_nade_toggle with nothing afterwards): PHP Code: register_concmd("award_nades_toggle", "award_nades_toggle", ADMIN_RCON, "[AG] award_nades_toggle <0|1> 0 = off, 1 = on");

Yea forgot about it
Will edit

Can u create a cvar to only terrorist if kill, give HE. Thx and bye.

Will do

[xjose93]

ok