[ReFlexPoison]

Class Damage Multiplier

Description:

Multiply damage dealt from specific classes.

Dependencies:

• SDKHooks

CVar's (Defaults):

PHP Code:

sm_dmgmult_enabled "1" // Enable Plugin
sm_dmgmult_admins "0" // Damage multiplier for admins only
sm_dmgmult_team "0" // Damage multiplier for specified teams 0 = Both 1 = Red 2 = Blue
sm_dmgmult_scout "1.0" // Damage multiplier for scouts
sm_dmgmult_soldier "1.0" // Damage multiplier for soldiers
sm_dmgmult_pyro "1.0" // Damage multiplier for pyros
sm_dmgmult_demoman "1.0" // Damage multiplier for demomans
sm_dmgmult_heavy "1.0" // Damage multiplier for heavies
sm_dmgmult_engineer "1.0" // Damage multiplier for engineers
sm_dmgmult_medic "1.0" // Damage multiplier for medics
sm_dmgmult_sniper "1.0" // Damage multiplier for snipers
sm_dmgmult_spy "1.0" // Damage multiplier for spies 


Overrides:

PHP Code:

"sm_dmgmult_flag" "b" // Required admin flag to benefit from damage mod if set to for admins only. 


Commands:

PHP Code:

sm_dmgmult_reset // Reset all values of Class Damage Modifier to normal. 


Version Log:

Spoiler

Version 1.2.0
> Fixed version CVar
> No longer changes self damage
> Rewrote and renamed

Version 1.1.0
> Add reset server command
> Add team only cvar

Version 1.0.0
> Initial Release

See my other plugins
Total Downloads: 118

[ReFlexPoison]

~Reserved

[Leonardo]

Y U NO say that it requires sdkhooks?

[ReFlexPoison]

Originally Posted by Leonardo Y U NO say that it requires sdkhooks?

I did though.

Requires SDKHooks

[Tylerst]

Spoiler

Nice plugin, but a couple of things I wanted to point out which aren't critical, but just bother me a bit

You may want to add a loop in PluginStart to hook all players to account for late loading.

That one is something you'll probably want to do. The rest of these are basically just suggestions of what I'd do.

Ok first off...lolwut?

PHP Code:

//...
new Handle:Version;
//...
public OnPluginStart() 
{
//...
    HookConVarChange(Version, CVarChange);
}

public CVarChange(Handle:convar, const String:oldValue[], const String:newValue[])
{
    if(convar == Version)
    {
        SetConVarString(Version, PLUGIN_VERSION);
    }
} 


Anyway...

You should move the enabled check to before the attacker validity check.

Then, If you're doing this for each class:

PHP Code:

CheckCommandAccess(attacker, "dmgmod_flag", ADMFLAG_GENERIC, false) 


Why not check it once then return?

In fact, because of short-circuiting, you could move all of those to the same check:

PHP Code:

if(!GetConVarBool(cvarEnabled) || !IsValidClient(attacker) || (GetConVarBool(cvarAdminOnly) && !CheckCommandAccess(attacker, "dmgmod_flag", ADMFLAG_GENERIC, false)))
{
    return Plugin_Continue;
} 


Also, why check if the damage <= 1.0? What if people want to lower damage with this with 0.5(half damage)?
I'd personally remove that altogether and have it just multiply the damage. Your cvars already limit it to a min of 0.0, so no need to check < 0.0 either. As for disabling, 1.0 is already 'disabled' really since it won't change the damage at all, and having it just multiply the damage by 1 seems faster than specifically checking for it just to return as normal.

Next point, I'd suggest checking and storing the attacker's class at the start rather than having to do it for each class.

Further, You could change the class checks into a switch for faster computing.

Actually, if you change the cvars a bit...

You know what? I'm rambling on a bit, let me just show an example, eh?

PHP Code:

new Handle:cvarEnabled;
new Handle:cvarAdminOnly;
new Handle:cvarClass[10];

public OnPluginStart() 
{
    CreateConVar("sm_dmgmod_version", PLUGIN_VERSION, "Class Damage Modifier Version.", FCVAR_REPLICATED | FCVAR_PLUGIN | FCVAR_SPONLY | FCVAR_DONTRECORD);

    cvarEnabled = CreateConVar("sm_dmgmod_enabled", "1", "Enable Class Damage Modifier.\n0 = Disabled\n1 = Enabled", FCVAR_NONE, true, 0.0, true, 1.0);
    cvarAdminOnly = CreateConVar("sm_dmgmod_admins", "0", "Damage Increase for Admins Only.\n0 = Disabled\n1 = Enabled", FCVAR_NONE, true, 0.0, true, 1.0);
    cvarClass[1] = CreateConVar("sm_dmgmod_scout", "1.0", "Damage Increase for Scouts. (By Percentage)", FCVAR_NONE, true, 0.0, true, 10.0);
    cvarClass[3] = CreateConVar("sm_dmgmod_soldier", "1.0", "Damage Increase for Soldiers. (By Percentage)", FCVAR_NONE, true, 0.0, true, 10.0);
    cvarClass[7] = CreateConVar("sm_dmgmod_pyro", "1.0", "Damage Increase for Pyros. (By Percentage)", FCVAR_NONE, true, 0.0, true, 10.0);
    cvarClass[4] = CreateConVar("sm_dmgmod_demoman", "1.0", "Damage Increase for Demomans. (By Percentage)", FCVAR_NONE, true, 0.0, true, 10.0);
    cvarClass[6] = CreateConVar("sm_dmgmod_heavy", "1.0", "Damage Increase for Heavy. (By Percentage)", FCVAR_NONE, true, 0.0, true, 10.0);
    cvarClass[9] = CreateConVar("sm_dmgmod_engineer", "1.0", "Damage Increase for Engineers. (By Percentage)", FCVAR_NONE, true, 0.0, true, 10.0);
    cvarClass[5] = CreateConVar("sm_dmgmod_medic", "1.0", "Damage Increase for Medics. (By Percentage)", FCVAR_NONE, true, 0.0, true, 10.0);
    cvarClass[2] = CreateConVar("sm_dmgmod_sniper", "1.0", "Damage Increase for Snipers. (By Percentage)", FCVAR_NONE, true, 0.0, true, 10.0);
    cvarClass[8] = CreateConVar("sm_dmgmod_spy", "1.0", "Damage Increase for Spys. (By Percentage)", FCVAR_NONE, true, 0.0, true, 10.0);
    //Late loading
    for(new i = 1; i <= MaxClients; i++)
    {
        SDKHook(i, SDKHook_OnTakeDamage, OnTakeDamage);
    }
}

public OnClientPutInServer(client) 
{
    SDKHook(client, SDKHook_OnTakeDamage, OnTakeDamage);
}

public Action:OnTakeDamage(victim, &attacker, &inflictor, &Float:damage, &damagetype) 
{
    if(!GetConVarBool(cvarEnabled) || !IsValidClient(attacker) || (GetConVarBool(cvarAdminOnly) && !CheckCommandAccess(attacker, "dmgmod_flag", ADMFLAG_GENERIC, false)))
    {
        return Plugin_Continue;
    }

    new Float:dmgmult = GetConVarFloat(cvarClass[TF2_GetPlayerClass(attacker)]);
    damage *= dmgmult;
    return Plugin_Changed;
} 


Edit: Hiding this long post.

[ReFlexPoison]

Do like the suggestions, and I'll probably do that in the next update if the plugin is even worth it. I just threw this together in a few minutes and posted it in the thought of soldiers being under-powered in vsh and ff2.

And btw, the version cvar is so you can't change it, simple as that.

[ReFlexPoison]

Version 1.1.0 Released

Changes:
* Now supports negating damage.
* Add reset server command.
* Add team only cvar.
* Deleted unnecessary code.

[SyluxLockjaw100]

Nice plugin,now I can have fun with bots with this plugin. Could you also disable damage modifier to self? This plugins makes rocket jumping lose too much HP...

[ReFlexPoison]

Version 1.2.0 Released

Changes:
> Fixed version CVar
> No longer changes self damage
> Rewrote and renamed

[Tylerst]

I went back and spoiler'd my first post since it was rather long and isn't relevant anymore.