[Chrisber]

Hi.
I'm currently trying to hook ConVar::SetValue.
All worked well, but RETURN_META_NEWPARAMS causes 82 errors: http://nopaste.org/p/aw6ORRr8C

Here's my declaration:

SH_DECL_HOOK1_void(ConVar, SetValue, SH_NOATTRIB, 0, int);
SH_DECL_HOOK1_void(ConVar, SetValue, SH_NOATTRIB, 1, float);
SH_DECL_HOOK1_void(ConVar, SetValue, SH_NOATTRIB, 2, const char*);

Here's the code to register the hook:

SH_ADD_HOOK_MEMFUNC(ConVar, SetValue, pConVar, &gConVar, &cConVar::SetValue, false);

And here's the hook function:

void cConVar::SetValue(int value)
{
    ConVar *pConVar = META_IFACEPTR(ConVar);

    if (!strcmp(pConVar->GetName(), "mp_timelimit"))
        RETURN_META_NEWPARAMS(MRES_IGNORED, &ConVar::SetValue, 0);
    
    RETURN_META(MRES_IGNORED);
}

I think it's caused by the 3 overloads that this function has.
But I can't understand why that code causes 82 errors :/
I hope someone can help me

Greetz.

[BAILOPAN]

RETURN_META_NEWPARAMS(MRES_IGNORED, &ConVar::SetValue, 0);

Should look like:

RETURN_META_NEWPARAMS(MRES_IGNORED, &ConVar::SetValue, (0));

[Chrisber]

Hi.
Causes the same errors.

Greetz.

[PM]

Hello,

1) BAIL is right, don't forget the ()

2) SourceHook can't deduce which one of the overloaded functions you want. I suppose a static_cast would work, but the clean way to slove this would probably be a temporary member function pointer variable:

void (ConVar::*  mfp) (int) = &ConVar::SetValue;
RETURN_META_NEWPARAMS(MRES_IGNORED, mfp, (0));

I suppose I could add a way to ask for the overload number in SH_DECL_HOOK ( 0 here ) but that would be only more confusing.

BTW: It gives you 82 errors because it lists every deduction function that doesn't fit twice, there are two deduction functions per parameter count and the allowed parameter counts are 0, 1, 2, ... 20. This gives us 2 * 2 * 21 = 84, but the exception is param count 1, where it finds a fitting deduction function but can't deduce the ambigous parameter type, which leads to only one error or something.

Hope this works,
PM


EDIT: or maybe some kind of template thing:

template <class TYPE>
inline static TYPE MFP_Chooser(TYPE a)
{
   return a;
}

RETURN_META_NEWPARAMS(MRES_IGNORED, MFP_Chooser< void (ConVar::*)(int) > (&ConVar::SetValue) , (0));

[Chrisber]

Hi.
Wow - that works perfectly now - big thx to you!!!

~ Chris