Raised This Month: $51 Target: $400
 12% 

Plugin Approval Rules Discussion


Post New Thread Reply   
 
Thread Tools Display Modes
dirka_dirka
Veteran Member
Join Date: Nov 2009
Old 01-15-2010 , 01:41   Re: Plugin Approval Rules Discussion
Reply With Quote #11

#1 is a good suggestion.. but it should also apply to all plugins for all mods. if a tf2 plugin wont work on css, it shouldnt load.

#2 is basically the same as #1.

#3 doesn't really matter unless its forced for all plugins, existing or new.. and thats just too much.

#4 and #5 go together, and as others have mentioned.. different plugins that mess with the same cvars are going to cause headaches. they are basically not compatible and the requirements dont matter.

#6 is a good one.. and a prime example is the scavenge remix plugin. it basically breaks my server when i try to edit. i run the game mode config plugin mentioned above - any plugin that changes game mode causes it to trigger.
dirka_dirka is offline
Downtown1
Veteran Member
Join Date: Mar 2004
Old 01-16-2010 , 15:50   Re: Plugin Approval Rules Discussion
Reply With Quote #12

OK so #1 is necessary so plugins for L4D don't load on L4D2 and vice versa (to reiterate there isn't a way to specify game is for L4D2 in the drop-down0.

#3 was made because people wouldn't prefix their plugins with anything, if we can agree on just having a prefix with an _ and so all the CVARs are prefixed the same in a plugin that would work.

#5 I don't think there is a more elegant fix without a lot more code. But it's a real problem nevertheless because plugins go against what's specified in the configs.

---------

At the end of the day I strongly support #1, #2, and #6 since those are pretty clear cut.

Last edited by Downtown1; 01-16-2010 at 15:55.
Downtown1 is offline
berni
SourceMod Plugin Approver
Join Date: May 2007
Location: Austria
Old 01-16-2010 , 21:28   Re: Plugin Approval Rules Discussion
Reply With Quote #13

Actually #2 is the only one that makes a little bit sense to me.

Quote:
Originally Posted by Downtown1 View Post
  • Your plugin should not load outside of L4D/L4D2 if it doesn't support other mods. Snippet
So Valve releases Left 4 Dead 3, now there are some plugins that might still work on L4D3, but people can't use them because there is a stupid hardcoded check.
Or some plugins might work on other mods too.
Sourcemod is meant to be a game independent platform.
__________________
Why reinvent the wheel ? Download smlib with over 350 useful functions.

When people ask me "Plz" just because it's shorter than "Please" I feel perfectly justified to answer "No" because it's shorter than "Yes"
powered by Core i7 3770k | 32GB DDR3 1886Mhz | 2x Vertex4 SSD Raid0
berni is offline
Downtown1
Veteran Member
Join Date: Mar 2004
Old 01-16-2010 , 21:51   Re: Plugin Approval Rules Discussion
Reply With Quote #14

Have you ever written any L4D plugins? because most of them don't work on L4D2 without a port.
Downtown1 is offline
Jamster
Veteran Member
Join Date: Jun 2008
Old 01-16-2010 , 23:00   Re: Plugin Approval Rules Discussion
Reply With Quote #15

I think the gamecheck is a good idea for a "just in case" scenario BUT I don't think it should be a forced rule and shouldn't JUST apply to L4D. I think thread titles are enough, that or a forum option to select L4D1/2, L4D1 or L4D2.

The cvar prefix thing does my nut in and I agree with pred on that front.

Everything else I don't really have an opinion on due to not really developing any L4D plugins.
Jamster is offline
berni
SourceMod Plugin Approver
Join Date: May 2007
Location: Austria
Old 01-17-2010 , 07:02   Re: Plugin Approval Rules Discussion
Reply With Quote #16

Quote:
Originally Posted by Downtown1 View Post
Have you ever written any L4D plugins? because most of them don't work on L4D2 without a port.
There you go, "most" is not "all", therefore it shouldn't be a rule.
I'm also a L4D/L4D2 player, but I hardly ever write game specific plugins.
__________________
Why reinvent the wheel ? Download smlib with over 350 useful functions.

When people ask me "Plz" just because it's shorter than "Please" I feel perfectly justified to answer "No" because it's shorter than "Yes"
powered by Core i7 3770k | 32GB DDR3 1886Mhz | 2x Vertex4 SSD Raid0
berni is offline
titan_rw
Member
Join Date: Sep 2009
Old 01-17-2010 , 20:42   Re: Plugin Approval Rules Discussion
Reply With Quote #17

Quote:
Originally Posted by Downtown1 View Post
Have you ever written any L4D plugins? because most of them don't work on L4D2 without a port.
5 out of 10 of plugins I run in L4D2 were compatible with 2 without any changes to the plugin.
titan_rw is offline
Downtown1
Veteran Member
Join Date: Mar 2004
Old 01-17-2010 , 21:01   Re: Plugin Approval Rules Discussion
Reply With Quote #18

So I don't understand what's the problem here, if the plugin author thinks his plugin is good enough to support future sequels, there's no reason why he can't do StrContains("left4dead") != -1, I never said anything about only supporting L4D1 or L4D2.

The point is it shouldn't load in CS or TF2 if it's meant for L4D.
Downtown1 is offline
psychonic

BAFFLED
Join Date: May 2008
Old 01-17-2010 , 21:10   Re: Plugin Approval Rules Discussion
Reply With Quote #19

Quote:
Originally Posted by Downtown1 View Post
The point is it shouldn't load in CS or TF2 if it's meant for L4D.
But why would anyone try to load it and/or complain it didn't work on other games if it was already clearly labeled to be for only L4D and/or L4D2?

You're trying to fight a user reading comprehension issue by requiring extra code.
psychonic is offline
Antithasys
Moderator
Join Date: Apr 2008
Old 01-17-2010 , 21:13   Re: Plugin Approval Rules Discussion
Reply With Quote #20

I would argue the reverse. If the plugin is marked "any" and clearly won't work on a specific mod, maybe then?

I can't really see any other use.
__________________
[my plugins]

When you think about asking a question... consider what have you tried?
Antithasys is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 19:43.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode