[dark_style]

SQL Log Admin Connect
Authors: Dark_Style & Kostov
Version: 1.4

Description:

The plugin logs the admin connection into SQL. Server, date/time, and his name will be logged. The archive includes .php file.



Web Part:

If you want the information to be showed into your web site, you will need to include the .php file.

PHP Code:


include "./directory/sql_log_admin.php"; 


Modules:

PHP Code:

#include <sqlx> 


Cvars:

lac_host "" - host
lac_user "" - user
lac_pass "" - password
lac_db "" - database
lac_table "" - table
lac_prefix "" - Prefix for the messages.
lac_log_info 1/2 - What info to be logged. 1 - name; 2 - name and steamid.
( The SQL settings )

Changelog:

1.4 - Added new cvar for the logging information. Check out the cvars.
1.3 - Added new cvar for the prefix of messages.
1.2 :

- The plugin is fully rewritten.
- Added cvars about the SQL settings, suggested by @Arkshine.
- All admins will be logged into the SQL.
- All messages are changed to server_print.
- Added prefix for the messages.

1.1 - Fix code.
1.0 - Code changes again, and again thanks to @Nextra.
0.2 - Code changes. Thanks to @Nextra.
0.1 - First release.

[Nextra]

Don't upload .amxx files anywhere. You are not allowed to do that.

Design Suggestions:
- I'd recommend to also store the admin's SteamId. Without that information any other information is basically useless.

Code suggestions:
- Some code in your SQL Handler looks like debug code. At least the output does not make sense otherwise. Either put appropriate functionality there or remove the debug code (on a side node, the format in server_print is not valid).
- Printing the PLUGIN name in every message is a bad idea. You should only print a plugin tag or a shorthand of the plugin name. Printing 26 chars in front of a log message just doesn't look good.
- For things like your mysql_init AMXX features the plugin_cfg forward. You should probably use that.
- Use formatex where applicable.
- Check for the admin flag first. Right now you are initializing a bunch of arrays and getting data which will go unused most of the time.
- Why do you make the database have varchar(100) fields when the name can only be 32 chars long on insert. This is not necessary.
- You have to escape the username and hostname if you don't want to run into trouble.
- At least one of your date and time arrays is too small.
- The Error variable should be local to mysql_init. It is not needed anywhere else and it is bad style to have two variables named the same (even if it works out, given how the compiler prioritizes them).
- Instead the query variable could be global or static.
- You are mixing console_print(0, ... ) and server_print. Be consistent.

[Exolent[jNr]]

You are not allowed to post .amxx files.

[dark_style]

Originally Posted by Exolent[jNr] You are not allowed to post .amxx files.

I'm sorry. Now the archive includes only .php file.
New Version!

[Nextra]

PHP Code:

if(is_user_connected(id) & get_user_flags(id) & read_flags(AdminFlag)) 


The first '&' should be '&&'. Also continue to work on it and read through my list for further advice.

[dark_style]

Originally Posted by Nextra PHP Code: if(is_user_connected(id) & get_user_flags(id) & read_flags(AdminFlag))  The first '&' should be '&&'. Also continue to work on it and read through my list for further advice.

Changed, thanks. I read your first post and done some things, but that for varchar I can't, becouse there's prefix which has chars.

[s3rserii]

Originally Posted by dark_style SQL Log Admin Connect Authors: Dark_Style & Kostov Version: 0.2 Description: When admin join in the server he will be included in SQL. Server, date/time, and his name will be logged. You can change which flags admins can be included. The archive included .php file. Modules: PHP Code: #include <sqlx>  Source Edit: PHP Code: #define AdminFlag "abcd"  /*=== Sql Settings ====*/  #define SqlHost  "127.0.0.1"  #define SqlUser  "root"   #define SqlPass  ""  #define SqlDb    "sqlamxx"  #define SqlTable "amx_connect_admin"  Changelog: 0.2 - Code changes. Thanks to @Nextra. 0.1 - First release.

it shows that the plugin is connectetd to the database but when i join the server it not creat the tables or the informations in the database?

i use amxbans to set my admins, not the normal "users.ini"

[Nextra]

Originally Posted by dark_style Changed, thanks. I read your first post and done some things, but that for varchar I can't, becouse there's prefix which has chars.

I know you have done some things but barely half of it. That's why I said you should continue to work on it. Especially on some crucial things like string escaping which can make your plugin fail totally (for example if the hostname has unescaped characters your plugin will not work at all).

And you can change the varchar size. You have

PHP Code:

HostName[64], AdminName[32] 


but reserve 100 for both.

[dark_style]

Originally Posted by Nextra I know you have done some things but barely half of it. That's why I said you should continue to work on it. Especially on some crucial things like string escaping which can make your plugin fail totally (for example if the hostname has unescaped characters your plugin will not work at all). And you can change the varchar size. You have PHP Code: HostName[64], AdminName[32]  but reserve 100 for both.

Thanks for your support! Working on new version. When it's done, I'll upload it. Happy New Year! Have fun on the holiday!

[s3rserii]

Originally Posted by s3rserii it shows that the plugin is connectetd to the database but when i join the server it not creat the tables or the informations in the database? i use amxbans to set my admins, not the normal "users.ini"

for now its not work or what?