[kot4404]

Hello, how could I make the strcmp check more efficient? I have

public Action:Command_check(client, args)
{
	if(!strcmp(sCheck, "easy"))
	{
		PrintToChat(client, sCheck);
	}
	else if(!strcmp(sCheck, "normal"))
	{
		PrintToChat(client, sCheck);

	}
	else if(!strcmp(sCheck, "hard"))
	{
		PrintToChat(client, sCheck);
	}
	//do the things
}

Can I avoid making that many strcmp checks so Only one if check of easy & normal & hard is here?

Also how can I do it so it won't execute the //do the things unless it passed the strcmp check?
I tried to add the Plugin_Handled thing but it still executed rest of the functions

[hmmmmm]

PHP Code:

if( StrEqual( sCheck, "easy", false ) || StrEqual( sCheck, "normal" ) || StrEqual( sCheck, "hard" ) )
{
    PrintToChat( client, sCheck );
    // do the things
} 


Bit unclear what you're trying to do, but I think this is what you want.

[backwards]

if it's a controlled string for instance from a menu string return value you can use single char compares that are unique identifiers like this:

PHP Code:

public Action:Command_check(client, args)
{
    if(sCheck[0] == 'e' || sCheck[0] == 'n' || sCheck[0] == 'h')
    {
        PrintToChat( client, sCheck );
    }
    
    return Plugin_Handled;
    //do the things
} 


when you return the code underneath within the same scope will not execute.

[kot4404]

if( StrEqual( sCheck, "easy", false ) || StrEqual( sCheck, "normal" ) || StrEqual( sCheck, "hard" ) )
{
    PrintToChat( client, sCheck );
    // do the things
}

Thanks, that's what I wanted
But now I tried to add opposite check so if there are 0 args or string isn't equal to easy normal hard it should display the error message

	if (args < 1 || !StrEqual( sDifficulty, "easy", false ) || !StrEqual( sDifficulty, "normal", false ) || !StrEqual( sDifficulty, "hard", false ))
	{
		ReplyToCommand(client, "Usage: !votedifficulty <difficulty> (easy;normal;hard)");
		return Plugin_Handled;
	}

But I can't pass the check even if I give the good string, any idea why?

[hmmmmm]

Step through it with some example input. Say you pass in 1 argument which is "easy". Args is 1, so first check is false. sDifficulty is "easy" so second check is false. sDifficulty is not normal, so third check returns true, and it enters the code block.

What you want is this instead:

PHP Code:

if (args < 1 || !(StrEqual( sDifficulty, "easy", false ) || StrEqual( sDifficulty, "normal" ) || StrEqual( sDifficulty, "hard" ))) 


This way if input is NOT "easy", "normal" or "hard" it returns false and enters like you want it to

[kot4404]

Originally Posted by hmmmmm Step through it with some example input. Say you pass in 1 argument which is "easy". Args is 1, so first check is false. sDifficulty is "easy" so second check is false. sDifficulty is not normal, so third check returns true, and it enters the code block. What you want is this instead: PHP Code: if (args < 1 || !(StrEqual( sDifficulty, "easy", false ) || StrEqual( sDifficulty, "normal" ) || StrEqual( sDifficulty, "hard" )))  This way if input is NOT "easy", "normal" or "hard" it returns false and enters like you want it to

Thanks now I got it

[Benoist3012]

Originally Posted by kot4404 if( StrEqual( sCheck, "easy", false ) || StrEqual( sCheck, "normal" ) || StrEqual( sCheck, "hard" ) ) { PrintToChat( client, sCheck ); // do the things } Thanks, that's what I wanted

You realize that StrEqual is just a disguised strcmp?

stock bool StrEqual(const char[] str1, const char[] str2, bool caseSensitive=true)
{
    return (strcmp(str1, str2, caseSensitive) == 0);
}

Your code is just:

if( strcmp( sCheck, "easy", false ) == 0 || strcmp( sCheck, "normal" ) == 0 || strcmp( sCheck, "hard" ) == 0 )