[SkumTomteN]

0.6 Released.

Version 0.6:
*Improved the way the camera is removed.
*Fixed a bug when the player disconnected. it would say "invalid player".

[Jhob94]

Well i have some advices, they are not really necessary, but it makes the code looks more nice.

You have some cases like this

PHP Code:

if(is_user_alive(iVictim))
        return HAM_IGNORED;
    if(!is_user_connected(iVictim))
        return HAM_IGNORED; 


PHP Code:

if(!is_user_connected(iVictim) || is_user_alive(iVictim))
        return HAM_IGNORED; 


or

PHP Code:

if(is_user_connected(iVictim) && !is_user_alive(iVictim))
{
    //Your code
} 


Also, you could change this

PHP Code:

public CMD_ToggleCam(iPlayer)
{
    if(get_pcvar_num(g_pCvar_iCameraForced))
    {
        client_printc(iPlayer, "!g[%s]!n Camera is forced on !t3rd person!n by server manager!", PLUGIN_TAG)
        return;
    }
    if(is_user_alive(iPlayer))
    {
        if(!g_bInThirdPerson[iPlayer])
        {
            Set_CameraEnt(iPlayer)
            
            g_bInThirdPerson[iPlayer] = true;

            client_print(0, print_center, "3rd Person Mode")
        }
        else 
        {
            Remove_CameraEnt(iPlayer, 1)
    
            g_bInThirdPerson[iPlayer] = false;
            
            client_print(0, print_center, "1st Person Mode")
        }
    }
    else /* He toggles when not alive */
    {
        if(!g_bInThirdPerson[iPlayer])
        {
            g_bInThirdPerson[iPlayer] = true;
        }
        else g_bInThirdPerson[iPlayer] = false;
        
        client_printc(iPlayer, "!g[%s]!n Your camera will be !t%s!n when you spawn!", PLUGIN_TAG, g_bInThirdPerson[iPlayer] ? "3rd Person" : "1st Person")
    }
} 


PHP Code:

public CMD_ToggleCam(iPlayer)
{
    if(get_pcvar_num(g_pCvar_iCameraForced))
    {
        client_printc(iPlayer, "!g[%s]!n Camera is forced on !t3rd person!n by server manager!", PLUGIN_TAG)
        return;
    }
    
    g_bInThirdPerson[iPlayer] = ~g_bInThirdPerson[iPlayer]
    
    if(is_user_alive(iPlayer))
    {
        if(g_bInThirdPerson[iPlayer])
        {
            Set_CameraEnt(iPlayer)

            client_print(0, print_center, "3rd Person Mode")
        }
        else 
        {
            Remove_CameraEnt(iPlayer, 1)
            
            client_print(0, print_center, "1st Person Mode")
        }
    }
    else /* He toggles when not alive */
    {
        client_printc(iPlayer, "!g[%s]!n Your camera will be !t%s!n when you spawn!", PLUGIN_TAG, g_bInThirdPerson[iPlayer] ? "3rd Person" : "1st Person")
    }
} 


And last:

PHP Code:

public fw_PlayerSpawn_Post(iPlayer)
{
    if(!is_user_alive(iPlayer))
        return HAM_IGNORED;
    if(!is_user_connected(iPlayer))
        return HAM_IGNORED;
    
    if(get_pcvar_num(g_pCvar_iCameraForced))
    {
        Set_CameraEnt(iPlayer)
    }
    else
    {
        if(g_bInThirdPerson[iPlayer])
            Set_CameraEnt(iPlayer)
        else 
            Remove_CameraEnt(iPlayer, 1)
    }
    return HAM_HANDLED;
} 


PHP Code:

public fw_PlayerSpawn_Post(iPlayer)
{
    if(is_user_alive(iPlayer))
    {
        if(get_pcvar_num(g_pCvar_iCameraForced) || g_bInThirdPerson[iPlayer])
        {
            Set_CameraEnt(iPlayer)
        }
        else
        {
            Remove_CameraEnt(iPlayer, 1)
        }
    }
} 


They are not really necessary, but it's always good to improve it.

[SkumTomteN]

Its been implemented in the code now, you were always so good in coding style, im jealous.
But i prefer to use "return" when im not using an if > else, just a preference.

Thank you for the suggestions and improvement. ill add you to credits

[GuskiS]

Originally Posted by Jhob94 PHP Code: ...         if(get_pcvar_num(g_pCvar_iCameraForced) || g_bInThirdPerson[iPlayer]) ...

PHP Code:

if(g_bInThirdPerson[iPlayer] || get_pcvar_num(g_pCvar_iCameraForced)) 


[Jhob94]

Originally Posted by GuskiS PHP Code: if(g_bInThirdPerson[iPlayer] || get_pcvar_num(g_pCvar_iCameraForced))

Doesn't matter. If cvar is enabled, would be better the other case. It's 50/50, so i am not sure why you posted that.

[GuskiS]

It does matter. I posted that because it is wiser to check on array than on native first because if array will return true, it won't check the other expression to be true. This can be really usefull in functions/events that are being called very often

[Jhob94]

Originally Posted by GuskiS This can be really usefull in functions/events that are being called very often

Yes, i know. But here isn't really the case.

[Visinescu]

I don't see this plugin to be approved... make more camera views like the shoulder view, and fix that wallhack plis.

[SkumTomteN]

More camera angles!: The purpose of the plugin is a simple cam. but as always, if anyone wants to make more angles, post your code here.
Fix wallhack: I don't have time to fix that issue, it would take a very long time and testing. but if anyone wants to support this plugin by giving a suggestion code for this, feel free

[Craxor]

Originally Posted by SkumTomteN If you want to see in detail what is different, i suggest you compare it yourself.

Wrong, if it's your plugin you have the responsability to say the differences between the others similar versions, anyway it's kind of useless. Same can be achieved very easy with engine.