[Rcki]

So, I have this small problem with my % lifesteal code:
I want it to heal 10% of damage done, with a maximum overheal of 250 hp. The code works if I want to heal a flat amount (for example 10 health per hit), but for some reason it heals me instantly to max overheal if I try to heal a certain % of damage dealt.
Am I just stupid or what is wrong with this?

public OnClientPutInServer(client) {
	SDKHook(client, SDKHook_OnTakeDamage, OnTakeDamage);
}

public Action:OnTakeDamage(client, &attacker, &inflictor, &Float:damage, &damagetype, &weapon, Float:damageForce[3], Float:damagePosition[3], damagecustom){
	new heal = damage * 0.1;
	AddPlayerHealth(attacker, heal, 250, true);
	return Plugin_Continue;
}

stock AddPlayerHealth(iClient, iAdd, iOverheal = 0, bStaticMax = false)
{
	new iHealth = GetClientHealth(iClient);
	new iNewHealth = iHealth + iAdd;
	new iMax = bStaticMax ? iOverheal : GetEntProp(iClient, Prop_Data, "m_iMaxHealth") + iOverheal;
	if (iHealth < iMax)
	{
		iNewHealth = min(iNewHealth, iMax);
		SetEntityHealth(iClient, iNewHealth);
	}
}

(This is not the full plugin, I have taken away the parts that do not affect this certain behaviour)
Sorry for being a noob and thanks in advance !

[mug1wara]

First thing I noticed out of place "new heal = damage * 0.1;" Should be Float.

[Rcki]

You mean like: new Float:heal? Tried it out, didn't make a difference. I also tried directly healing the damage dealt, which also resulted in the same problem. Like this:

public Action:OnTakeDamage(client, &attacker, &inflictor, &Float:damage, &damagetype, &weapon, Float:damageForce[3], Float:damagePosition[3], damagecustom){
	//new Float:heal = damage * 0.1;
	AddPlayerHealth(attacker, damage, 250, true);
	return Plugin_Continue;
}

(I dealt 65 damage, which means I should be getting healed for 65 health, instead I got instantly healed up to 250 health.)
Any ideas?

[ddhoward]

The damage parameter in OnTakeDamage() is a Float.

also, eww old syntax

[thecount]

The issue is obviously coming from the stock function. Since you pass it the correct values, it must be interpreting it incorrectly. GetClientHealth() undoubtedly works and your logic for setting a maximum health seems correct. iNewHealth must initially be an unexpected value which I can only assume to be the fault of iAdd. It is probably being interpreted incorrectly. (Maybe the data passed is being read as an integer rather than a float and changing the numerical value) Try changing to this:

stock AddPlayerHealth(iClient, Float:iAdd, Float:iOverheal = 0.0, bStaticMax = false)
{
	new Float:iHealth = float(GetClientHealth(iClient));
	new Float:iNewHealth = iHealth + iAdd;
	new Float:iMax = bStaticMax ? iOverheal : GetEntProp(iClient, Prop_Data, "m_iMaxHealth") + iOverheal;
	if (iHealth < iMax)
	{
		iNewHealth = min(iNewHealth, iMax);
		SetEntityHealth(iClient, iNewHealth);
	}
}

[Rcki]

Originally Posted by ddhoward The damage parameter in OnTakeDamage() is a Float. also, eww old syntax

The syntax might be old because I started this plugin back in 2013 or something. I had a long break from sourcepawn coding since then.

Originally Posted by thecount The issue is obviously coming from the stock function. Since you pass it the correct values, it must be interpreting it incorrectly. GetClientHealth() undoubtedly works and your logic for setting a maximum health seems correct. iNewHealth must initially be an unexpected value which I can only assume to be the fault of iAdd. It is probably being interpreted incorrectly. (Maybe the data passed is being read as an integer rather than a float and changing the numerical value) Try changing to this: stock AddPlayerHealth(iClient, Float:iAdd, Float:iOverheal = 0.0, bStaticMax = false) { new Float:iHealth = float(GetClientHealth(iClient)); new Float:iNewHealth = iHealth + iAdd; new Float:iMax = bStaticMax ? iOverheal : GetEntProp(iClient, Prop_Data, "m_iMaxHealth") + iOverheal; if (iHealth < iMax) { iNewHealth = min(iNewHealth, iMax); SetEntityHealth(iClient, iNewHealth); } }

Well, I tried and now the function doesn't heal at all (Not even with a flat value, or a flat float). Hmmm, it doesn't seem to work with Floats at all. This is getting really problematic.