[BaD CopY]

What is more optimized way, for making vars for player data, then this

PHP Code:

new    Golds[33], 
    Rank[33], 
    XP[33],
    Kills[33],
    Deaths[33]; 


I'm saving all data to sql database in real time like this

PHP Code:

public onDeathMsg()
{
    new iKiller = read_data(1);
    new iVictim = read_data(2);
    new Headshot = read_data(3);
    
    if(task_exists(iVictim + mainHudID))
    {
        remove_task(iVictim + mainHudID);
    }
    
    new button = pev(iKiller, pev_button)
    new Wpn = get_user_weapon(iKiller)
    
    if( iKiller != iVictim && ( 1 <= iKiller <= MAXPLAYERS ) && ( 1 <= iVictim <= MAXPLAYERS ) && !is_user_bot(iKiller))
    {
        XP[iKiller] ++
        Golds[iKiller] ++
        Kills[iKiller] ++
        Deaths[iVictim] ++
        
        SQL_SaveData(iKiller)
        SQL_SaveData(iVictim)
    }
}

stock SQL_SaveData(id)
{
    new nick[33];
    get_user_name(id, nick, charsmax(nick));
    
    new Handle: SQL_Connection = SQL_Connect(SQL_GlobalConnection, ErrorCode, g_Error, charsmax(g_Error));
    
    new Handle: SQL_Query;
    
    SQL_Query = SQL_PrepareQuery(SQL_Connection, "UPDATE `r` SET (`g` = '%i', `x` = '%i', `k` = '%i', `d` = '%i') WHERE (`r`.`n` = '%s')", Golds[id], XP[id], Kills[id], Deaths[id], nick);
    SQL_Execute(SQL_Query);
    
    SQL_FreeHandle(SQL_Query);
    SQL_FreeHandle(SQL_Connection);
} 


[HamletEagle]

It is perfectly fine.

[Bugsy]

You do not need quotes around numerical values in your SQL statement.

`g` = '%i' -> `g` = %i

Should be fine with this:

UPDATE r SET (g = %i, x = %i, k = %i, d = %i) WHERE ( r.n = '%s' )

[OciXCrom]

PHP Code:

enum _:PlayerData
{
    Golds,
    Rank,
    XP,
    Kills,
    Deaths
}

new g_ePlayerData[33][PlayerData] 


I don't know if it's more optimized or not, but it's easier to use.

[Bugsy]

Agree with oxixcrom, use enum sized arrays instead of individual arrays if the data is associated with the same object, in this case a player. Much more organized.

[BaD CopY]

Okay, what about sql saving ? What is best time to call sql save function (ex. onDeath, onSpawn, client_diconnect, plugin_end, ... ?)

EDIT:
What about Queries, SQL_PrepareQuery or SQL_ThreadQuery ? Now every time when I call sql function, plugin call database. How to reduce database calling ?

[klippy]

If it's a threaded query then it doesn't matter.

[OciXCrom]

Save it when a client disconnects, load it on connect.