Raised This Month: $32 Target: $400
 8% 

Knife-Skins v2.2.


Post New Thread Reply   
 
Thread Tools Display Modes
ShLuMieL
Senior Member
Join Date: Jul 2010
Old 12-10-2013 , 16:37   Re: Knife Levels v1.0.
Reply With Quote #11

Quote:
Originally Posted by Kia View Post
PHP Code:
if ( is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage 8)
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 10 )
    {
        
SetHamParamFloat(4damage 10 )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 11 )
    {
        
SetHamParamFloat(4damage 11 )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 12 )
    {
        
SetHamParamFloat(4damage 12 )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 13 )
    {
        
SetHamParamFloat(4damage 13 )
    } 
This be can made better, and you know that.

PHP Code:
if(iLevel[id]==0)
    {
        new 
menu menu_createszItem"Knife_Handler" );
        
menu_additem(menu"\wNormal Knife [\yUNLOCKED\w]""");               // Normal Knife
        
menu_additem(menu"\d???? ????? [\rLEVEL 1 REQUIRE\d]""");     // Alien Knife
        
menu_additem(menu"\d?????? ?????? [\rLEVEL 2 REQUIRE\d]""");     // Ellium Dagger
        
menu_additem(menu"\d???? ?????? [\rLEVEL 3 REQUIRE\d]""");     // Dark Dagger
        
menu_additem(menu"\d??????????? ????? [\rLEVEL 4 REQUIRE\d]""");     // Transparent Knife
        
menu_additem(menu"\d??????? ?????? [\rLEVEL 5 REQUIRE\d]""");     // Genuine Dagger
        
menu_additem(menu"\d???? ????? [\rLEVEL 6 REQUIRE\d]""");     // Hunt Blade
        
menu_additem(menu"\d?????? ????? [\rLEVEL 7 REQUIRE\d]""");     // Shadow Blade
        
menu_additem(menu"\d??????????? ??? [\rLEVEL 8 REQUIRE\d]""");     // Slaughterer Axe
        
menu_additem(menu"\d?????? ?????? [\rLEVEL 9 REQUIRE\d]""");     // Golden Katana
        
menu_additem(menu"\d???????? ????? [\rLEVEL 10 REQUIRE\d]""");     // Assasin's Blade
        
menu_additem(menu"\d?????????? [\rLEVEL 11 REQUIRE\d]""");        // Lightsaber
        
menu_additem(menu"\d?????? ????????? ????? [\rLEVEL 12 REQUIRE\d]"""); // Bloody Wolverine Claws
        
menu_additem(menu"\d?????? ??? [\rLEVEL 13 REQUIRE\d]""");     // Proton Axe
        
        
menu_setpropmenuMPROP_EXITMEXIT_ALL );
        
menu_displayidmenu);
    } 
This one too, check for the Level and decide then what string to display, saves much code.

PHP Code:
case 0:{
            
SetKnife(id 0)
            
ColorChat(id,"The knife you chose is: ^4Normal Knife^1.");
        }
        case 
1:{
            
SetKnife(id 1)
            
ColorChat(id,"The knife you chose is: ^4Alien Knife^1.");
        }
        case 
2:{
            
SetKnife(id 2)
            
ColorChat(id,"The knife you chose is: ^4Ellium Dagger^1.");
        }
        case 
3:{
            
SetKnife(id 3)
            
ColorChat(id,"The knife you chose is: ^4Dark Dagger^1.");
        }
        case 
4:{
            
SetKnife(id 4)
            
ColorChat(id,"The knife you chose is: ^4Transparent Knife^1.");
        }
        case 
5:{
            
SetKnife(id 5)
            
ColorChat(id,"The knife you chose is: ^4Genuine Dagger^1.");
        }
        case 
6:{
            
SetKnife(id 6)
            
ColorChat(id,"The knife you chose is: ^4Hunt Blade^1.");
        }
        case 
7:{
            
SetKnife(id 7)
            
ColorChat(id,"The knife you chose is: ^4Shadow Blade^1.");
        }
        case 
8:{
            
SetKnife(id 8)
            
ColorChat(id,"The knife you chose is: ^4Slaughterer Axe^1.");
        }
        case 
9:{
            
SetKnife(id 9)
            
ColorChat(id,"The knife you chose is: ^4Golden Katana^1.");
        }
        case 
10:{
            
SetKnife(id 10)
            
ColorChat(id,"The knife you chose is: ^4Assasin's Blade^1.");
        }
        case 
11:{
            
SetKnife(id 11)
            
ColorChat(id,"The knife you chose is: ^4Lightsaber^1.");
        }
        case 
12:{
            
SetKnife(id 12)
            
ColorChat(id,"The knife you chose is: ^4Bloody Wolverine Claws^1.");
        }
        case 
13:{
            
SetKnife(id 13)
            
ColorChat(id,"The knife you chose is: ^4Proton Axe^1.");
        } 
Same for here.

You have much redundant code in your plugin, review your code and update it.
I know its a lot of necessary lines but Im ain't got any idea how to do this with less lines, if you can give me idea it will very helpfull thank's for this comment you are very help me.

and Thank's for all for telling me how to make it better your's comments are helping a lot, Im just beginer so thanks all its very helping to another stuff's really thank's.

Last edited by ShLuMieL; 12-10-2013 at 16:43.
ShLuMieL is offline
ShLuMieL
Senior Member
Join Date: Jul 2010
Old 12-10-2013 , 16:46   Re: Knife Levels v1.0.
Reply With Quote #12

Quote:
Originally Posted by PoLiCe View Post
Also Gravity+ would be cool, SuperJump/Speed Depoly if possible & Fast Stab / Slash..
And add a chat command that shows how many kills until next level .. / how many players i've killed & top15 Knifers.
Hey thank's for the idea's, Umm in the plugin there was already commands that shows how much you need to get for the next level, I edited the thread and I wrote it thanks to you, I just forgot to write it... so thanks anyway.
ShLuMieL is offline
simanovich
AlliedModders Donor
Join Date: Jun 2012
Location: Israel
Old 12-11-2013 , 02:34   Re: Knife Levels v1.0.
Reply With Quote #13

Quote:
Originally Posted by ShLuMieL View Post
I know its a lot of necessary lines but Im ain't got any idea how to do this with less lines, if you can give me idea it will very helpfull thank's for this comment you are very help me.
It means that you don't know how to script, because this code is bad coded
__________________
simanovich is offline
ShLuMieL
Senior Member
Join Date: Jul 2010
Old 12-11-2013 , 07:53   Re: Knife Levels v1.0.
Reply With Quote #14

Quote:
Originally Posted by simanovich View Post
It means that you don't know how to script, because this code is bad coded
Yeah laugh on me, I said im just in the begining of scripting, because of that I need the people comment to learn how to make it better, and if you such a good scripter show me how you would do that better.
ShLuMieL is offline
Strick3n
Member
Join Date: Apr 2013
Old 12-11-2013 , 08:16   Re: Knife Levels v1.0.
Reply With Quote #15

Quote:
Originally Posted by ShLuMieL View Post
Yeah laugh on me, I said im just in the begining of scripting, because of that I need the people comment to learn how to make it better, and if you such a good scripter show me how you would do that better.
All this shit,
Code:
public fw_TakeDamage(victim, inflictor, attacker, Float:damage)
{
	if (get_pcvar_num(knife_on) == 0)
	{
		SetHamParamFloat(4, damage)
		return PLUGIN_HANDLED;
	}
	
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 1 )
	{
		SetHamParamFloat(4, damage + 1 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 2 )
	{
		SetHamParamFloat(4, damage + 2 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 3 )
	{
		SetHamParamFloat(4, damage + 3 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 4 )
	{
		SetHamParamFloat(4, damage + 4 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 5 )
	{
		SetHamParamFloat(4, damage + 5 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 6 )
	{
		SetHamParamFloat(4, damage + 6 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 7 )
	{
		SetHamParamFloat(4, damage + 7 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 8 )
	{
		SetHamParamFloat(4, damage + 8)
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 9 )
	{
		SetHamParamFloat(4, damage + 9 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 10 )
	{
		SetHamParamFloat(4, damage + 10 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 11 )
	{
		SetHamParamFloat(4, damage + 11 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 12 )
	{
		SetHamParamFloat(4, damage + 12 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 13 )
	{
		SetHamParamFloat(4, damage + 13 )
	}
	return PLUGIN_HANDLED;
}
can be easily replaced with this,
Code:
public fw_TakeDamage(victim, inflictor, attacker, Float:damage)
{
	if( get_pcvar_num( knife_on ) == 0 )
		return HAM_IGNORED;
	
	if( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE )
	{
		SetHamParamFloat(4, damage + knife_model[ attacker ] );
		
		return HAM_HANDLED;
	}
	
	return HAM_IGNORED;
}
And now you need to optimize the menu ..
Strick3n is offline
ShLuMieL
Senior Member
Join Date: Jul 2010
Old 12-11-2013 , 08:43   Re: Knife Levels v1.0.
Reply With Quote #16

Quote:
Originally Posted by Strick3n View Post
All this shit,
Code:
public fw_TakeDamage(victim, inflictor, attacker, Float:damage)
{
	if (get_pcvar_num(knife_on) == 0)
	{
		SetHamParamFloat(4, damage)
		return PLUGIN_HANDLED;
	}
	
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 1 )
	{
		SetHamParamFloat(4, damage + 1 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 2 )
	{
		SetHamParamFloat(4, damage + 2 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 3 )
	{
		SetHamParamFloat(4, damage + 3 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 4 )
	{
		SetHamParamFloat(4, damage + 4 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 5 )
	{
		SetHamParamFloat(4, damage + 5 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 6 )
	{
		SetHamParamFloat(4, damage + 6 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 7 )
	{
		SetHamParamFloat(4, damage + 7 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 8 )
	{
		SetHamParamFloat(4, damage + 8)
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 9 )
	{
		SetHamParamFloat(4, damage + 9 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 10 )
	{
		SetHamParamFloat(4, damage + 10 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 11 )
	{
		SetHamParamFloat(4, damage + 11 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 12 )
	{
		SetHamParamFloat(4, damage + 12 )
	}
	if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 13 )
	{
		SetHamParamFloat(4, damage + 13 )
	}
	return PLUGIN_HANDLED;
}
can be easily replaced with this,
Code:
public fw_TakeDamage(victim, inflictor, attacker, Float:damage)
{
	if( get_pcvar_num( knife_on ) == 0 )
		return HAM_IGNORED;
	
	if( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE )
	{
		SetHamParamFloat(4, damage + knife_model[ attacker ] );
		
		return HAM_HANDLED;
	}
	
	return HAM_IGNORED;
}
And now you need to optimize the menu ..
But Im dont understand how with this code the plugin will know how damage to add each knife ?
ShLuMieL is offline
Strick3n
Member
Join Date: Apr 2013
Old 12-11-2013 , 08:50   Re: Knife Levels v1.0.
Reply With Quote #17

Quote:
Originally Posted by ShLuMieL View Post
But Im dont understand how with this code the plugin will know how damage to add each knife ?
The damage will increase by the number of the knife model.
Strick3n is offline
simanovich
AlliedModders Donor
Join Date: Jun 2012
Location: Israel
Old 12-11-2013 , 09:15   Re: Knife Levels v1.0.
Reply With Quote #18

Quote:
Originally Posted by ShLuMieL View Post
Yeah laugh on me, I said im just in the begining of scripting
That's why you shouldn't release plugins.
__________________

Last edited by simanovich; 12-11-2013 at 09:15.
simanovich is offline
Kia
AlliedModders Donor
Join Date: Apr 2010
Location: In a world of madness
Old 12-11-2013 , 09:27   AW: Re: Knife Levels v1.0.
Reply With Quote #19

Quote:
Originally Posted by simanovich View Post
That's why you shouldn't release plugins.
+1

If you're new, what you obviously are, then ask in Scripting Help if your code is good and release when advanced scripters tell you it's optimized.
__________________
Kia is offline
ShLuMieL
Senior Member
Join Date: Jul 2010
Old 12-11-2013 , 10:22   Re: AW: Re: Knife Levels v1.0.
Reply With Quote #20

Quote:
Originally Posted by Kia View Post
+1

If you're new, what you obviously are, then ask in Scripting Help if your code is good and release when advanced scripters tell you it's optimized.
Im agree, you are definitely right, so no body here tell me how can I fix the plugin, to make it with less line's?,
ShLuMieL is offline
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 17:58.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode