[Tank Rush]

Sorry, I forgot this post. Here you go but it is in Spanish, you can find the include files and everything you need in this GitHub repository:
https://github.com/Attano/L4D2-Competitive-Framework
https://github.com/SirPlease/L4D2-Competitive-Rework

Thank you!

• foxhound27 - for supporting this plugin
• V1SoR - for creating the original plugin

[Hawkins]

Where to put the .inc files?

[Psyk0tik]

Originally Posted by Hawkins Where to put the .inc files?

addons/sourcemod/scripting/include/<put .inc files here>

[JLmelenchon]

L 09/26/2021 - 18:55:19: [SM] Exception reported: Memory leak
L 09/26/2021 - 18:55:19: [SM] Exception reported: Error creating ThisHandle in preparation to call hook callback. (error 6)
L 09/26/2021 - 18:55:19: [SM] Blaming: left4dhooks.smx::SelectTankAttack
L 09/26/2021 - 18:55:19: [SM] MEMORY LEAK DETECTED IN PLUGIN (file "tankhud.smx")
L 09/26/2021 - 18:55:19: [SM] Unloading plugin to free 31396 handles.
L 09/26/2021 - 18:55:19: [SM] Contact the author(s) of this plugin to correct this error.
L 09/26/2021 - 18:55:19: --------------------------------------------------------------------------
L 09/26/2021 - 18:55:19: Type IMenuPanel | Count 31390
L 09/26/2021 - 18:55:19: Type GameConfigs | Count 1
L 09/26/2021 - 18:55:19: Type Timer | Count 1
L 09/26/2021 - 18:55:19: Type Trie | Count 3
L 09/26/2021 - 18:55:19: Type ValveCall | Count 1
L 09/26/2021 - 18:55:19: --------------------------------------------------------------------------
L 09/26/2021 - 18:55:19: Oldest Living Handle: Timer created at 09/24/2021 - 01:02:52
L 09/26/2021 - 18:55:19: Newest Living Handle: IMenuPanel created at 09/26/2021 - 18:55:17
L 09/26/2021 - 18:55:19: -- Approximately 882076 bytes of memory are in use by (31396) Handles.

L 09/26/2021 - 18:55:19: [SM] Exception reported: Memory leak
L 09/26/2021 - 18:55:19: [SM] Exception reported: Error creating ThisHandle in preparation to call hook callback. (error 6)
L 09/26/2021 - 18:55:19: [SM] Blaming: left4dhooks.smx::SelectTankAttackPre
L 09/26/2021 - 18:55:19: [SM] MEMORY LEAK DETECTED IN PLUGIN (file "tankhud.smx")
L 09/26/2021 - 18:55:19: [SM] Unloading plugin to free 31396 handles.
L 09/26/2021 - 18:55:19: [SM] Contact the author(s) of this plugin to correct this error.
L 09/26/2021 - 18:55:19: --------------------------------------------------------------------------
L 09/26/2021 - 18:55:19: Type IMenuPanel | Count 31390
L 09/26/2021 - 18:55:19: Type GameConfigs | Count 1
L 09/26/2021 - 18:55:19: Type Timer | Count 1
L 09/26/2021 - 18:55:19: Type Trie | Count 3
L 09/26/2021 - 18:55:19: Type ValveCall | Count 1
L 09/26/2021 - 18:55:19: --------------------------------------------------------------------------
L 09/26/2021 - 18:55:19: Oldest Living Handle: Timer created at 09/24/2021 - 01:02:52
L 09/26/2021 - 18:55:19: Newest Living Handle: IMenuPanel created at 09/26/2021 - 18:55:17
L 09/26/2021 - 18:55:19: -- Approximately 882076 bytes of memory are in use by (31396) Handles.

[Marttt]

Probably a memory weak from opening multiple Menus but not releasing the Handle (menu)

Seems that DummySpecHudHandler / DummyTankHudHandler doesn't delete the handle on action "End"

Didn't test buy maybe changing

PHP Code:

public DummySpecHudHandler(Handle:hMenu, MenuAction:action, param1, param2) {}
public DummyTankHudHandler(Handle:hMenu, MenuAction:action, param1, param2) {} 


to:

PHP Code:

public int DummySpecHudHandler(Menu menu, MenuAction action, int param1, int param2)
{
    switch (action)
    {
        case MenuAction_End:
        {
            delete menu;
        }
    }

    return 0;
}

public int DummyTankHudHandler(Menu menu, MenuAction action, int param1, int param2)
{
    switch (action)
    {
        case MenuAction_End:
        {
            delete menu;
        }
    }

    return 0;
} 


would fix it.

[JLmelenchon]

Ok nice i will try.

[JLmelenchon]

Still not.

L 10/23/2021 - 21:55:24: [SM] MEMORY LEAK DETECTED IN PLUGIN (file "tankhud.smx")
L 10/23/2021 - 21:55:24: [SM] Unloading plugin to free 31243 handles.
L 10/23/2021 - 21:55:24: [SM] Contact the author(s) of this plugin to correct this error.
L 10/23/2021 - 21:55:24: --------------------------------------------------------------------------
L 10/23/2021 - 21:55:24: Type	IMenuPanel          |	Count	31238
L 10/23/2021 - 21:55:24: Type	GameConfigs         |	Count	1
L 10/23/2021 - 21:55:24: Type	Timer               |	Count	1
L 10/23/2021 - 21:55:24: Type	Trie                |	Count	3
L 10/23/2021 - 21:55:24: --------------------------------------------------------------------------
L 10/23/2021 - 21:55:24: Oldest Living Handle: Timer created at 10/21/2021 - 06:54:11
L 10/23/2021 - 21:55:24: Newest Living Handle: IMenuPanel created at 10/23/2021 - 21:55:05
L 10/23/2021 - 21:55:24: -- Approximately 877820 bytes of memory are in use by (31243) Handles.

L 10/23/2021 - 21:55:24: [SM] Exception reported: Memory leak
L 10/23/2021 - 22:03:43: Error log file session closed.

But is it problematic ? If the plugin got unloaded anyway.

[dustinandband]

After a quick 2 minute search:

PHP Code:

new Handle:tankHud = CreatePanel();
if (!FillTankInfo(tankHud, true)) // No tank -- no HUD
    return Plugin_Handled; 


Handle tankHud gets created in a continuous loop and never gets freed since you need to close the handle before returning Plugin_Handled.

[JLmelenchon]

What should i add?

[dustinandband]

Originally Posted by JLmelenchon What should i add?

Odd that the competitive framework version has the same return without closing the handle, but go ahead and try this

PHP Code:

public Action:HudDrawTimer(Handle:hTimer) 
{
    if (IsInReady() || IsInPause())
        return Plugin_Handled;

    new bool:bSpecsOnServer = false;
    for (new i = 1; i <= MaxClients; i++) 
    {
        if (IsSpectator(i))
        {
            bSpecsOnServer = true;
            break;
        }
    }

    if (bSpecsOnServer) // Only bother if someone's watching us
    {
        new Handle:specHud = CreatePanel();

        FillHeaderInfo(specHud);
        FillSurvivorInfo(specHud);
        FillInfectedInfo(specHud);
        FillTankInfo(specHud);
        FillGameInfo(specHud);

        for (new i = 1; i <= MaxClients; i++) 
        {
            if (!bSpecHudActive[i] || !IsSpectator(i) || IsFakeClient(i))
                continue;

            SendPanelToClient(specHud, i, DummySpecHudHandler, 3);
            if (!bSpecHudHintShown[i])
            {
                bSpecHudHintShown[i] = true;
                CPrintToChat(i, "<{olive}HUD{default}> Escriba {green}!spechud{default} en el chat para alternar el {blue}Espectador HUD{default}.");
            }
        }

        CloseHandle(specHud);
    }
    
    new Handle:tankHud = CreatePanel();
    if (FillTankInfo(tankHud, true))
    {
        for (new i = 1; i <= MaxClients; i++) 
        {
            if (!bTankHudActive[i] || !IsClientInGame(i) || IsFakeClient(i) || IsSurvivor(i) || (bSpecHudActive[i] && IsSpectator(i)))
                continue;

            SendPanelToClient(tankHud, i, DummyTankHudHandler, 3);
            if (!bTankHudHintShown[i])
            {
                bTankHudHintShown[i] = true;
                CPrintToChat(i, "<{olive}HUD{default}> Escriba {green}!tankhud{default} en el chat para alternar el {red}Tank HUD{default}.");
            }
        }
    }
    CloseHandle(tankHud);
    return Plugin_Continue;
}