[evilworm]

Player entity parameter is not NULL, I checked that with debug output to log, but I'm not sure abut INDEXENT output. The is_valid_ent() will not work, because it first checks if player is ingame and then checks INDEXENT. By the way, as I said, I'm doing the kick from the client_authorized() function, which sometimes fails. I guess it's too early to call message_begin() here. However client_putinserver() is not guaranteed to happen before client_authorized(), so I cannot call that one either. Just had a thought that I sould check which one of the functions is called last and execute kick from there (some kinda emulation of OnClientPreAdminCheck function from SourceMod).

[Teyut]

Originally Posted by evilworm Player entity parameter is not NULL, I checked that with debug output to log, but I'm not sure abut INDEXENT output.

The player entity is the result of INDEXENT (it's a pointer). The only reason why the MESSAGE_BEGIN macro (the HLSDK macro) throws that fatal error is when the player entity parameter is NULL with unicast messages.

Originally Posted by evilworm Just had a thought that I sould check which one of the functions is called last and execute kick from there (some kinda emulation of OnClientPreAdminCheck function from SourceMod).

Don't forget to also implement the client_disconnect forward to handle clients that disconnect between the two events.

Originally Posted by ConnorMcLeod Originally Posted by Teyut Fixed, thanks. I didn't know where to find the correct names. Originally Posted by message_const.inc /* Hardcoded message types for message_begin() * Look in the actual HLSDK for details! */

Thanks, but as the preterit tense should have implied: I've already found them .

[Owyn]

so not to get error with MSG_ONE you only need to check

PHP Code:

if (FNullEnt(INDEXENT(iEnt))) 


?

that would be easy, make a new native in engine to check only this and use it, woudn't it?

[hleV]

This is awesome. I wonder which is better: SVC_KICK or SVC_DISCONNECT?

[Arkshine]

SVC_KICK doesn't exist, it's only SVC_DISCONNECT.

[Owyn]

sure it is) but it has problems if you wanna use it before client_putinserver()

just edit engine module and add a new native to check only INDEXENT or add a check

PHP Code:

if (FNullEnt(INDEXENT(iEnt))) 


into

PHP Code:

static cell AMX_NATIVE_CALL message_begin(AMX *amx, cell *params) /* 4 param */ 


why nobody did this before?

[xPaw]

Originally Posted by Owyn sure it is) but it has problems if you wanna use it before client_putinserver()?

Originally Posted by Arkshine SVC_KICK doesn't exist, it's only SVC_DISCONNECT.

[Arkshine]

Originally Posted by Owyn sure it is) but it has problems if you wanna use it before client_putinserver() just edit engine module and add a new native to check only INDEXENT or add a check PHP Code: if (FNullEnt(INDEXENT(iEnt)))  into PHP Code: static cell AMX_NATIVE_CALL message_begin(AMX *amx, cell *params) /* 4 param */  why nobody did this before?

Check yourself you pass a valid player index.

[Owyn]

Check yourself

that's what i did, now i have no problems, just shared a solution =) *it may looks like u haven't read whole thread, there is no way to check it before client_putinserver() *just noticing**


2xPaw,

Originally Posted by hleV This is awesome

Originally Posted by Owyn sure it is)

[ConnorMcLeod]

I suppose is_valid_ent returns true even when players are not connected.