[happy_2012]

Hello,

I am trying to make a weapon system to strip weapons according to flags, and I am trying to do that through cvars

Here is my problem:

PHP Code:

enum
{
    WEAPON_NONE = 0,
    WEAPON_PRIMARY,
    WEAPON_SECONDARY,
    WEAPON_GRENADE
};

#define BITSUM_WEAPON_NONE        ( 1 << WEAPON_NONE )        // -- 1
#define BITSUM_WEAPON_PRIMARY    ( 1 << WEAPON_PRIMARY )        // -- 2
#define BITSUM_WEAPON_SECONDARY    ( 1 << WEAPON_SECONDARY )    // -- 4
#define BITSUM_WEAPON_GRENADE    ( 1 << WEAPON_GRENADE )        // -- 8 


Using client print in the server to trace the problem, I got these:

PHP Code:

    /*
        Prints [should be fixed]:
        -- [ZP] BITSUM_WEAPON_NONE = 1
        -- [ZP] BITSUM_WEAPON_PRIMARY = 2
        -- [ZP] BITSUM_WEAPON_SECONDARY = 4
        -- [ZP] BITSUM_WEAPON_GRENADE = 8

        -- [ZP] g_szWeaponsDropZombie = ab - i_Drop = 3
        -- [ZP] Drop - BITSUM_WEAPON_PRIMARY = 2

        -- [ZP] g_szWeaponsStripZombie = c - i_Strip = 4
        -- [ZP] Strip - BITSUM_WEAPON_SECONDARY = 4
    */ 


Look at the attached SMA for the full code, it will soon be on GitHub, how can I fix it?

[Bugsy]

Not sure that I fully understand what you're trying to resolve but I'll take a stab.

Are you expecting g_szWeaponsDropZombie, which holds flags "ab" to result in a 2 to match BITSUM_WEAPON_PRIMARY?

PHP Code:

        -- [ZP] g_szWeaponsDropZombie = ab - i_Drop = 3
        -- [ZP] Drop - BITSUM_WEAPON_PRIMARY = 2 


If so it's because flags a and b combined give you a resulting integer of 3 (1 << 0 | 1 << 2)

PHP Code:

#define ADMIN_IMMUNITY      (1<<0)  /* flag "a" */
#define ADMIN_RESERVATION   (1<<1)  /* flag "b" */
#define ADMIN_KICK          (1<<2)  /* flag "c" */ 


You can do this to get you to 3

PHP Code:

#define BITSUM_WEAPON_PRIMARY    ( 1 << WEAPON_PRIMARY ) |  ( 1 << WEAPON_NONE ) 


If what I said above is correct, then this is working?

PHP Code:

        -- [ZP] g_szWeaponsStripZombie = c - i_Strip = 4
        -- [ZP] Strip - BITSUM_WEAPON_SECONDARY = 4 


[happy_2012]

Well, I think I am doing flags all wrong, because BITSUM_WEAPON_NONE = 1 which is basically flag a, and I want flag a to be BITSUM_WEAPON_PRIMARY

so it would be like this: BITSUM_WEAPON_PRIMARY is flag "a", BITSUM_WEAPON_SECONDARY is flag "b", and BITSUM_WEAPON_GRENADES is flag "c", and I want to keep BITSUM_WEAPON_NONE as zero or whatever since I am using it for other purposes

EDIT:
Not sure this is idea, but it worked:

PHP Code:

enum
{
    WEAPON_PRIMARY = 0,
    WEAPON_SECONDARY,
    WEAPON_GRENADE,
    WEAPON_NONE
};

#define BITSUM_WEAPON_PRIMARY    ( 1 << WEAPON_PRIMARY )        // -- 1; flag "a"
#define BITSUM_WEAPON_SECONDARY    ( 1 << WEAPON_SECONDARY )    // -- 2; flag "b"
#define BITSUM_WEAPON_GRENADE    ( 1 << WEAPON_GRENADE )        // -- 4; flag "c"
#define BITSUM_WEAPON_NONE        ( 1 << WEAPON_NONE )        // -- 8; flag "d" 


[Bugsy]

You can get rid of the separate #defines with this

PHP Code:

enum WeaponStuff (<<=1)
{
    WEAPON_PRIMARY = 1, //1
    WEAPON_SECONDARY, //2
    WEAPON_GRENADE, //4
    WEAPON_NONE //8
} 


[Natsheh]

Already been done check out the one made by Conner.

[happy_2012]

Originally Posted by Bugsy You can get rid of the separate #defines with this PHP Code: enum WeaponStuff (<<=1) {     WEAPON_PRIMARY = 1, //1     WEAPON_SECONDARY, //2     WEAPON_GRENADE, //4     WEAPON_NONE //8 }

Hey,

If you checked the code, I am using the other non-bitsums for other purposes, so I think (for now?) it is better (for me?) to keep them

Originally Posted by Natsheh Already been done check out the one made by Conner.

Hey,

What is? I don't follow

[Bugsy]

It's no issue to keep it as you have it, given the point you made.

If you want to have a BITSUM_WEAPON_NONE while allowing PRIMARY to be 1, SECONDARY 2, etc. , do the below. It does not appear that you are doing any bit-wise logic on BITSUM_WEAPON_NONE, it's more of just a constant so it if has a -1 value it should not cause issues.

PHP Code:

enum
{
    WEAPON_NONE = -1,  // -1
    WEAPON_PRIMARY, // 0
    WEAPON_SECONDARY, // 1
    WEAPON_GRENADE // 2
};

#define BITSUM_WEAPON_NONE        WEAPON_NONE        // -- -1
#define BITSUM_WEAPON_PRIMARY    ( 1 << WEAPON_PRIMARY )        // -- 1
#define BITSUM_WEAPON_SECONDARY    ( 1 << WEAPON_SECONDARY )    // -- 2
#define BITSUM_WEAPON_GRENADE    ( 1 << WEAPON_GRENADE )        // -- 4 


[happy_2012]

Originally Posted by Bugsy It's no issue to keep it as you have it, given the point you made. If you want to have a BITSUM_WEAPON_NONE while allowing PRIMARY to be 1, SECONDARY 2, etc. , do the below. It does not appear that you are doing any bit-wise logic on BITSUM_WEAPON_NONE, it's more of just a constant so it if has a -1 value it should not cause issues. PHP Code: enum {     WEAPON_NONE = -1,  // -1     WEAPON_PRIMARY, // 0     WEAPON_SECONDARY, // 1     WEAPON_GRENADE // 2 }; #define BITSUM_WEAPON_NONE        WEAPON_NONE        // -- -1 #define BITSUM_WEAPON_PRIMARY    ( 1 << WEAPON_PRIMARY )        // -- 1 #define BITSUM_WEAPON_SECONDARY    ( 1 << WEAPON_SECONDARY )    // -- 2 #define BITSUM_WEAPON_GRENADE    ( 1 << WEAPON_GRENADE )        // -- 4

Thank you very much, I will try it and test it!