[<VeCo>]

What function, what value?

Yes, you should destroy the menu since you don't need it after closing it and there's no need to fill the memory with useless things.

[Bilal Pro]

Originally Posted by Liverwiz He had a bunch of errors in that code. But i got what he was trying to say. That tut that EpicMonkey posted was awesome.

Lol tell me the errors, please.

[mottzi]

Liverwiz for that you'd use the menu's handler.

[Liverwiz]

I'm trying to prompt the user of the menu (admin) a list of possible players to do an action to, then the proper value for the action.

It'd be most efficient to grab the answers one after another then use the chosen vars in a function that deals with it. Code....

switch(selection)
	{
		case 1: // set level
		{
			new menu = menu_create("BKF Admin", "mh_BKFAdmin")
			menu_additem(menu, "Set Player Level", "1", ADMIN_KICK)
			menu_additem(menu, "Set Player Frags", "2", ADMIN_KICK)
			menu_additem(menu, "Give Player Frags", "3", ADMIN_KICK)
			menu_additem(menu, "Prune Vault", "4", ADMIN_BAN)
			menu_additem(menu, "Set CVARs", "5", ADMIN_CFG)

			menu_setprop(menu, MPROP_EXIT, MEXIT_ALL)
			menu_display(id, menu, 0)

			new playerID = mh_playerSelect(id)
			new level = mh_levelMenu(id)
			new frags = setLevel(playerID, level, ADMIN_GRANT)
			new sz_name[34]
			get_user_name(playerID, sz_name, charsmax(sz_name) )
			client_print_color(id, DontChage, "[BKF] ^3%s ^1has been set with %d frags. (level %d)", sz_name, frags, getLevel(playerID) )
		}

That's a snippet from the main menu's choices. It wasn't finished (as you can tell i CPd a lot) because i was called away from my programming nook. But you can see what i want out of it.

[Liverwiz]

Originally Posted by Bilal Pro Lol tell me the errors, please.

You shouldn't have a callback if you didn't set a callback in the menu
Your switch is incomplete
You should ALWAYS have a default: in your switch. (good practice)
Your case's logic should be INSIDE the brackets
You need to CLOSE brackets after your done
You should destroy a menu before you return PLUGIN_HANDLED

And as i was looking back i realized you did close your brackets. But i didn't delete that because it just shows how much white space and indentation adds to readablity of your code. All things you need to work on.

[hornet]

D'you mean something like this?

PHP Code:

public MyPlayerMenu( id )
{
    new iMenu = menu_create( "\ySelect a player", "MyPlayerHandler" );
    
    new iPlayers[ 32 ], iNum, szName[ 32 ], szInfo[ 4 ];
    get_players( iPlayers, iNum );

    for( new i ; i < iNum ; i ++ )
    {
        get_user_name( iPlayers[ i ], szName, charsmax( szName ) );
        num_to_str( iPlayers[ i ], szInfo, charsmax( szInfo ) );
        menu_additem( iMenu, szName, szInfo, 0 );
    }
    
    menu_display( id, iMenu );
} 


And then in your handler you can use the info to refer back to the player's index, and then check if they're still eligible to target for a command?

Btw no need for the double posting - there is an edit button ;)

[Liverwiz]

Originally Posted by hornet And then in your handler you can use the info to refer back to the player's index, and then check if they're still eligible to target for a command?

Oh, so like sending the playerID or something as the data to the handler, which will then get the level from the admin and perform calcs from there? I suppose that could work....we shall see!

Originally Posted by hornet Btw no need for the double posting - there is an edit button ;)

They were different purposes for posting to different people. I felt it'd be best to do it that way. I'm quite familiar with the edit button. I use it when its necessary. For instance: i will edit this to see how it compiles when i'm done. ;)

[hornet]

Originally Posted by Liverwiz Oh, so like sending the playerID or something as the data to the handler, which will then get the level from the admin and perform calcs from there?

Not the admin level, the player index.

[mottzi]

Like hornet showed in the upper example, you can send data to the Handler by using the third parameter of menu_additem()

[Liverwiz]

What do you guys think of this? Its just something i came up with to shorten my code a BIT.

PHP Code:

/*   THIS FUNCTION AUTOMATICALLY SETS THE EXIT (creates a useable menu)
       p_menu is a pointer to the menu that we're going to add the players list to
       source[] is the source menu to keep track of what's going on internally
       itemAccess is the "access" paramater for menu_additem
       getPlayersFlags[] is a string of flags for the get_players command 
       RETURNS: number of players in the list */
mhlp_getPlayerMenu(&p_menu, source[], itemAccess=0, getPlayersFlags[]="ch")
{
    new players[32], plyrCnt
    new sz_name[32], sz_info[8]
    get_players(players, plyrCnt, getPlayersFlags)
    
    for(new i=0; i<plyrCnt; 1++)
    {
        get_user_name(players[i], sz_name, charsmax(sz_name) )
        format(sz_info, charsmax(sz_info), "%s %d", source, players[i])
        menu_additem(p_menu, sz_name, sz_info, itemAccess)
    }
    
    menu_setprop(p_menu, MPROP_EXIT, MEXIT_ALL)
    return playCnt
} 


and that is called like this....

new lvlMn = menu_create("BKF Set Player Level", "mh_setLevel")
mhlp_getPlayerMenu(lvlMn, "I", ADMIN_ALL, "ch")
menu_display(id, lvlMn, 0)

Still writing it.....but i want to make sure its sound before i continue