[Papero]

I cannot understand why I'm getting this error

PHP Code:

L 09/09/2017 - 12:17:50: [SM] Exception reported: Handle 3df4107c is invalid (error 1)
L 09/09/2017 - 12:17:50: [SM] Blaming: zMisc/VipBonus.smx
L 09/09/2017 - 12:17:50: [SM] Call stack trace:
L 09/09/2017 - 12:17:50: [SM]   [0] CloseHandle
L 09/09/2017 - 12:17:50: [SM]   [1] Line 578, VipMenu.sp::Menu_PlayerSpawn 


The block:

PHP Code:

    if (hRegenTimer[client] != INVALID_HANDLE)
    {
        hRegenTimer[client].Close();
        hRegenTimer[client] = INVALID_HANDLE;
    } 


FullCode: https://github.com/Hexer10/VipMenu-B...emod/scripting

[AI_]

Have you tried replacing that block with delete?:

delete hRegenTimer[client];

[Papero]

Originally Posted by AI_ Have you tried replacing that block with delete?: delete hRegenTimer[client];

Yes...

[AI_]

A slight nitpick, but your array initializations only set the first element.

int iArr[4] = 1; // iArr is now {1, 0, 0, 0}

To set them all, use this syntax:

int iArr[4] = {1, ...}; // iArr is now {1, 1, 1, 1}

[Papero]

Originally Posted by AI_ A slight nitpick, but your array initializations only set the first element. To set them all, use this syntax: int iArr[4] = {1, ...};

You are right, but I dont think that is causing the problem.

[AI_]

Looks like there's a chance your timer may be terminated here due to Plugin_Stop:

public Action Timer_Regen(Handle timer, any userid)
{
	int client = GetClientOfUserId(userid);
	if (!IsValidClient(client, false, false))
		return Plugin_Continue;
	int iHealth = GetClientHealth(client);
	if (IsValidClient(client))
	{
		if (!bRegen[client])
			return Plugin_Stop;
		
		if (cv_iRegenMaxHP.IntValue > iHealth)
		{
			if (bRegen[client])
			{
				SetEntityHealth(client, iHealth + cv_iRegenHP.IntValue);
				return Plugin_Continue;
			}
		}
		
		if (!cv_bStopTimer.BoolValue)
			return Plugin_Stop;
		else
			return Plugin_Continue;
	}
	else
	{
		return Plugin_Stop;
	}
}

This will not automatically set hRegenTimer[client] to null but the handle it refers to is no longer valid.

[Zeisen]

Try This: might be solve.

public Action Timer_Regen(Handle timer, any userid)
{
	int client = GetClientOfUserId(userid);
	if (!IsValidClient(client, false, false))
		return Plugin_Continue;
        hRegenTimer[client] = INVALID_HANDLE;
	int iHealth = GetClientHealth(client);
	if (IsValidClient(client))
	{
		if (!bRegen[client])
			return Plugin_Stop;
		
		if (cv_iRegenMaxHP.IntValue > iHealth)
		{
			if (bRegen[client])
			{
				SetEntityHealth(client, iHealth + cv_iRegenHP.IntValue);
				return Plugin_Continue;
			}
		}
		
		if (!cv_bStopTimer.BoolValue)
			return Plugin_Stop;
		else
			return Plugin_Continue;
	}
	else
	{
		return Plugin_Stop;
	}
}

but actually your code has problem..

[Bacardi]

Repeated timer?

...your timers are passing player userid.
But if player disconnect, you not get client index anymore with given userid.
That is one problem.

You could try datatimer to store both clientindex and userid in timer dstapack

Secondly, you need set global Handle to null everytime when timer Plugin_Stop.

[WildCard65]

Timers automatically destroy themselves upon completion (as in no longer going to be calling your plugin's callback function).

[Fyren]

The problem is what AI_ and Bacardi said, when the code takes a path that returns Plugin_Stop in the callback, then your variable will not be set to null/INVALID_HANDLE yet the timer will be invalid. Zeisen's suggested code isn't right because it sets the timer to INVALID_HANDLE even in the path where Plugin_Continue is returned.

Also:

Originally Posted by Bacardi ...your timers are passing player userid. But if player disconnect, you not get client index anymore with given userid. That is one problem.

This is not a problem if you check that the return value of GetClientOfUserId is not zero.