[JusTGo]

i get FATAL ERROR (shutting down): Bad entity in IndexOfEdict(). when using a code this code

PHP Code:

#include < amxmodx >
#include < engine >
#include < fakemeta >
#include < hamsandwich >
#include < xs >

public plugin_init( ) {
    register_clcmd( "say /test", "CmdTest" );
}

public CmdTest(id)
{
    register_forward(FM_TraceLine, "fw_traceline")
}

public fw_traceline(Float:start[3], Float:end[3], conditions, id, trace)
{
    static pHit;
    pHit = get_tr2( trace, TR_pHit );
} 


problem doesn't exist in amxx 1.8.2

[fysiks]

Write a small test plugin that recreates the issue and post that. That is the best way to help fix the issue. Also, make sure that you are using the latest version of the dev version.

[JusTGo]

Originally Posted by fysiks Write a small test plugin that recreates the issue and post that. That is the best way to help fix the issue. Also, make sure that you are using the latest version of the dev version.

after alot of time debuging the code i found that the problem in amxx 1.8.3 only and not on 1.8.2 here is the code to reproduce the error with the lastest amxx dev.

PHP Code:

#include < amxmodx >
#include < engine >
#include < fakemeta >
#include < hamsandwich >
#include < xs >

public plugin_init( ) {
    register_clcmd( "say /test", "CmdTest" );
}

public CmdTest(id)
{
    register_forward(FM_TraceLine, "fw_traceline")
}

public fw_traceline(Float:start[3], Float:end[3], conditions, id, trace)
{
    static pHit;
    pHit = get_tr2( trace, TR_pHit );
} 


[Arkshine]

You're saying that calling get_tr2 with TR_pHit in this forward crashes always the server with the error you mentioned?

[JusTGo]

Originally Posted by Arkshine You're saying that calling get_tr2 with TR_pHit in this forward crashes always the server with the error you mentioned?

i m not sure what is the name of the error cause im on windows now and i m using last amxx 1.8.3 dev and it crashs when i say /test.

edit1:

here is some logs

PHP Code:

L 04/02/2016 - 21:38:15: Log file started (file "cstrike\addons\amxmodx\logs\hlds_crash.log") (game "cstrike") (amx "1.8.3-dev+5044")
L 04/02/2016 - 21:38:15: Sys_Error: [Bad entity in IndexOfEdict()] 


got them with :

PHP Code:

#include <amxmodx>
#include <fakemeta>

new const crash_log[] = "hlds_crash.log"

public plugin_precache()
{
    register_forward(FM_Sys_Error, "fw_Sys_Error")
}

public fw_Sys_Error(const error[])
{
    log_to_file(crash_log, "Sys_Error: [%s]", error)
} 


edit2:
i changed the fakemeta module of amxx "1.8.3-dev+5044" and replaced with with the one from amxx 1.8.2 and problem still exist.

[Arkshine]

Well, you hook as pre, meaning nothing are set in TraceResult yet, so it's possible (and expected) that mod/engine passes some address where memory was not initialized (basically you get garbage), and you get a crash because value is not null, but when engine tries to convert pHit edict to index, result is not a valid player's index. You would get a crash with any AMXX version.

[JusTGo]

i got the code from approved plugin and works with no problems on amxx 1.8.2. so hooking as post will not break plugin functionality and wont crash ?

[Arkshine]

I doubt that code tries to retrieve pHit in such forward as pre. Show me.

This is not a compatibility issue, this is expected it may crash because nothing is set in "trace" at this point. You can't retrieve data which doesn't exist yet.

[JusTGo]

https://forums.alliedmods.net/showthread.php?p=580384

PHP Code:

public fw_traceline(Float:start[3], Float:end[3], conditions, id, trace)
{
    // Spectators don't need to run this.
    if (!is_user_alive(id)) return FMRES_IGNORED
    
    // If we hit a player, don't bother searching for an item nearby.
    if (is_user_alive(get_tr2(trace, TR_pHit))) return FMRES_IGNORED
    
    static Float:endpt[3], tr = 0, i
    
    get_tr2(trace, TR_vecEndPos, endpt)
    
    i = 0
    
    while ((i = engfunc(EngFunc_FindEntityInSphere, i, endpt, 20.0)))
    {
        if (is_shootable_ent(i))
        {
            engfunc(EngFunc_TraceModel, start, end, HULL_POINT, i, tr)
        
            if (pev_valid(get_tr2(tr, TR_pHit)))
            {
                get_tr2(tr, TR_vecEndPos, endpt)
                set_tr2(trace, TR_vecEndPos, endpt)
                
                set_tr2(trace, TR_pHit, i)
                
                return FMRES_IGNORED
            }
        }
    }
    
    return FMRES_IGNORED
} 


[Arkshine]

Code could work if "trace" was equal to 0 because it's allowed to pass 0 with get_tr2(), it will retrieve from the global var but when you look at CS code source, it's unlikely.

His code is wrong, forward should be registered as post to be able to retrieve data from trace result. Supposing "trace" is 0, his code would be still wrong because global var is updated once trace line is done.
You can see other people getting a crash in 2009: https://forums.alliedmods.net/showpo...3&postcount=97