[CryWolf]

I don't see why we need so many optimizations, since we are not using Pentium II CPU-s anymore, and HLDS is an old engine, will work on P2 as well.

I did once, moved the biohazard 1.93 mod to a Metamod module, and wasn't to much optimization, and a completly waste of time, and was well coded.

[HamletEagle]

Originally Posted by CryWolf I don't see why we need so many optimizations, since we are not using Pentium II CPU-s anymore, and HLDS is an old engine, will work on P2 as well.

These sort of "optimizations" wouldn't even make a difference in a Pentium II to be honest.

[Bugsy]

Are you accounting for everything that cs_set_user_armor() does?

PHP Code:

static cell AMX_NATIVE_CALL cs_set_user_armor(AMX *amx, cell *params) // cs_set_user_armor(index, armorvalue, CsArmorType:armortype); = 3 params
{
    // Set armor and set what type and send a message to client...
    // params[1] = user index
    // params[2] = armor value
    // params[3] = armor type (no armor/vest/vest+helmet)

    CHECK_PLAYER(params[1]);

    // Make into edict pointer
    edict_t *pPlayer = MF_GetPlayerEdict(params[1]);

    // Set armor value
    pPlayer->v.armorvalue = params[2];

    // Set armor type
    *((int *)pPlayer->pvPrivateData + OFFSET_ARMORTYPE) = params[3];
    
    if (params[3] == CS_ARMOR_KEVLAR || params[3] == CS_ARMOR_ASSAULTSUIT)
    {
        // And send appropriate message
        MESSAGE_BEGIN(MSG_ONE, GET_USER_MSG_ID(PLID, "ArmorType", NULL), NULL, pPlayer);
        WRITE_BYTE(params[3] == CS_ARMOR_ASSAULTSUIT ? 1 : 0);
        MESSAGE_END();
    }

    return 1;
} 


[mlibre]

Originally Posted by Bugsy Are you accounting for everything that cs_set_user_armor() does?

Which do you think is better compared to entity_set_float

PHP Code:

static cell AMX_NATIVE_CALL entity_set_float(AMX *amx, cell *params)
{
    int iEnt = params[1];
    int idx = params[2];
    REAL fVal = amx_ctof(params[3]);

    CHECK_ENTITY_SIMPLE(iEnt);

    edict_t *pEnt = TypeConversion.id_to_edict(iEnt);

    switch (idx)
    {
        case impacttime:
            pEnt->v.impacttime = fVal;
            break;
        case starttime:
            pEnt->v.starttime = fVal;
            break;
        case idealpitch:
            pEnt->v.idealpitch = fVal;
            break;
        case pitch_speed:
            pEnt->v.pitch_speed = fVal;
            break;
        case ideal_yaw:
            pEnt->v.ideal_yaw = fVal;
            break;
        case yaw_speed:
            pEnt->v.yaw_speed = fVal;
            break;
        case ltime:
            pEnt->v.ltime = fVal;
            break;
        case nextthink:
            pEnt->v.nextthink = fVal;
            break;
        case gravity:
            pEnt->v.gravity = fVal;
            break;
        case friction:
            pEnt->v.friction = fVal;
            break;
        case frame:
            pEnt->v.frame = fVal;
            break;
        case animtime:
            pEnt->v.animtime = fVal;
            break;
        case framerate:
            pEnt->v.framerate = fVal;
            break;
        case health:
            pEnt->v.health = fVal;
            break;
        case frags:
            pEnt->v.frags = fVal;
            break;
        case takedamage:
            pEnt->v.takedamage = fVal;
            break;
        case max_health:
            pEnt->v.max_health = fVal;
            break;
        case teleport_time:
            pEnt->v.teleport_time = fVal;
            break;
        case armortype:
            pEnt->v.armortype = fVal;
            break;
        case armorvalue:
            pEnt->v.armorvalue = fVal;
            break;
        case dmg_take:
            pEnt->v.dmg_take = fVal;
            break;
        case dmg_save:
            pEnt->v.dmg_save = fVal;
            break;
        case dmg:
            pEnt->v.dmg = fVal;
            break;
        case dmgtime:
            pEnt->v.dmgtime = fVal;
            break;
        case speed:
            pEnt->v.speed = fVal;
            break;
        case air_finished:
            pEnt->v.air_finished = fVal;
            break;
        case pain_finished:
            pEnt->v.pain_finished = fVal;
            break;
        case radsuit_finished:
            pEnt->v.radsuit_finished = fVal;
            break;
        case scale:
            pEnt->v.scale = fVal;
            break;
        case renderamt:
            pEnt->v.renderamt = fVal;
            break;
        case maxspeed:
            pEnt->v.maxspeed = fVal;
            break;
        case fov:
            pEnt->v.fov = fVal;
            break;
        case flFallVelocity:
            pEnt->v.flFallVelocity = fVal;
            break;
        case fuser1:
            pEnt->v.fuser1 = fVal;
            break;
        case fuser2:
            pEnt->v.fuser2 = fVal;
            break;
        case fuser3:
            pEnt->v.fuser3 = fVal;
            break;
        case fuser4:
            pEnt->v.fuser4 = fVal;
            break;
        default:
            return 0;
            break;
    }

    return 1;
} 


[CrazY.]

There is set_pev from fakemeta and if you're using reapi, set_entvar, but neither is better than the other, they just offer different functions. Which one to use? well, it depends on what you need. You can include as many modules as you want, just avoid fakemeta_util.

Unless this isn't for counter-strike, I don't see reason for replacing cstrike with say, engine. You need to explain what you're trying to do.

Btw, you'll find some tips for optimizing a plugin in this link.
https://wiki.alliedmods.net/Optimizi...d_X_Scripting)

[hellmonja]

Originally Posted by CrazY. just avoid fakemeta_util.

I've heard this many times. So when I need something in fakemeta_util I copy the function I need into my plugin and access it from there. Is this a better way or the same as using fakemeta_util?...

[CrazY.]

The problem is that some functions make a bunch of calls. Look at fm_give_item for example

stock fm_give_item(index, const item[]) {
    if (!equal(item, "weapon_", 7) && !equal(item, "ammo_", 5) && !equal(item, "item_", 5) && !equal(item, "tf_weapon_", 10))
        return 0;

    new ent = fm_create_entity(item);
    if (!pev_valid(ent))
        return 0;

    new Float:origin[3];
    pev(index, pev_origin, origin);
    set_pev(ent, pev_origin, origin);
    set_pev(ent, pev_spawnflags, pev(ent, pev_spawnflags) | SF_NORESPAWN);
    dllfunc(DLLFunc_Spawn, ent);

    new save = pev(ent, pev_solid);
    dllfunc(DLLFunc_Touch, ent, index);
    if (pev(ent, pev_solid) != save)
        return ent;

    engfunc(EngFunc_RemoveEntity, ent);

    return -1;
}

You could simply replace that with fun's give_item, which is just one line

give_item(id, "weapon_name) 

If you look at fun source, you'll notice that it does almost the same amount of calls as fakemeta_util but it's supposed to be faster.

// native give_item(index, const item[])
static cell AMX_NATIVE_CALL give_item(AMX *amx, cell *params)
{
	enum args { arg_count, arg_index, arg_item };

	CHECK_PLAYER(params[arg_index]);

	auto itemLength = 0;
	const auto item = MF_GetAmxString(amx, params[arg_item], 1, &itemLength);

	if (!itemLength
		||(strncmp(item, "weapon_", 7) != 0
		&& strncmp(item, "ammo_", 5) != 0
		&& strncmp(item, "item_", 5) != 0
		&& strncmp(item, "tf_weapon_", 10) != 0))
	{
		return 0;
	}

	auto pEntity = CREATE_NAMED_ENTITY(ALLOC_STRING(item));

	if (FNullEnt(pEntity))
	{
		MF_LogError(amx, AMX_ERR_NATIVE, "Item \"%s\" failed to create", item);
		return 0;
	}

	const auto pPlayer = TypeConversion.id_to_edict(params[arg_index]);

	pEntity->v.origin = pPlayer->v.origin;
	pEntity->v.spawnflags |= SF_NORESPAWN;

	MDLL_Spawn(pEntity);

	const auto oldSolid = pEntity->v.solid;

	MDLL_Touch(pEntity, pPlayer);

	if (pEntity->v.solid == oldSolid)
	{
		REMOVE_ENTITY(pEntity); // The function did not fail - we're just deleting the item
		return -1;
	}

	return TypeConversion.edict_to_id(pEntity);
}

Avoid when possible, but if you need to use it for some reason, go ahead. If it was that harmful, amxx dev would have already removed it.