[prabalgarina]

I like you'r plugin.
Hope there are no bugs and get approve.

[zacky]

Originally Posted by prabalgarina I like you'r plugin. Hope there are no bugs and get approve.

Thanks ;)

[Arkshine]

Hi.

Some suggestions :

- Use pcvars. You must do it.
- fwStartFrame() : Use static for vars which are not yet. Rearranging the function would not a bad idea. ( Like Nextra )
- check_pistols() : not used ?
- Spawn : avoid to use spawn() native. Use Ham_CS_RoundRespawn.
- Get rid of engine module since you're using fakemeta. entity_[get|set]_*() = pev() ; and EV_*_* = pev_ . Not hard.
- Use TE_TELEPORT instead of 11.
- Using ML ?

Too much to say. I stop there for the moment.

[joaquimandrade]

Originally Posted by arkshine Hi. Some suggestions : - Use pcvars. You must do it. - fwStartFrame() : Use static for vars which are not yet. Rearranging the function would not a bad idea. ( Like Nextra ) - check_pistols() : not used ? - Spawn : avoid to use spawn() native. Use Ham_CS_RoundRespawn. - Get rid of engine module since you're using fakemeta. entity_[get|set]_*() = pev() ; and EV_*_* = pev_ . Not hard. - Use TE_TELEPORT instead of 11. - Using ML ? Too much to say. I stop there for the moment.

My turn:

Change this:

PHP Code:

        give_item(id, "weapon_m3");
        give_item(id, "weapon_xm1014");
        give_item(id, "weapon_mp5navy");    
        give_item(id, "weapon_p90");
        give_item(id, "weapon_mac10");
        give_item(id, "weapon_tmp");
        ...
        give_item(id, "weapon_scout");
        give_item(id, "weapon_awp");
        give_item(id, "weapon_sg550");
        give_item(id, "weapon_g3sg1");
        give_item(id, "weapon_m249");
        give_item(id, "weapon_elite");
        give_item(id, "weapon_fiveseven");
        give_item(id, "weapon_usp");
        give_item(id, "weapon_glock18");
        give_item(id, "weapon_deagle");
        give_item(id, "weapon_p90"); 


To

PHP Code:

ALL_WEAPONS[][] = {"weapon_m3","weapon_xm1014" ...

...

const sizeOfAllWeapons = sizeof ALL_WEAPONS;

for(new i=0;i<sizeOfAllWeapons;i++)
    give_item(id,ALL_WEAPONS[i]); 


Everywhere.

Change this:

PHP Code:

new Data[6];
new Access;
new Callback;
new Name[64];
menu_item_getinfo(mWeaponMenu, item, Access, Data, 5, Name, 63, Callback); 


to this:

PHP Code:

new Data[2];
new Access;
new Callback;
menu_item_getinfo(mWeaponMenu, item, Access, Data, 1, _, _, Callback); 


Everywhere.

This:

PHP Code:

for(new a = 0; a < 33; a++) { 


To:

PHP Code:

for(new a = 1; a < 33; a++) { 


This:

PHP Code:

stock move_to_check(id) {
        new vel[3]={0,0,0};
        kz_velocity_set(id,vel);
...

stock kz_velocity_set(id,vel[3]) {
    //Set Their Velocity to 0 so that they they fall straight down from
    new Float:Ivel[3];
    Ivel[0]=float(vel[0]);
    Ivel[1]=float(vel[1]);
    Ivel[2]=float(vel[2]);
    entity_set_vector(id, EV_VEC_velocity, Ivel);
} 


PHP Code:

move_to_check(id) {
        kz_velocity_set(id,{0.0,0.0,0.0});
...

kz_velocity_set(id,Float:vel[3]) {
        //Set Their Velocity to 0 so that they they fall straight down from
        entity_set_vector(id, EV_VEC_velocity, vel);
} 


You are not using:

PHP Code:

stock kz_velocity_get(id,vel[3]) { 


You are declaring functions as stocks pointlessly.

PHP Code:

new dist = 9999; 


PHP Code:

new dist 


You are not using the function: check_pistols what makes

PHP Code:

 if ( !g_PistolsDisabled ) 


useless


and its better for you because:

PHP Code:

public check_pistols()
{
    /* Determine if we should give players a pistol or not */
    if ( get_cvar_num("sv_checkpistols") )
    {
        set_task(1.0, "check_pistols"); 


Would be a infinite loop.

Check if you can replace your semi-clip code by this:

http://forums.alliedmods.net/showthread.php?t=87690

Declare the constants that you use, in the beginning of the code. (33,96)

Probably there is a better way to check if the user has a weapon but anyway, this:

PHP Code:

for (new i = 0;i < number;i++)
{
    if (wpnList[i] == CSW_GLOCK18)
        foundGlock = true;
    if (wpnList[i] == CSW_USP)
        foundUSP = true;
} 


Should be:

PHP Code:

for (new i = 0;i < number;i++)
{
    new weapon = wpnList[i]

    if (weapon == CSW_GLOCK18)
    {
        foundGlock = true;
        break;
    }
    else if(weapon == CSW_USP)
    {    
        foundUSP = true;
        break;
    }
} 


[YamiKaitou]

PHP Code:

public CheckCheckpoint(id) {
    // Check if they can respawn
    new origin[33][3];
    new dist = 9999;
    for(new a = 0; a < 33; a++) {
        if (is_user_connected(a)) {
            get_user_origin(a,origin[a]);
            dist = get_distance(origin[a],gCheckpointPos[id]);
        }
    }
    return true;
} 


This does absolutely nothing but return true. What is the point of it?

[prabalgarina]

This plugin has 2 warnings, but it works fine anyway.

You can delete this.. because you say you fixed the 2 warnings ... and give some credits to joaquimandrade and YamiKaitou for helping you (this is not a order.. )

[renato127]

The plugin is blocking say commands....

[zacky]

Originally Posted by renato127 The plugin is blocking say commands....

Not for me

[Arkshine]

Your code blocks say command. Return CONTINUE at the end and HANDLED after spawn_func().

[kriixn]

Very good plugin i will test it