[Pawemol12]

Hi,

In Left 4 Dead 2 are 2 good weapons. But one of them is difficult to find. That i try replace this weapon, so as to be equally, you know if an odd number of one weapons will always be more. My way works, but sometimes removes random weapon, so that it is not at all in the game. I do not know why. Here's the code and my function:

min_ilosc is the min count of m60 in the map(it is more important then grenade launcher)

static ReplaceWeapon(min_ilosc)
{
    new granatniki; //count of grenade launchers
    new m60; //count of m60 rifles
    for ( new index = 1; index <= GetMaxEntities(); index++) // Now i'm counting my weapons
    {
        if (IsValidEntity(index))
        {
            if (IsValidEdict(index))
            {
                new String:weapon_name[64];
                GetEdictClassname(index, weapon_name, sizeof(weapon_name));    
                if (StrEqual(weapon_name, "weapon_grenade_launcher_spawn"))
                {
                    granatniki++;
                }
                else if (StrEqual(weapon_name, "weapon_rifle_m60_spawn"))
                {
                    m60++;
                }                    
            }
        }    
    }                
    for ( new index = 1; index <= GetMaxEntities(); index++) // Now I replace weapons, so that it was equally
    {
        if (IsValidEntity(index))
        {
            if (IsValidEdict(index))
            {
                new String:weapon_name[64];
                GetEdictClassname(index, weapon_name, sizeof(weapon_name));    
                if (StrEqual(weapon_name, "weapon_grenade_launcher_spawn"))
                {
                    if (m60 < granatniki || m60 < min_ilosc)
                    {
                        new Float:Location[3];
                        Entity_GetAbsOrigin(index, Location);
                        new Float:Angles[3];
                        GetEntPropVector(index, Prop_Send, "m_angRotation", Angles);
                        RemoveEdict(index);    
                        new replacement = CreateEntityByName("weapon_rifle_m60_spawn");
                        TeleportEntity(replacement, Location, Angles, NULL_VECTOR);                        
                        DispatchKeyValue(replacement, "count", "1");                        
                        DispatchSpawn(replacement);
                        m60++;
                        granatniki--;
                    }
                    else if (StrEqual(weapon_name, "weapon_rifle_m60_spawn"))
                    {
                        if (m60 > granatniki)
                        {
                            new Float:Location[3];
                            Entity_GetAbsOrigin(index, Location);
                            new Float:Angles[3];
                            GetEntPropVector(index, Prop_Send, "m_angRotation", Angles);
                            RemoveEdict(index);    
                            new replacement = CreateEntityByName("weapon_grenade_launcher_spawn");
                            TeleportEntity(replacement, Location, Angles, NULL_VECTOR);                        
                            DispatchKeyValue(replacement, "count", "1");                        
                            DispatchSpawn(replacement);
                            granatniki++;
                            m60--;
                        }
                    }
                }    
            }
        }
    }    
}

[MasterOfTheXP]

Why not just use Stripper:Source to replace entities?

[Pawemol12]

It doesnt support l4d2.

[McFlurry]

Stripper: Source works on all Source Engine versions.

[Pawemol12]

Hmm, yes, but i wont turn so that it was equally Grenade Launcher and M60, can be the difference of one. But i dont know why first entity is remove, and new dont create

Edit:

I note when m60 remove, sometimes grenade launcher dont create

[berni]

you should redo that code anyway, right now it's doing ~20.000 or more native calls.
I recommend using FindEntityByClassname instead.

[Pawemol12]

Hmm, i dont know how to count entities by while loop and FindEntityByClassname. Can you help?

But my code good count the entities, but when replace sometimes it remove entity and dont create new.

[berni]

Originally Posted by Pawemol12 Hmm, i dont know how to count entities by while loop and FindEntityByClassname. Can you help?

you find an example on the same page in the comments (look at the last comment).

And instead of RemoveEdict(index); you should use AcceptEntityInput(index, "Kill");

Originally Posted by Pawemol12 But my code good count the entities, but when replace sometimes it remove entity and dont create new.

if it's good then don't expect support, I personally puked when I looked at the code

[Pawemol12]

Yesterday I tried a while loop, but it still turned the same And on this page does not count as a while loop.

Now my code look like:

new ilosc[38]; //jest 38 broni, a na index 0 nic nie daje
for ( new index = 65; index <= GetMaxEntities(); index++)    
{
    if (IsValidEntity(index))
    {
        if (IsValidEdict(index))
        {
            new String:weapon_name[64];
            GetEdictClassname(index, weapon_name, sizeof(weapon_name));
            if (StrEqual(weapon_name, "weapon_rifle_m60_spawn") || StrEqual(weapon_name, "weapon_grenade_launcher_spawn"))
            {
                new id = GetEntProp(index, Prop_Send, "m_weaponID", 4);
                ilosc[id]++;
            }
        }
    }
}    
new index = -1;
new prev = 0;
while ((index = FindEntityByClassname(index, "weapon_rifle_m60_spawn")) != -1 && ilosc[GRENADE_LAUNCHER] + 1 < ilosc[M60])
{
    if (prev);
    {    
        if (IsValidEntity(prev))
        {
            new Float:Location[3];
            Entity_GetAbsOrigin(prev, Location);
            new Float:Angles[3];
            GetEntPropVector(prev, Prop_Send, "m_angRotation", Angles);
            Entity_Kill(prev);
            new index2 = CreateEntityByName("weapon_grenade_launcher_spawn");
            Entity_SetModel(index2, "models/w_models/weapons/w_grenade_launcher.mdl");
            SetEntProp(index2, Prop_Send, "m_weaponID", GRENADE_LAUNCHER);
            TeleportEntity(index2, Location, Angles, NULL_VECTOR);
            DispatchKeyValue(index2, "count", "1");
            DispatchSpawn(index2);                                
            ilosc[GRENADE_LAUNCHER]++;
            ilosc[M60]--;
        }    
    }
    prev = index;
}

And still new entities remove (dont create new entity) Maybe I must do a timer to delay create. Idk, becouse sometimes entity is create, but not always.

Btw. In map start entity normal create. But when restart round it doesnt create, but remove old entity.

[berni]

Since you tried so hard, I decided to rewrite your code a bit,
now it should be a bit easier to debug any problems.

with removing a random weapon, do you mean the weapon you tried to spawn did not get created ?
It could be Left4Dead2 itself, I think this game has some weird logic that on certain map it only allows a certain amount of weapons if I remember correctly.

PHP Code:

stock GetEntityCountByClassName(const String:className[])
{
    new count=0;

    new entity = -1;
    while ((entity = FindEntityByClassname(entity, className)) != INVALID_ENT_REFERENCE) {
        count++;
    }

    return count;
}

stock ReplaceWeaponByAnotherWeapon(const String:classNameToFind[], const String:classNameToCreate[], const String:model[], weaponId, max)
{
    new x=0;

    new entity = -1;
    while ((entity = FindEntityByClassname(entity, classNameToFind)) != INVALID_ENT_REFERENCE) {

        if (x >= max) {
            return;
        }

        new Float:location[3];
        new Float:angles[3];

        Entity_GetAbsOrigin(entity, location);
        GetEntPropVector(entity, Prop_Send, "m_angRotation", angles);

        // Mark the entity to kill, but this will be delayed to the next frame, so it's still valid
        Entity_Kill(entity);

        new newEntity = CreateEntityByName(classNameToCreate);
        Entity_SetModel(newEntity, model);
        SetEntProp(newEntity, Prop_Send, "m_weaponID", weaponId);
        TeleportEntity(newEntity, location, angles, NULL_VECTOR);
        DispatchKeyValue(newEntity, "count", "1");
        DispatchSpawn(newEntity);

        x++;
    }
}

yourFunction() {
    new countM60                = GetEntityCountByClassName("weapon_rifle_m60_spawn");
    new countGrenadeLauncher    = GetEntityCountByClassName("weapon_grenade_launcher_spawn");

    if (countM60 > countGrenadeLauncher) {
        ReplaceWeaponByAnotherWeapon(
            "weapon_rifle_m60_spawn",
            "weapon_grenade_launcher_spawn",
            "models/w_models/weapons/w_grenade_launcher.mdl",
            GRENADE_LAUNCHER
            RoundFloat((countM60 - countGrenadeLauncher) / 2))
        );
    }
    else if (countM60 > countM60) {
        ReplaceWeaponByAnotherWeapon(
            "weapon_grenade_launcher_spawn",
            "weapon_rifle_m60_spawn",
            "models/w_models/weapons/w_m60.mdl",
            M60,
            RoundFloat((countGrenadeLauncher - countM60) / 2))
        );
    }
}