[mug1wara]

Should've used StrContains, also:

if (StrContains(sReason, "VAC", false) != -1)

[Bacardi]

hmmm. It was long time I had this kind plugin.
And I remember something that there is tiny differences with VAC message between windows and linux server...
I'm not 100% sure.

But last time I used this
*edit
And this works only when event player_disconnect happen. (VAC banned player try join in server or have been kicked by server.)

PHP Code:

if(StrEqual(reason, "VAC banned from secure server\n", true)) 


[adska]

Thanks all for solution

[TheWhitesmith]

Originally Posted by Drixevel PHP Code: #include <sourcemod>  public void OnPluginStart()  {      HookEvent("player_disconnect", Event_Disconnect);  }  public void Event_Disconnect(Event event, const char[] name, bool dontBroadcast)  {      char sReason[256];      event.GetString("reason", sReason, sizeof(sReason));            if (StrContains(sReason, "VAC") != -1)     {          //action     }  }  This makes more sense.

This is very wrong, people may get kicked by VAC but they aren't really VAC Banned.
Example: "Disconnect: VAC authentication error" (when you open Cheat Engine or Process Hacker 2 while playing on VAC-Protected server)

[Drixevel]

Originally Posted by TheWhitesmith This is very wrong, people may get kicked by VAC but they aren't really VAC Banned. Example: "Disconnect: VAC authentication error" (when you open Cheat Engine or Process Hacker 2 while playing on VAC-Protected server)

"Very wrong" might be an overreach but I see your point.

[Visual77]

Originally Posted by Drixevel "Very wrong" might be an overreach but I see your point.

he's right about it being "very wrong". strequal should be used when the same word re-appears in different kick messages.

[backwards]

Originally Posted by Visual77 he's right about it being "very wrong". strequal should be used when the same word re-appears in different kick messages.

Not exactly, he's still technically correct. it just requires more checks to work as intended. Just combined it with "StrContains" check for not containing "authentication" and other phrases associated with false VAC related disconnection issues.

[DarkDeviL]

Originally Posted by 1337norway Just combined it with "StrContains" check for not containing "authentication" and other phrases associated with false VAC related disconnection issues.

Sounds very lousy, when you have the option do it "properly" like shown in Bacardi's example in Post #12.

The least you can do when making plugins, is try to do them right.

[backwards]

Originally Posted by arne1288 Sounds very lousy, when you have the option do it "properly" like shown in Bacardi's example in Post #12. The least you can do when making plugins, is try to do them right.

I wouldn't say it's "lousy" as that method Bacardi posted would break easily if the message string was slightly changed in the future. The dynamic way (my suggestion) would be more appropriate for the long term. It's ignorant to believe there's a "proper" way when it comes to something as contrasted as programming.

[DarkDeviL]

Originally Posted by 1337norway I wouldn't say it's "lousy" as that method Bacardi posted would break easily if the message string was slightly changed in the future. The dynamic way (my suggestion) would be more appropriate for the long term. It's ignorant to believe there's a "proper" way when it comes to something as contrasted as programming.

Cutting corners and claiming to be "future proof", especially when you never know what happens in the future, and when it will lead to false positives; that is clearly "lousy".

The ignorant way, to take your word, would be check multiple StrEqual/StrContains, when you have the option right now to do it right and use one single, that wouldn't cause a single false positive.

You have some options and things available right now, those are the only things you can depend on at the time being. If things change in the future, you should adjust things at that time in the future.

A "Ban By VAC", to quote the title, is related to when a user is VAC banned, and NOT when there are anything else related to the VAC system, that isn't the exact ban.