[ambn]

hi everyone, yesterday i tried to create a plugin that catch player's ip who attempts to SendNetMsg (flooding server using several console commands + sometimes happens on player join), so i'm catching the console message with PTaH extension and will give it as an input for this function and the result which is going to be stored into the string should be an ip but it's just an empty string, here is my code + The numbers match is always 0:

PHP Code:

bool getAttackerIp(const char[] attackInput, char[] ipOutAttack, int maxlen)
{
    if(StrContains(attackInput, "SendNetMsg", false) != -1)
    {
        //char ipRegexMatch[32];
        //Format(ipRegexMatch, sizeof(ipRegexMatch), "(\d+\.\d+\.\d+\.\d+)");
        Regex regex = CompileRegex("(\\d+\\.\\d+\\.\\d+\\.\\d+)");
        int numMatched = regex.Match(attackInput);
        PrintToServer("numMatch : %d", numMatched);
        if(numMatched != -1)
        {
            char ipGet[64];
            regex.GetSubString(0, ipGet, sizeof(ipGet));
            Format(ipOutAttack, maxlen, "%s", ipGet);
            return true;
        }
        else
        {
            return false;
        }
    }
    else
    {
        return false;
    }
} 


any help?
NOTE: i've tested the regular expression code and i'm sure which that is not the problem.

[Fyren]

This complete test plugins works as expected:

PHP Code:

#include <regex>

public Action test(int client, int args)
{
        char out[64];
        test2("lksjflkdsfSendNetMsglkjsdflks 1.2.3 skljdfldksj 1.2.3.4lkjsdflk", out, sizeof(out));
        PrintToServer("ret: %s", out);
}

void test2(char[] s, char[] out, int len) {
        if(StrContains(s, "SendNetMsg", false) != -1)
        {
                Regex regex = CompileRegex("(\\d+\\.\\d+\\.\\d+\\.\\d+)");
                int numMatched = regex.Match(s);
                PrintToServer("numMatch : %d", numMatched);
                regex.GetSubString(0, out, len);
        }
}

public void OnPluginStart() {
        RegConsoleCmd("regextest", test);
} 


The problem is probably not in the code you provided.

You don't need the parentheses in the regex because the match at index 0 will be what matched the entire regex. The match at index 1 will be what matched the first subgroup (which will be the same thing). You also don't need to compile the regex every time, just once.

[ambn]

well the post has got a little old but i haven't been able to get it working til now, any suggestions? here's my code , what's is really the problem?

PHP Code:

stock void getAttackerIP(const char[] message, char[] ip, int maxlen)
{
    Regex regex = CompileRegex("\\d+\\.\\d+\\.\\d+\\.\\d+");
    int numMatched = regex.Match(message);
    PrintToServer("numMatch : %d", numMatched);
    regex.GetSubString(0, ip, maxlen);
} 


the matchNum is 0 and the string is empty..

[Fyren]

Originally Posted by Fyren The problem is probably not in the code you provided.

Once again:

PHP Code:

#include <regex>

public void OnPluginStart() {
        RegConsoleCmd("regextest", test);
}

public Action test(int client, int args)
{
        char out[64];
        getAttackerIP("lksjflkdsfSendNetMsglkjsdflks 1.2.3 skljdfldksj 1.2.3.4lkjsdflk", out, sizeof(out));
        PrintToServer("ret: %s", out);
}

stock void getAttackerIP(const char[] message, char[] ip, int maxlen)
{
        Regex regex = CompileRegex("\\d+\\.\\d+\\.\\d+\\.\\d+");
        int numMatched = regex.Match(message);
        PrintToServer("numMatch : %d", numMatched);
        regex.GetSubString(0, ip, maxlen);
} 


regextest
numMatch : 1
ret: 1.2.3.4

[ambn]

awh well thanks for clearing that, i might have just to figure out what's wrong with the input rather than the regular expression.