Damage message, help with DamageType - Page 3

**Bugsy** · *Last edited by Bugsy; 09-09-2017 at 12:09.*

Try this and see what the output is when you shoot someone:

PHP Code:


			
RegisterHam( Ham_TakeDamage , "player" , "TakeDamage_Post" , true ); 

public TakeDamage_Post( Victim , Inflictor , Attacker , Float:fDamage , bitDamage ) 
{     
    client_print( Attacker , print_chat , "Damage=%f bitDamage=%d" , fDamage , bitDamage )

Reel mafioso · *Last edited by Reel mafioso; 09-09-2017 at 12:47.*

Quote:

Originally Posted by Bugsy

Try this and see what the output is when you shoot someone:

PHP Code:


			
RegisterHam( Ham_TakeDamage , "player" , "TakeDamage_Post" , true ); 

public TakeDamage_Post( Victim , Inflictor , Attacker , Float:fDamage , bitDamage ) 
{     
    client_print( Attacker , print_chat , "Damage=%f bitDamage=%d" , fDamage , bitDamage )

I did that and it prints "32" for fall damage
Sure enough I've then changed
(in my original code to test it)

Code:

 
register_event("Damage", "takedamage","b", "2>1",); 
into
register_event("Damage", "takedamage","b", "2>1", "3!32");

Which didn't change a thing, you would still get healed from fall damage.

Code:

 
register_event("Damage", "takedamage","b", "2>1", "3!32");
into
register_event("Damage", "takedamage","b", "2>1", "3!=32");

This did prevent fall damage healing, but also, again, prevented healing at all.
Did you attempt to run my code with

Code:

 register_event("Damage", "takedamage","b", "2>1", "3=2");

in CS 1.6?
If it did truly work there then I am baffled as to why it doesn't in Czero.

**Bugsy** · 09-09-2017 , 12:49 Re: Damage message, help with DamageType

Does the Ham_TakeDamage method work in CZero? Is this where you tested fall damage? Please forget about using the "Damage" event method.

Reel mafioso · 09-09-2017 , 12:54 Re: Damage message, help with DamageType

Quote:

Originally Posted by Bugsy

Does the Ham_TakeDamage method work in CZero? Is this where you tested fall damage? Please forget about using the "Damage" event method.

Yes all tests I'm doing are for czero.

**Bugsy** · 09-09-2017 , 12:57 Re: Damage message, help with DamageType

Ok, then take damage hook is working fine for czero if you get output for fall damage. What exactly is not working with my latest code above?

Reel mafioso · *Last edited by Reel mafioso; 09-09-2017 at 13:01.*

Quote:

Originally Posted by Bugsy

Ok, then take damage hook is working fine for czero if you get output for fall damage. What exactly is not working with my latest code above?

Health setting is not working. It just does nothing.
What about using get_user_attacker in some way?

**Bugsy** · *Last edited by Bugsy; 09-09-2017 at 13:05.*

To make sure that code is getting reached, please put a client_print above the set_user_health() line. Also, this may be obvious, set_user_health() will only trigger for bullet damage. Are you testing this when shooting someone?

PHP Code:


			
client_print( Attacker , print_chat , "setting health" );
set_user_health( Attacker , clamp( floatround( ( (fDamage * 0.6 ) + health ) ) , 1 , 100 ) );

You should do this type of debugging when you find issues like this. When you find the location of an issue, you can then ask how to resolve it. For example, if that client_print() never fires, then we no there is something not right with the conditions above.

Natsheh · 09-09-2017 , 13:08 Re: Damage message, help with DamageType

Wait are you testing on czero bots?

Reel mafioso · 09-09-2017 , 13:11 Re: Damage message, help with DamageType

Quote:

Originally Posted by Bugsy

To make sure that code is getting reached, please put a client_print above the set_user_health() line. Also, this may be obvious, set_user_health() will only trigger for bullet damage. Are you testing this when shooting someone?

PHP Code:


			
client_print( Attacker , print_chat , "setting health" );

set_user_health( Attacker , clamp( floatround( ( (fDamage * 0.6 ) + health ) ) , 1 , 100 ) );

You should do this type of debugging when you find issues like this. When you find the location of an issue, you can then ask how to resolve it. For example, if that client_print() never fires, then we no there is something not right with the conditions above.

Code:

 public TakeDamage_Post( Victim , Inflictor , Attacker , Float:fDamage , bitDamage ) 
{     
	client_print( Attacker , print_chat , "Function got called" );
    if ( bitDamage & DMG_BULLET )
    {
		client_print( Attacker , print_chat , "Passed damage type check" );
        new Float:fDamageTake , health;
        new iWeapon = get_user_weapon( Attacker , _ , _ ) ;
        
        if ( ( g_iClipAmmo[ Attacker ][ iWeapon ] > 0 ) && ( ( health = get_user_health( Attacker ) ) < 100 ) ) 
        {
            pev( Victim , pev_dmg_take , fDamageTake );
            client_print( Attacker , print_chat , "setting health" );
            set_user_health( Attacker , clamp( floatround( fDamageTake * 0.6 ) + health , 1 , 100 ) );
            //emit_sound(attackerid, CHAN_WEAPON, "misc/arrow_impact_crossbow_heal.wav", 0.7, ATTN_NORM, 0, PITCH_NORM);
        }
    }
    
    return PLUGIN_HANDLED
}

Yes ofc I'm doing damage with bullets. It only reached to "function got called" print, which means that its probably failing the damagetype check which I suspected was going on all the time.

**Bugsy** · *Last edited by Bugsy; 09-09-2017 at 13:12.*

Ok, get me the bitDamage value when bullet damage occurs. Replace function got called print with the below:

PHP Code:


			
client_print( Attacker , print_chat , "bitDamage=%d" , bitDamage );